Page MenuHomePhabricator

don't add email addresses to CC if they are already in TO

Authored by talshiri on Jul 18 2014, 1:18 AM.



Some mailers remove the duplicate entries themselves, but some (Mailgun) don't.
This affects installations with set to false, and will cause

  • ugly looking "to" entries. Gmail, for example, collapses to+cc entries to one list, so you get something that looks like "to: me me john"
  • It sometimes causes duplicate delivery of the same message when used in conjuction with Google Groups. I suspect that their message de-dup mechanism is confused by it (I fuzzed it directly with Mailgun, and saw the same message delivered twice - once directly through mailgun, and bounced again through Google Groups). This doesn't happen when the entries are not duplicated.
Test Plan

Created some tasks. Added subscribers. Things seem to work reasonably well.

Diff Detail

rP Phabricator
Lint Skipped
Unit Tests Skipped

Event Timeline

talshiri retitled this revision from to don't add email addresses to CC if they are already in TO.
talshiri updated this object.
talshiri edited the test plan for this revision. (Show Details)
talshiri added a reviewer: epriestley.
epriestley edited edge metadata.

This is bad if you have "Cc" mail client rules and expect them to identify objects you're subscribed to, but in theory everyone "should" be using X-Phabricator-Cc, and I'm not sure this rule is useful anyway.

This revision is now accepted and ready to land.Jul 18 2014, 1:32 AM
epriestley updated this revision to Diff 23975.

Closed by commit rP570a78d42af7 (authored by @talshiri, committed by @epriestley).