Paths

Table of Contentst

restored --head support
ClosedPublic
Actions

Authored by talshiri on Sep 8 2014, 8:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 9:04 PM

	Unknown Object (File)
	Sat, Jan 25, 1:09 PM

	Unknown Object (File)
	Thu, Jan 23, 4:21 PM

	Unknown Object (File)
	Thu, Jan 23, 4:21 PM

	Unknown Object (File)
	Thu, Jan 23, 4:21 PM

	Unknown Object (File)
	Tue, Jan 21, 9:15 AM

	Unknown Object (File)
	Dec 31 2024, 1:22 PM

	Unknown Object (File)
	Dec 24 2024, 3:07 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCec35375e96ad: restored --head support

Summary

the call to setHeadCommit() was accidentally placed in a if ($background) {} block, which was removed in 54bea94. This adds the removed call.

Test Plan

used --head, worked as expected

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

talshiri updated this revision to Diff 25123.Sep 8 2014, 8:52 PM

talshiri retitled this revision from to restored --head support.

talshiri updated this object.

talshiri edited the test plan for this revision. (Show Details)

talshiri added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 8 2014, 8:52 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2469: Diff 25123.Sep 8 2014, 8:53 PM

epriestley accepted this revision.Sep 8 2014, 9:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2014, 9:02 PM

Closed by commit rARCec35375e96ad (authored by @talshiri, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

6 lines

Diff 25124

View Options

src/workflow/ArcanistDiffWorkflow.php

restored --head supportClosedPublicActions