Page MenuHomePhabricator

Use `git diff a b` for ranges, not `git diff a..b`
ClosedPublic

Authored by epriestley on Jul 11 2014, 4:57 PM.
Tags
None
Referenced Files
F18029963: D9898.id23770.diff
Sat, Aug 2, 11:27 PM
F17952786: D9898.id23763.diff
Fri, Aug 1, 2:21 AM
F17948589: D9898.id.diff
Thu, Jul 31, 9:32 PM
F17940690: D9898.diff
Thu, Jul 31, 4:40 AM
F17939898: D9898.id.diff
Thu, Jul 31, 3:37 AM
F17924376: D9898.diff
Wed, Jul 30, 9:55 AM
Unknown Object (File)
Jul 4 2025, 8:23 PM
Unknown Object (File)
Jul 2 2025, 4:55 AM
Subscribers

Details

Summary

These are documented as being identical, but git diff a b works if a is a tree (for example, 4b825d..., the empty tree hash), but git diff a..b does not.

Particularly, with the a..b form, arc diff --base arc:empty does not work. With the a b form, it does.

Test Plan

Ran arc diff --base arc:empty in a repository and got a diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use `git diff a b` for ranges, not `git diff a..b`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: talshiri, btrahan.
talshiri edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2014, 5:43 PM
epriestley updated this revision to Diff 23770.

Closed by commit rARCf9f2092246d2 (authored by @epriestley).