Page MenuHomePhabricator

Use `git diff a b` for ranges, not `git diff a..b`
ClosedPublic

Authored by epriestley on Jul 11 2014, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 11:00 PM
Unknown Object (File)
Sat, Dec 14, 4:21 PM
Unknown Object (File)
Tue, Dec 10, 1:18 PM
Unknown Object (File)
Mon, Dec 9, 4:01 PM
Unknown Object (File)
Sat, Dec 7, 11:57 AM
Unknown Object (File)
Sat, Dec 7, 1:22 AM
Unknown Object (File)
Tue, Dec 3, 2:21 PM
Unknown Object (File)
Sat, Nov 30, 4:44 PM
Subscribers

Details

Summary

These are documented as being identical, but git diff a b works if a is a tree (for example, 4b825d..., the empty tree hash), but git diff a..b does not.

Particularly, with the a..b form, arc diff --base arc:empty does not work. With the a b form, it does.

Test Plan

Ran arc diff --base arc:empty in a repository and got a diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use `git diff a b` for ranges, not `git diff a..b`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: talshiri, btrahan.
talshiri edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2014, 5:43 PM
epriestley updated this revision to Diff 23770.

Closed by commit rARCf9f2092246d2 (authored by @epriestley).