Page MenuHomePhabricator

Add addLinkSection to MailBody to properly format URIs
ClosedPublic

Authored by chad on Oct 30 2014, 5:33 PM.

Details

Summary

Fixes T6343. Grepped for all callsites and added addLinkSection where needed.

Test Plan

Tested Differential, Maniphest, Conpherence, Ponder and Macro. Inspect HTML mail for anchor tags. Inspect text mails for non-disruption.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 25830.Oct 30 2014, 5:33 PM
chad retitled this revision from to Add addLinkSection to MailBody to properly format URIs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added inline comments.Oct 30 2014, 5:39 PM
src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
89

should I wrap this in another div?

btrahan accepted this revision.Oct 30 2014, 5:50 PM
btrahan edited edge metadata.

Nice!

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
89

idk... want to give something like this a whirl?

https://litmus.com/email-testing

theoretically each and every html email client may render it differently. I also feel fine just letting users report rendering issues as they come up.

107–109

this site will need updating too

This revision is now accepted and ready to land.Oct 30 2014, 5:50 PM

Looks good, although it won't fix inline links (in comments and such)

chad added a comment.Oct 30 2014, 10:23 PM

Tried Litmus, things looked good. It might be worth signing up.

This revision was automatically updated to reflect the committed changes.