Improve out-of-the-box compatability with Mail.app's threading
Needs ReviewPublic
Actions

Authored by talshiri on Jun 25 2014, 12:10 AM.

Details

Reviewers

epriestley
valleysgirl76

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1735: Improve implementation of "Re:" prefix by dropping it from messages which are unambiguously first-in-thread

Summary

Mail.app is a little touchy about how it does threading.
If your mail adapter supports the Message-ID email header AND follow-up messages are prefixed with "Re: ",
it will correctly thread messages together.

This change changes the behavior of subject consturction:

when metamta.re-prefix is false, Phabricator will prefix "Re: " to follow up messages ONLY, which seems like the sensible thing to do in most cases. This has no negative side-effects as far as I can tell, and it makes Mail.app "just work" if your adapter supports Message-IDs.
when metamta.re-prefix is true, it retains the previous behavior of prefixing "Re: " to all messages, including the first one. This is a hack that's only required when your adapter doesn't support Message-IDs (like Amazon SNS & SendGrid. Is this still the case?)

metamta.re-prefix probably needs to be renamed to something else (metamta.force-re-prefix ?) and have a migration script added.

Test Plan

Tested on Gmail and Mail.app, with various combinations (metamta.can-send-as-user turned on and off). Threading now just works, and the topics aren't uglified by it (since the first message is not prefixed with "Re: ")

Diff Detail

Repository

rP Phabricator

Branch

improved_mail.app_support

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1372
Build 1372: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri updated this revision to Diff 23330.Jun 25 2014, 12:10 AM

talshiri retitled this revision from to Improve out-of-the-box compatability with Mail.app's threading.

talshiri updated this object.

talshiri edited the test plan for this revision. (Show Details)

talshiri added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 25 2014, 12:10 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1372: Diff 23330.Jun 25 2014, 12:11 AM

talshiri updated this object.Jun 25 2014, 12:13 AM

talshiri edited edge metadata.

One clarification: the only requirement for this to work is knowing what the Message-ID of the message is.

Amazon seems to return some identifier, but it's not clear if this is related to the Message-ID header (I don't have a SNS account to test this).
SendGrid: Couldn't find any documentation about this. Don't have an account there either.