Page MenuHomePhabricator

basic diff highlighting for html emails
AbandonedPublic

Authored by talshiri on Aug 15 2014, 7:59 PM.

Details

Summary

This adds super basic highlighting for diffs. It's nowhere nearly as good as the built-in one Phabricator has, but it's trivial to add and makes HTML emails more useful.
We can get rid of it once we figure out something nicer.

Test Plan

Created some diffs, emails looked appropriately colorful.

Diff Detail

Repository
rP Phabricator
Branch
colorful_diffs_for_html_emails
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 2250
Build 2254: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri updated this revision to Diff 24758.Aug 15 2014, 7:59 PM
talshiri retitled this revision from to basic diff highlighting for html emails.
talshiri updated this object.
talshiri edited the test plan for this revision. (Show Details)
talshiri added a reviewer: epriestley.
chad added a subscriber: chad.Aug 20 2014, 1:07 AM

Screenshot?

epriestley requested changes to this revision.Nov 23 2015, 3:44 PM
epriestley edited edge metadata.

See T9790 for less-basic plans.

This revision now requires changes to proceed.Nov 23 2015, 3:44 PM
talshiri abandoned this revision.Nov 23 2015, 6:28 PM
scode added a subscriber: scode.Mar 29 2016, 11:56 PM