Page MenuHomePhabricator

Tweak error and status messages for commit ranges
ClosedPublic

Authored by epriestley on Jun 11 2014, 10:30 PM.

Details

Summary

Improve/clarify some error messages a bit, hopefully.

Test Plan

Ran arc which, arc diff, etc., with various explicit, implicit, and --head flags. Read error messages, didn't catch anything too awkward.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley retitled this revision from to Tweak error and status messages for commit ranges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: talshiri.
  • Use %R ("Readable Argument") in the Mercurial construction.
talshiri added inline comments.Jun 11 2014, 10:52 PM
src/repository/api/ArcanistGitAPI.php
132

getBaseCommit() returns a SHA?

149–153

This is exactly infinite time better than my phrasing

epriestley added inline comments.Jun 11 2014, 10:56 PM
src/repository/api/ArcanistGitAPI.php
132

It may or may not return a SHA. If invoked as arc diff X, it will return a SHA, but if a --base rule is used to figure it out it may not.

talshiri accepted this revision.Jun 11 2014, 10:58 PM
talshiri edited edge metadata.
talshiri added inline comments.
src/repository/api/ArcanistGitAPI.php
132

oic

This revision is now accepted and ready to land.Jun 11 2014, 10:58 PM
epriestley closed this revision.Jun 11 2014, 11:35 PM
epriestley updated this revision to Diff 22746.

Closed by commit rARC9492b4ecba12 (authored by @epriestley).