Page MenuHomePhabricator

lintCommit column is not large enough to hold some svn URIs.
Open, Needs TriagePublic

Description

The lintCommit column in phabricator_repository.repository_branch is defined as VARCHAR(40). I assume this is based on the largest size of git or mercurial hashes. But with svn, the lintCommit column is populated with a value that includes the repository URI, which can grow arbitrarily longer than this.

I set my local copy to VARCHAR(255) and now the save_lint.php script is working without errors, but I don't know if this is enough to cover any reasonable case.

Event Timeline

jasonrumney raised the priority of this task from to Needs Triage.
jasonrumney updated the task description. (Show Details)
jasonrumney added a project: Repositories.
jasonrumney added a subscriber: jasonrumney.