Page MenuHomePhabricator
Feed All Stories

Mar 8 2018

epriestley added a revision to T5258: Memes use older image transform code without modern error handling: Restricted Differential Revision.
Mar 8 2018, 6:50 PM · Restricted Project, Files, Macros
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Restricted Differential Revision.
Mar 8 2018, 5:38 PM · Remarkup, Security, Macros
epriestley added a revision to T5258: Memes use older image transform code without modern error handling: Restricted Differential Revision.
Mar 8 2018, 5:38 PM · Restricted Project, Files, Macros
epriestley added a revision to T5258: Memes use older image transform code without modern error handling: Unknown Object (Differential Revision).
Mar 8 2018, 4:31 PM · Restricted Project, Files, Macros
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 4:31 PM · Remarkup, Security, Macros
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 8 2018, 4:27 PM · Plans
epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

Actually, HTML mail has an issue now.

Mar 8 2018, 4:00 PM · Remarkup, Security, Macros
epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

This is technically fixed now but the meme stuff is real old and rough so I'm going to maybe make some kind of effort to get through more of T5258, etc.

Mar 8 2018, 3:56 PM · Remarkup, Security, Macros
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 3:40 PM · Remarkup, Security, Macros
epriestley closed T12542: Build a macro typeahead as Wontfix.

This is conceptually easy but no trigger character really makes a ton of sense. I'm going to decline this until it's more clear what the desired behavior actually is.

Mar 8 2018, 3:09 PM · Macros, Remarkup
epriestley closed T4190: Rebuild remarkup image proxying as Resolved by committing Restricted Diffusion Commit.
Mar 8 2018, 3:04 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I've removed the requirement that prototypes be enabled and marked this as fixed in D19195. The behavior could probably be refined, but I think it should fail in an obvious way when it fails, now.

Mar 8 2018, 3:02 PM · Contributor Onboarding, Remarkup
epriestley added a revision to T4190: Rebuild remarkup image proxying: Restricted Differential Revision.
Mar 8 2018, 3:00 PM · Contributor Onboarding, Remarkup
epriestley added a revision to T4190: Rebuild remarkup image proxying: Unknown Object (Differential Revision).
Mar 8 2018, 2:51 PM · Contributor Onboarding, Remarkup
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 2:51 PM · Remarkup, Security, Macros
epriestley added a revision to T4190: Rebuild remarkup image proxying: Unknown Object (Differential Revision).
Mar 8 2018, 1:36 PM · Contributor Onboarding, Remarkup
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 1:36 PM · Remarkup, Security, Macros
epriestley added a revision to T4190: Rebuild remarkup image proxying: Unknown Object (Differential Revision).
Mar 8 2018, 1:03 PM · Contributor Onboarding, Remarkup
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 1:03 PM · Remarkup, Security, Macros
epriestley closed T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order as Resolved by committing Restricted Diffusion Commit.
Mar 8 2018, 4:57 AM · Owners
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 8 2018, 2:22 AM · Plans
epriestley added a revision to T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order: Unknown Object (Differential Revision).
Mar 8 2018, 2:22 AM · Owners
epriestley added a revision to T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order: Unknown Object (Differential Revision).
Mar 8 2018, 1:33 AM · Owners
epriestley added a revision to T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order: Unknown Object (Differential Revision).
Mar 8 2018, 12:44 AM · Owners
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 8 2018, 12:09 AM · Plans

Mar 7 2018

epriestley triaged T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy as Normal priority.
Mar 7 2018, 11:11 PM · Remarkup, Security, Macros
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 7 2018, 10:55 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 7 2018, 10:54 PM · Plans
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2018, 3:25 PM · Plans
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Mar 7 2018, 3:04 PM · Plans, Harbormaster
epriestley closed T11015: Owners has perplexing behavior when directory paths are not terminated with a slash as Resolved.

I believe the behavior of this UI should generally align well with what reasonable users might expect, now. In particular, /src/backend and /src/backend/ are now exactly the same in terms of actually resolving ownership, although the UI will continue to show you the value you entered (to avoid confusion where someone types /docs/README.md and the UI echoes back /docs/README.md/ and they have a reasonable concern that the path wasn't understood).

Mar 7 2018, 4:54 AM · Owners, Bug Report
epriestley added a comment to T13099: Plans: 2018 Week 10 Bonus Content.

The easiest fix here is probably to just return an interstitial.

Mar 7 2018, 4:47 AM · Plans
epriestley added a comment to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.

I've deployed these configuration changes to production and they appear to have resolved the issue.

Mar 7 2018, 4:47 AM · Phacility
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 7 2018, 4:33 AM · Plans
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: Unknown Object (Differential Revision).
Mar 7 2018, 4:28 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: Unknown Object (Differential Revision).
Mar 7 2018, 4:14 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: Unknown Object (Differential Revision).
Mar 7 2018, 3:54 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: Unknown Object (Differential Revision).
Mar 7 2018, 3:47 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: Unknown Object (Differential Revision).
Mar 7 2018, 3:37 AM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Probably better is to add pathIndex

Mar 7 2018, 3:25 AM · Owners, Bug Report
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

New, far wordier options available at HEAD:

Mar 7 2018, 3:12 AM · Restricted Project, Feature Request
epriestley closed T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package as Resolved by committing Restricted Diffusion Commit.
Mar 7 2018, 3:02 AM · Restricted Project, Feature Request
epriestley added a revision to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package: Unknown Object (Differential Revision).
Mar 7 2018, 2:59 AM · Restricted Project, Feature Request
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Restricted Differential Revision.
Mar 7 2018, 2:59 AM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 7 2018, 2:56 AM · Plans
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 7 2018, 1:58 AM · Plans, Diffusion
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2018, 1:41 AM · Plans
epriestley added a revision to T12787: Creating a subtask 'reopens' the new task: Unknown Object (Differential Revision).
Mar 7 2018, 1:41 AM · Feed, Bug Report

Mar 6 2018

epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 6 2018, 8:38 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 6 2018, 8:28 PM · Plans
epriestley edited the content of 2018 Week 9 (Very Early March).
Mar 6 2018, 8:20 PM
epriestley added a revision to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values: Unknown Object (Differential Revision).
Mar 6 2018, 8:16 PM · Phacility
epriestley added a comment to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.

Since I can't really figure out how to make this stuff segfault or what reasonable ranges for these values are, I'm tentatively going to lower these values to 10000 in production (based on sage advice from Rasmus in https://bugs.php.net/bug.php?id=36463) and see what that breaks.

Mar 6 2018, 8:11 PM · Phacility
epriestley added a comment to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.

On my system, this script:

Mar 6 2018, 7:57 PM · Phacility
epriestley triaged T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values as Normal priority.
Mar 6 2018, 7:43 PM · Phacility
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 6 2018, 7:38 PM · Plans
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 6 2018, 6:31 PM · Plans
epriestley added a comment to T13099: Plans: 2018 Week 10 Bonus Content.

Entering MFA credentials during an OAuth server redirect workflow can currently be blocked by the CSP.

Mar 6 2018, 6:10 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 6 2018, 5:31 PM · Plans
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 6 2018, 5:11 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 6 2018, 5:11 PM · Plans
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 6 2018, 4:36 PM · Plans
epriestley added a comment to T13099: Plans: 2018 Week 10 Bonus Content.

PHI410 and PHI348 are both related to Differential's TYPE_UPDATE transaction. This is essentially the only Differential transaction which has not moved to ModularTransactions.

Mar 6 2018, 4:29 PM · Plans
epriestley closed T13096: Implement a global lock log to make it easier to debug global locks as Resolved.

This log is now available at HEAD of master.

Mar 6 2018, 2:04 AM · Daemons, Infrastructure

Mar 5 2018

epriestley added a revision to T13096: Implement a global lock log to make it easier to debug global locks: Unknown Object (Differential Revision).
Mar 5 2018, 11:27 PM · Daemons, Infrastructure
epriestley added a revision to T13096: Implement a global lock log to make it easier to debug global locks: Unknown Object (Differential Revision).
Mar 5 2018, 10:11 PM · Daemons, Infrastructure
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 5 2018, 6:09 PM · Plans
epriestley moved T13099: Plans: 2018 Week 10 Bonus Content from Backlog to Soon on the Plans board.
Mar 5 2018, 3:20 PM · Plans
epriestley triaged T13099: Plans: 2018 Week 10 Bonus Content as Normal priority.
Mar 5 2018, 3:20 PM · Plans
epriestley added a comment to T13083: Plans: Portals and Facts.

Just to briefly touch this:

Mar 5 2018, 3:15 PM · Plans, Facts, Dashboards
epriestley moved T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds from Backlog to Future on the Plans board.

This is effectively paused until I'm more convinced that the stabilizations changes really stabilized things -- I'm hoping to stabilize first, then work on improvements from there.

Mar 5 2018, 3:06 PM · Plans, Drydock
epriestley moved T13074: Plans: Workboard triggers, groups, and subproject columns from Backlog to Tentative on the Plans board.
Mar 5 2018, 3:03 PM · Workboards (v3), Plans, Projects
epriestley moved T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction from Backlog to Tentative on the Plans board.
Mar 5 2018, 3:03 PM · Plans, Ops, Infrastructure, Phacility
epriestley moved T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance from Backlog to Tentative on the Plans board.
Mar 5 2018, 3:03 PM · Plans, Diffusion
epriestley moved T13077: Plans: Phriction modern "v3" APIs, Drafts from Backlog to Future on the Plans board.

The corresponding support ticket was likely addressed by these changes. The remaining stuff here is still planned, but probably not moving forward any time soon.

Mar 5 2018, 3:03 PM · Plans, Phriction
epriestley moved T13083: Plans: Portals and Facts from Backlog to Soon on the Plans board.
Mar 5 2018, 3:02 PM · Plans, Facts, Dashboards
epriestley moved T13088: Plans: Harbormaster UI usability and interconnectedness from Backlog to Soon on the Plans board.
Mar 5 2018, 3:02 PM · Plans, Harbormaster
epriestley moved T13098: Plans: Arcanist toolsets and extensions from Backlog to Tentative on the Plans board.
Mar 5 2018, 3:02 PM · Arcanist, Plans
epriestley moved T13047: Plans: Symbol Indexes from Backlog to Future on the Plans board.

The actual support issues were likely addressed or obsoleted by the above changes. The rest of this is still planned, probably won't move forward any time soon.

Mar 5 2018, 3:01 PM · Plans, Symbols
epriestley edited the content of 2018 Week 9 (Very Early March).
Mar 5 2018, 2:55 PM
epriestley edited the content of 2018 Week 9 (Very Early March).
Mar 5 2018, 2:55 PM
epriestley added a revision to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers: Unknown Object (Differential Revision).
Mar 5 2018, 2:52 PM · Phacility, Security
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I had a lot of stuff come up this weekend, but made it through Kitava A5 with a Tectonic Slam Facebreakers Juggernaut (???) and an Arc Totem Hierophant, both around 51. Unsure how I currently feel about either character. I think I can turn the Juggernaut into Molten Strike if I find a decent weapon. Damage is okay so far on the Hierophant but my Haku is still at level 1 so fixing his resists has been tough.

Mar 5 2018, 2:31 PM · Phacility
epriestley moved T1549: Add a top-level mechanism for disabling lint by adding a comment from Backlog to Upstream on the Arcanist board.
Mar 5 2018, 2:20 PM · Arcanist
epriestley moved T10608: Arc diff failing to generate diff with svn 1.9.3 from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:19 PM · Arcanist, Bug Report
epriestley moved T12382: ArcanistJSONLintRenderer fails to produce JSON output with non-UTF-8 encodings from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:17 PM · Lint, Arcanist, Bug Report
epriestley moved T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export" from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley moved T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Differential
epriestley moved T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12785: Arc unit command fails with PHPUnit 6 from Backlog to Unit/Lint Bindings on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Mercurial, Bug Report
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Unit/Lint Bindings to Upstream on the Arcanist board.
Mar 5 2018, 2:15 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T13059: Write a lint rule for detecting unreachable blocks from Backlog to Upstream on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Lint
epriestley closed T8929: Arcanist glitch for `arc help ---full` as Invalid.

I don't know how to reproduce this.

Mar 5 2018, 2:11 PM · Arcanist
epriestley closed T7488: Add shell completion support to PhutilArgumentWorkflow as Wontfix.

See T13098. I currently plan to expose the shell-complete workflow to every arc toolset, but I don't think being able to shell-complete bin/storage upgrade or similar is worth pursuing.

Mar 5 2018, 2:10 PM · Restricted Project, libphutil
epriestley closed T7488: Add shell completion support to PhutilArgumentWorkflow, a subtask of T9116: Shell completion doesn't work for filenames containing a space, as Wontfix.
Mar 5 2018, 2:10 PM · Restricted Project, Arcanist
epriestley closed T7488: Add shell completion support to PhutilArgumentWorkflow, a subtask of T7487: ArcanistWorkflow should extend from PhutilArgumentWorkflow, as Wontfix.
Mar 5 2018, 2:10 PM · Arcanist
epriestley closed T7487: ArcanistWorkflow should extend from PhutilArgumentWorkflow as Wontfix.

See T13098 for followup. Currently, I have ArcanistWorkflow generating a PhutilArgumentWorkflow but not actually subclassing it.

Mar 5 2018, 2:09 PM · Arcanist
epriestley closed T6234: Add option to make arc lint interactive as Wontfix.

This has seen little interest so I don't currently plan to pursue it. Ideally, lint messages should simply include patches so that arc fixes the errors itself.

Mar 5 2018, 2:07 PM · Arcanist
epriestley renamed T13098: Plans: Arcanist toolsets and extensions from Plans: Arcanist to Plans: Arcanist toolsets and extensions.
Mar 5 2018, 2:04 PM · Arcanist, Plans