Page MenuHomePhabricator
Feed All Stories

Nov 19 2015

qinchao added a comment to Q221: Is that possible to host several phabricators in one single server? (Answer 255).

Okay, thanks for the info.

Nov 19 2015, 4:45 AM
epriestley closed T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host as Invalid.

Since we don't have access to whatever GitLab is measuring, we can't understand this issue in greater detail. Particularly, we can not reproduce the underlying heavy load in a way we can examine. We have not seen similar reports from other users, except @jcarrillo7, who has not filed any details. We have many installs with hundreds of repositories and my expectation is that the operation is cheap, so I suspect this may be an issue unique to GitLab.

Nov 19 2015, 3:32 AM · Diffusion, Daemons
avivey added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

Sounds like you could easily fork and change the polling frequency; The calculation is at https://secure.phabricator.com/diffusion/P/browse/master/src/applications/repository/storage/PhabricatorRepository.php$1527, and you can drop it to an hour just by changing that line.

Nov 19 2015, 3:23 AM · Diffusion, Daemons
hach-que updated the task description for T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.
Nov 19 2015, 3:08 AM · Drydock
award added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

I am not sure of the underlying implementation of GitLab, but our phabricator instance has been flagged as the #1 user of GitLab resources. Our GitLab instance hosts thousands of repositories, so being the single largest user of GitLab is concerning since we only have ~50 repositories.

Nov 19 2015, 3:04 AM · Diffusion, Daemons
hach-que added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Based on my memory, I think it's possible that exception is the cause of the issue; when it occurs, the exception ends the current worker task with a permanent failure, and the task won't be revisited. Thus the build remains pending because the worker that would have performed the next update failed to do so.

Nov 19 2015, 3:03 AM · Harbormaster, Drydock
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

My next step would be to put more crumbs in the UI, but we're missing a little data right now. Basically, I'd do this:

Nov 19 2015, 3:03 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

We can leave this at "reduced expected incidence rate to < 1/3k" and I'll come back here if it happens again if you don't have any more obvious ideas.

Nov 19 2015, 2:55 AM · Harbormaster, Drydock
epriestley added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

huge amount of traffic

Nov 19 2015, 2:53 AM · Diffusion, Daemons
hach-que added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

At that scale, is there any reason to not use Phabricator's repository hosting instead of GitLab? You can mirror repositories from Phabricator to GitLab if you still need some GitLab functionality (see the Mirrors option under Edit Repository).

Nov 19 2015, 2:52 AM · Diffusion, Daemons
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Oh I lied, checked the old logs, this error was present the last two times it occurred, but not present when it happened this evening.

Nov 19 2015, 2:51 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

This perfectly recreates the symptoms, except it generates an error in the daemon log:

Nov 19 2015, 2:49 AM · Harbormaster, Drydock
award renamed T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host from Repositories are being polled at 2Hz to Fast repository polling on multiple repositories causes 2Hz polling of remote host.
Nov 19 2015, 2:41 AM · Diffusion, Daemons
award added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

Oops! Thats embarrassing. These numbers were gathered from multiple places/multiple people, and mass confusion ensued. The 2Hz number came from the total requests to GitLab instead of requests per repository. Ill update the title/description accordingly.

Nov 19 2015, 2:40 AM · Diffusion, Daemons
Mnkras added a comment to T9805: XHProf will not build on PHP7.

I don't think that is going to work here are some things I pulled from the extension migration page (unless we ifdef large blocks of code):

zval

  • PHPNG doesn't require any involvement of pointers to pointers to zval. Most occurrences of zval** variables and parameters have to be changed into zval*. The corresponding Z_*_PP() macros that work with such variables should be changed into Z_*_P().
  • In many places PHPNG work with zval directly (eliminating need for allocation and deallocation). In these cases corresponding zval* variable should be converted into plain zval, macros that use this variable from Z_*P() into Z_*() and corresponding creation macros from ZVAL_*(var, …) into ZVAL_*(&var, …). Be always careful about passing addresses of zval and & operator. PHPNG almost never require passing address of zval*. In some places & operator should be removed.
  • zval allocation macros ALLOC_ZVAL, ALLOC_INIT_ZVAL, MAKE_STD_ZVAL are removed. In most cases their usage indicate that zval* need to be changed into plain zval. Macro INIT_PZVAL is removed as well and its usages in most cases should be just removed.
Nov 19 2015, 2:39 AM · XHProf
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Specifically, if you put like a sleep(10) directly after applyPlan() I would expect that to trigger the race ~100% of the time as long as the queue isn't too full. You could see if the behavior is similar to the behavior you've observed.

Nov 19 2015, 2:24 AM · Harbormaster, Drydock
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Yeah, I think that can race. Here's an example -- open two connections to MySQL, mysql1> and mysql2>. In the first window do this:

Nov 19 2015, 2:21 AM · Harbormaster, Drydock
featherless awarded T8783: Unprototype Nuance (v1) a Mountain of Wealth token.
Nov 19 2015, 2:19 AM · Nuance, Restricted Project
featherless awarded T3670: Add subprojects a Like token.
Nov 19 2015, 2:18 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

I'm not sure I understand your math -- here's what I get:

Nov 19 2015, 2:14 AM · Diffusion, Daemons
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

DAO's prefixed CISubmitQueue are in their own database. There has never been any problems with referential integrity / never seen anything in the database that would indicate we'd written records incorrectly. But you may be right about the tasks being written before the plan is written. I suspect that would cause errors though, I can try to reproduce that first in order to rule out our specifics being the problem.

Nov 19 2015, 2:13 AM · Harbormaster, Drydock
yelirekim added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Let me post the whole block, it didn't seem relevant:

Nov 19 2015, 2:10 AM · Harbormaster, Drydock
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Oh, you removed openTransaction(), so that's probably not the culprit.

Nov 19 2015, 2:09 AM · Harbormaster, Drydock
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

It's vaguely possible that openTransaction() is the culprit. applyPlan() queues a daemon task, and I could imagine the race might be:

Nov 19 2015, 2:08 AM · Harbormaster, Drydock
award updated subscribers of T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

@epriestley I know you mentioned that a diffusion.looksoon would trigger this, but we have no known users of this command.

Nov 19 2015, 2:08 AM · Diffusion, Daemons
yelirekim updated the task description for T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:07 AM · Harbormaster, Drydock
• EnterTheMusic updated Q224: Phabricator development - IDE from to Phabricator development - IDE.
Nov 19 2015, 2:06 AM
yelirekim updated the task description for T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:06 AM · Harbormaster, Drydock
award updated the task description for T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.
Nov 19 2015, 2:05 AM · Diffusion, Daemons
yelirekim updated the task description for T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:04 AM · Harbormaster, Drydock
yelirekim created T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 19 2015, 2:03 AM · Harbormaster, Drydock
award created T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.
Nov 19 2015, 2:02 AM · Diffusion, Daemons
jcarrillo7 added a comment to T9803: Eternally failing mail send task.

Only due to the fact that it failed 250 times and got removed by Phabricator.... I suspect it will happen again the next time that file changes.

Nov 19 2015, 1:26 AM · Daemons, Mail
epriestley closed T9803: Eternally failing mail send task as Invalid.

It sounds like this no longer reproduces for you.

Nov 19 2015, 1:25 AM · Daemons, Mail
chad closed T7908: Implement aliases for objects as Resolved.

You can do this with Phurl today.

Nov 19 2015, 12:24 AM · Maniphest
chad updated subscribers of T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.
Nov 19 2015, 12:23 AM · Maniphest
chad merged task T9813: "Blocked" filtering: task shows up on both "blocked" and "non-blocked" queries into T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.
Nov 19 2015, 12:23 AM · Maniphest

Nov 18 2015

epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 18 2015, 11:04 PM · Restricted Project, ApplicationEditor, Transactions
joshuaspence updated Q209: Is it possible to update Differential dependencies from Conduit? from Is it possible to update differential dependencies from conduit to Is it possible to update Differential dependencies from Conduit?.
Nov 18 2015, 10:05 PM · Differential
joshuaspence updated the answer details for Q210: Unable to understand who the Author/Commiter is. (Answer 242).
Nov 18 2015, 10:04 PM
joshuaspence added a revision to T992: Send rich HTML mail bodies without impacting reply handling functionality: Unknown Object (Differential Revision).
Nov 18 2015, 8:52 PM · Differential, Mail
lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: Unknown Object (Differential Revision).
Nov 18 2015, 8:40 PM · Phurl
• andrask added a comment to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.

Is there anything I could do to facilitate discussion or acception of this proposal?

Nov 18 2015, 8:27 PM · Subversion, Arcanist
caov297 updated Q223: How to restrict outgoing MySQL ports to specific range from to How to restrict outgoing aphrontMySQL ports to specific range.
Nov 18 2015, 8:22 PM · Aphront
rodbegbie awarded T4214: Allow installs to change or supplement the "Phabricator" icon a Like token.
Nov 18 2015, 7:57 PM · Design
joshuaspence awarded T9811: Make it easier to diagnose command failures occurring inside Drydock allocations a Like token.
Nov 18 2015, 7:56 PM · Drydock
joshuaspence awarded T9812: Show SSH diagnostic information in Drydock logs a Like token.
Nov 18 2015, 7:56 PM · Drydock
joshuaspence renamed T9813: "Blocked" filtering: task shows up on both "blocked" and "non-blocked" queries from "blocked" filtering: task shows up on both "blocked" and "non-blocked" queries to "Blocked" filtering: task shows up on both "blocked" and "non-blocked" queries.
Nov 18 2015, 7:55 PM · Maniphest
rodbegbie created T9814: Add SVG icon for Safari 9's pinned tabs.
Nov 18 2015, 7:52 PM · User Delight
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 18 2015, 7:24 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 18 2015, 6:40 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9805: XHProf will not build on PHP7.
  • If the changes are relatively minor, add a bunch more #ifdefs? We already have some of this to deal with prior API changes, and I believe this approach is historically a standard one across other extensions.
    • If the changes are substantial, maybe we need to get more creative.
Nov 18 2015, 4:14 PM · XHProf
kgadek created T9813: "Blocked" filtering: task shows up on both "blocked" and "non-blocked" queries.
Nov 18 2015, 4:04 PM · Maniphest
fanis added a comment to T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.

After a few months of using P1094, we have found it invaluable in getting an overview of big and deep tasks. It is sufficient for our needs, we're happy with it continuing to work locally.

Nov 18 2015, 3:57 PM · Maniphest
chad awarded Image Macro "magicfingers" a Love token.
Nov 18 2015, 3:57 PM
Mnkras updated subscribers of T9805: XHProf will not build on PHP7.

@epriestley, due to the fact that the Zend APIs for PHP7+ are different than those in PHP5* how should changes to XHProf be submitted so we don't break stuff?

Nov 18 2015, 3:29 PM · XHProf
hach-que added a comment to T6454: Implement support for KVM-based hosts in Drydock.

@epriestley I have a reasonable implementation of this working on the new Drydock architecture. I want to pursue this before EC2 so we can ensure that all of the locking mechanisms are working correctly before we use the new Drydock on something that potentially costs money (and in the event that Drydock goes haywire, may cost thousands of dollars). KVM offers a safe alternative, because if Drydock goes haywire, the worst that will happen is that it won't be able to allocate new VMs on the KVM host due to out of memory errors.

Nov 18 2015, 3:04 PM · Drydock
hach-que claimed T9812: Show SSH diagnostic information in Drydock logs.
Nov 18 2015, 3:03 PM · Drydock
hach-que created T9812: Show SSH diagnostic information in Drydock logs.
Nov 18 2015, 3:03 PM · Drydock
hach-que renamed T6454: Implement support for KVM-based hosts in Drydock from Implement support for libvirt-based hosts in Drydock to Implement support for KVM-based hosts in Drydock.
Nov 18 2015, 2:58 PM · Drydock
hach-que added a revision to T9811: Make it easier to diagnose command failures occurring inside Drydock allocations: Unknown Object (Differential Revision).
Nov 18 2015, 2:48 PM · Drydock
hach-que created T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.
Nov 18 2015, 2:46 PM · Drydock
vlada awarded T9456: Evaluate upstream support for third-party build systems a Doubloon token.
Nov 18 2015, 2:34 PM · Restricted Project, Harbormaster
leduc removed a revision from T4189: Install commit hooks in hosted repositories: Unknown Object (Differential Revision).
Nov 18 2015, 11:18 AM · Diffusion
PhoneixS awarded T5520: Implement support for Maven (Java) repositories a Like token.
Nov 18 2015, 10:47 AM · Phragment
jgelens added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

If you want to test that something in this vein works, I'm happy to bring it upstream.

Nov 18 2015, 8:47 AM · Arcanist, Mercurial
epriestley closed T9810: 한글 테스트 중입니다. as Invalid.
Nov 18 2015, 8:10 AM · Android
• cjdthck created T9810: 한글 테스트 중입니다..
Nov 18 2015, 8:07 AM · Android
hach-que changed the image for Image Macro "magicfingers".
Nov 18 2015, 6:34 AM
chad closed Q221: Is that possible to host several phabricators in one single server? as resolved.
Nov 18 2015, 6:11 AM
chad closed T9325: "Added a revision: Unknown Object (Differential Revision)" email as Invalid.

Closing here, without a way to reproduce the issue, not sure anything else can be done.

Nov 18 2015, 6:09 AM · Differential, Mail
chad closed T9656: Apply "transaction color" (Maniphest) status configuration option to the status - as shown on the left top - whenever a task is opened. as Wontfix.

We don't have any current plans to pursue this and I can't guess what or how Phabricator may work years from now. Thanks for the feedback.

Nov 18 2015, 6:01 AM · Maniphest
chad merged task T9677: Difficulty debugging sudo permissions into T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository.
Nov 18 2015, 5:58 AM · Diffusion
chad updated subscribers of T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository.
Nov 18 2015, 5:58 AM · Diffusion
featherless closed T9809: Add 'URL' auxiliary field type to Maniphest as Invalid.

Ah - just saw that the diffs I was looking at were outdated and that link is a thing now. Saw the guide explaining all of the custom fields :)

Nov 18 2015, 4:01 AM · Maniphest
• jverkoey created T9809: Add 'URL' auxiliary field type to Maniphest.
Nov 18 2015, 3:48 AM · Maniphest
rfergu edited P1893 (An Untitled Masterwork).
Nov 18 2015, 3:01 AM
epriestley closed T9808: Daemon worker garbage collector executes query with inefficient key usage as Resolved by committing Restricted Diffusion Commit.
Nov 18 2015, 1:05 AM · Daemons, Phacility
epriestley added a revision to T9808: Daemon worker garbage collector executes query with inefficient key usage: Unknown Object (Differential Revision).
Nov 18 2015, 1:02 AM · Daemons, Phacility
epriestley created T9808: Daemon worker garbage collector executes query with inefficient key usage.
Nov 18 2015, 12:25 AM · Daemons, Phacility

Nov 17 2015

cspeckmim updated the task description for T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).
Nov 17 2015, 11:22 PM · Arcanist, Mercurial
cspeckmim added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

Wow thank you - I was planning to look at this probably sometime this weekend (with pretty much the change you pasted). I'll edit the task description to provide a workaround if anyone else runs into this.

Nov 17 2015, 11:17 PM · Arcanist, Mercurial
epriestley added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

If you want to test that something in this vein works, I'm happy to bring it upstream.

Nov 17 2015, 11:14 PM · Arcanist, Mercurial
epriestley added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

We should be able to just omit the final argument if remote is not specified. We can refine that later, but our usage seems like it's in the wrong to me.

Nov 17 2015, 11:13 PM · Arcanist, Mercurial
cspeckmim created T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).
Nov 17 2015, 11:07 PM · Arcanist, Mercurial
reanimus edited the content of 2015 Week 46 (Mid November).
Nov 17 2015, 10:12 PM
jcarrillo7 added a comment to T9803: Eternally failing mail send task.

sadly I can't run this

bin/worker execute --id <id>

since the task has been archived

Nov 17 2015, 9:36 PM · Daemons, Mail
richardvanvelzen added a comment to T9805: XHProf will not build on PHP7.

https://wiki.php.net/phpng-upgrading should contain a lot of relevant information.

Nov 17 2015, 8:48 PM · XHProf
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 17 2015, 8:37 PM · Restricted Project, ApplicationEditor, Transactions
joshuaspence updated the title for P1892 xhpast_tree.php from untitled to xhpast_tree.php.
Nov 17 2015, 8:29 PM · XHPAST
joshuaspence updated the question details for Q222: Integration with Jira.
Nov 17 2015, 8:10 PM · Doorkeeper
joshuaspence added a project to Q222: Integration with Jira: Doorkeeper.
Nov 17 2015, 8:09 PM · Doorkeeper
joshuaspence added Q222: Integration with Jira (Answer 257).
Nov 17 2015, 8:07 PM
lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: Unknown Object (Differential Revision).
Nov 17 2015, 8:03 PM · Phurl
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

If a Phurl doesn't have a name, should we still show the empty name property on the object view?

Nov 17 2015, 7:55 PM · Phurl
joshuaspence added a comment to Q221: Is that possible to host several phabricators in one single server?.

No, that's not currently possible, but it might be worth filing a Maniphest task for that.

Nov 17 2015, 7:53 PM
sinayion awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Like token.
Nov 17 2015, 7:50 PM · Maniphest
sinayion added a comment to T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies.

Definitely want to weigh in, and say that this is a vastly important feature for myself. Having the tree view in other bug trackers is helpful for planning, triaging, and almost every aspect of software development.

Nov 17 2015, 7:50 PM · Maniphest
jcarrillo7 added a comment to T9803: Eternally failing mail send task.

I have metamta.differential.inline-patches set to 100
metamta.email-body-limit is set to the Global Default 524288

Nov 17 2015, 7:45 PM · Daemons, Mail
avivey updated the task description for T9806: Exception while editing Ponder comment to an answer.
Nov 17 2015, 6:41 PM · Ponder