Page MenuHomePhabricator

Auto-create Maniphest tasks for concerns raised through Audit.
Closed, DuplicatePublic

Description

We would like to get a history of commits that were made in order to fix a concern raised against a commit during Audit because this makes it easier for reviewers to follow up on changes made post-audit without the committer having to remember to CC the auditors in every commit.

This is currently possible manually by creating a Maniphest task, attaching the concerning commit to the task, and then referencing that Maniphest task in all new commits made to fix the concerning commit. The task history then represents a history of actions taken to fix a failed Audit which auditors can comment on in context.

Since the task must always be made after the failed Audit and then attached, this process cannot be sped up via commit message triggers and since Herald does not allow triggering on raised concerns, this cannot be automated currently.

Related Objects

Event Timeline

Please check out our guide on requesting features in Phabricator. Specifically, it's helpful for us to understand what problem you are having with Phabricator and then we can look at various solutions. Right now I don't have any clear idea on what problem duplicating Audit into Maniphest could solve.

https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#describe-problems

@nick.udell I'm still not really understanding the problem. It sounds like you're just copying information from Audit to Maniphest but I don't see what problem duplicating the information solves. If I have a commit with a Raised Concern, it's on my dashboard to address and I have all pertinent information to assign a new review to resolve the issue.

@chad the issue is that subsequent commits (made to fix concerns raised) are not easily linked to the commit that raised concerns and are harder for auditors to view in context with the commit they had originally audited.

It sounds like you want T4026 then?

I think you can write a custom HeraldAdapter to do what you want in the meantime, trying to see if we've documented that somewhere yet.

Yeah I don't know why you would want to duplicate Audit details to Maniphest. Do these commits have a single merge commit which could be audited instead?

@joshuaspence the issue for me is that the commits made to fix the failed audit naturally do not occur until after the audit has failed, and so can't be in the same commit.

While all revisions made to fix an audit could be put in the same merge commit, and that would ameliorate the problem, there would still be the issue that the commit that failed audit is not linked to the fixes made for it. There's no way of just seeing them all in the same page, in the context of "this was marked as broken, these are the attempts to fix it".

I end up with this situation: "I have raised concerns on this commit, how do I see what commits have been made to fix this? How can I verify that the issues from the audit are fixed and that there have not been new issues created in fixing the previous issues?"

The reason I am involving Maniphest here is that it allows me to link all the commits in one place, with the Maniphest task being the context of "A failed audit and all commits made to fix it." It is not necessarily ideal as, yes, it does duplicate data, but I cannot find a better solution currently.

chad changed the task status from Duplicate to Wontfix.Oct 17 2015, 3:24 AM
chad closed this task as a duplicate of T4026: Add relations between commits.

Yeah, T4026 seems like a reasonable path forward here in that there would exist a relation for "commit X addressed concerns raised in commit Y".