Filter by active users
Needs RevisionPublic
Actions

Authored by g-p-g on Sep 11 2014, 3:27 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Currently it's not possible to query users that are not disabled, are not bots, but are approved. This seems like a typical query, which would list the currently active users. Ideally it should be possible to display these users in a dashboard panel as well.

Test Plan

Check if the filter for systemAgent is still working properly; Check if the new filter works fine.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 2538
Build 2542: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

g-p-g updated this revision to Diff 25198.Sep 11 2014, 3:27 PM

g-p-g retitled this revision from to Filter by active users.

g-p-g updated this object.

g-p-g edited the test plan for this revision. (Show Details)

g-p-g set the repository for this revision to rP Phabricator.

g-p-g added a project: People.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 3:27 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2518: Diff 25198.Sep 11 2014, 3:28 PM

I'll accept this if you:

Use three-state select dropdowns instead of adding a new checkbox.
- States are basically "(Show All)", "Show only users with this property", "Show only users without this property".
- PhabricatorAppSearchEngine has an example (Installed/Beta/Launchable/Provenance).
Retain backward compatibility with existing saved queries.

This revision now requires changes to proceed.Sep 14 2014, 6:08 PM