Page MenuHomePhabricator
Feed Advanced Search

May 24 2016

swisspol added a comment to T11023: Branch contains condition in Herald rule not behaving as expected .

Deleting the branch first won't have any effect, since the commit still exists.

May 24 2016, 2:37 PM · Bug Report
swisspol added a comment to T11023: Branch contains condition in Herald rule not behaving as expected .

Sounds like a dup indeed. What's the work around?

  • Doing a rebase instead of FF-merge?
  • Deleting the topic branch in Diffusion first, then FF-merge and push?
May 24 2016, 2:29 PM · Bug Report
swisspol created T11023: Branch contains condition in Herald rule not behaving as expected .
May 24 2016, 6:14 AM · Bug Report

May 11 2016

swisspol created T10951: Search shows document types corresponding to disabled apps.
May 11 2016, 4:02 PM · Contributor Onboarding, Search, Bug Report

Apr 29 2016

swisspol added a comment to T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.

BTW is the print action the expected method to get an "invoice" for my records? Or can you download a formal invoice from somewhere?

Apr 29 2016, 3:08 PM · Design, Bug Report
swisspol created T10899: Print CSS does not fold/hide curtains for object pages like Phortune carts.
Apr 29 2016, 2:36 PM · Design, Bug Report

Apr 19 2016

swisspol added a comment to T10838: Differential revision page diff sometimes shows file diffs without visible differences.

OK I understand. Even if the current UX is not perfect, if implementing an improved version would result in a more fragile UX because the code is a lot more complex, then yes, the current situation is preferable.

Apr 19 2016, 3:24 PM · Bug Report
swisspol added a comment to T10838: Differential revision page diff sometimes shows file diffs without visible differences.

Ah I was wondering about this comment, but since it was explicitly hidden, I thought it wasn't the cause.

Apr 19 2016, 3:06 PM · Bug Report
swisspol created T10838: Differential revision page diff sometimes shows file diffs without visible differences.
Apr 19 2016, 2:47 PM · Bug Report

Apr 15 2016

swisspol added a comment to T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.

Thanks for looking into this @epriestley!

Apr 15 2016, 4:41 PM · Maniphest, Mail, Bug Report
swisspol added a comment to T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.

You can either solve this by not sending such emails when a task is merged (but they you don't notified of merged tasks which is bad), or by having a dedicated subject / body for merged task notifications, which then:

  1. solves this bug
  2. improves the UX since you now get a notification email that actually reflects the action that happened
Apr 15 2016, 3:59 PM · Maniphest, Mail, Bug Report
swisspol added a comment to T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.

I really don't think this task should be closed. This is a user experience bug, independently of any underlying good reason there might be in the implementation.

Apr 15 2016, 3:57 PM · Maniphest, Mail, Bug Report
swisspol added a comment to T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.

It looks like the changed subscribers results from a merged task, so maybe this case is not handled?

Apr 15 2016, 3:17 PM · Maniphest, Mail, Bug Report
swisspol updated the task description for T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.
Apr 15 2016, 3:15 PM · Maniphest, Mail, Bug Report
swisspol created T10822: When vary-subjects is enabled, a task is merged, and subscribers are modifed the subject is misleading.
Apr 15 2016, 3:15 PM · Maniphest, Mail, Bug Report
swisspol awarded T9870: Include clang-format-lint as a linter a Like token.
Apr 15 2016, 12:03 AM · Restricted Project, Lint, Arcanist
swisspol created T10818: Lint errors about filenames, which do not include any source context, render with awkward whitespace.
Apr 15 2016, 12:01 AM · Arcanist, Bug Report

Apr 14 2016

swisspol added a comment to T10817: Allow more characters for built-in `filename` linter.

The best might be to have a configuration option for this linter to add extra allowed characters.

Apr 14 2016, 11:54 PM · Lint, Feature Request
swisspol created T10817: Allow more characters for built-in `filename` linter.
Apr 14 2016, 11:50 PM · Lint, Feature Request
swisspol added a comment to T10810: Add Renaming Column command to column contextual menu in workboards.

If you have this in mind, I'm not looking for batches renaming or anything like this.

Apr 14 2016, 7:26 PM · Feature Request
swisspol added a comment to T10810: Add Renaming Column command to column contextual menu in workboards.

That's already the root problem 😉

Apr 14 2016, 7:25 PM · Feature Request
swisspol created T10810: Add Renaming Column command to column contextual menu in workboards.
Apr 14 2016, 6:07 PM · Feature Request

Apr 7 2016

swisspol created T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Apr 7 2016, 9:17 PM · Restricted Project, Harbormaster, Bug Report

Apr 6 2016

swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I'm using the reload button next to the URL field indeed. I'm not sure this trashes the cache because if that was the case, there would be no 304s, right?

Apr 6 2016, 10:43 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Thanks @epriestley, much looking forward to have this deployed to Phacility.

Apr 6 2016, 10:06 PM · Restricted Project, Restricted Project, Wikimedia, Files
ofbeaton awarded T5358: Make "Self Actions" default value a setting a Like token.
Apr 6 2016, 8:36 PM · User Preferences
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I'm on my laptop using tethering on T-Mobile right now and I just noticed the user profile photos in the workboards are not being cached. Whenever I reload the page (Chrome 49.0.2623.110 on OS X 10.11.4), these photos reload from scratch. Here are the headers as reported by the Chrome inspector:

Apr 6 2016, 3:59 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol created T10733: Workboards don't have canonical URLs.
Apr 6 2016, 3:02 PM · Bug Report
swisspol added a comment to T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.

Thanks much for the info. What should happen with this very task then? Close it?

Apr 6 2016, 4:06 AM · Remarkup, Feature Request
swisspol added a comment to T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.

The 'mild redesign' we've been rolling out will have a fixed-width option likely per user under Accessibility

Apr 6 2016, 3:52 AM · Remarkup, Feature Request
swisspol added a comment to T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.

It's just one of those design/usability tenants, whitespace improves visual comprehension. Plenty of usability research out there supports this.

Apr 6 2016, 3:35 AM · Remarkup, Feature Request
swisspol added a comment to T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.

Stuff like this:

Apr 6 2016, 3:16 AM · Remarkup, Feature Request
swisspol added a comment to T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.

Wikipedia, the ultimate wiki, is full page width (https://en.wikipedia.org/wiki/Phabricator).

Apr 6 2016, 3:07 AM · Remarkup, Feature Request
swisspol created T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.
Apr 6 2016, 2:58 AM · Remarkup, Feature Request

Apr 2 2016

epriestley awarded T10707: arc backout added bonus free "tips" to end of commit message a Pterodactyl token.
Apr 2 2016, 1:32 PM · Arcanist, Bug Report
swisspol updated the task description for T10707: arc backout added bonus free "tips" to end of commit message.
Apr 2 2016, 2:35 AM · Arcanist, Bug Report
swisspol created T10707: arc backout added bonus free "tips" to end of commit message.
Apr 2 2016, 2:34 AM · Arcanist, Bug Report

Apr 1 2016

charles awarded T5793: Add support for personal workboards a Like token.
Apr 1 2016, 7:27 PM · User Delight, Wikimedia, Workboards
ofbeaton awarded T5353: Add visual hint to tasks that are blocked by others a Like token.
Apr 1 2016, 7:09 PM · Custom Fields, Maniphest

Mar 31 2016

swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

When I said "user images" above, I meant to say "user uploaded images" like what you drag & drop in Pholio, Phriction, Maniphest, etc... i.e. explicitly not Phab built-in images which are indeed cached. Sorry if that was confused with "user profile images". There are no performance problems here. In general I have observed no performance issues with Phacility outside of the matter tracked by this very task.

Mar 31 2016, 5:34 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Here's another big problem (IMHO) I just realized: using Phab on mobile or through tethering on your laptop is terrible: the fact user images don't get cached, kills usability: it takes forever to load / reload anything with user images.

Mar 31 2016, 5:11 PM · Restricted Project, Restricted Project, Wikimedia, Files

Mar 29 2016

swisspol added a comment to T10693: Allow setting --plan-changes in Differential UI.

I was expecting this "parameter" to be a checkbox that could be turned on / off on the diff itself, and editable through the creation and edit forms, not through the action system, if that makes sense?

Mar 29 2016, 11:59 PM · Feature Request
swisspol created T10693: Allow setting --plan-changes in Differential UI.
Mar 29 2016, 11:42 PM · Feature Request
ajvorobiev awarded T10682: Applications have no profile photos when they author transactions a Love token.
Mar 29 2016, 6:41 AM · Restricted Project, Harbormaster, Bug Report

Mar 28 2016

swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

No to beat on a dead horse, but I just finished creating a new wiki page with ~20 screenshots of mobile UI (in a series of tables to easily compare UIs on different OSes), and the fact images don't cache is a massive pain:

  • whenever editing the markup, even to add a single character, the preview area needs to reload 2+ MBs of screenshots
  • not only is this slow, but the layout of the preview jumps all around while the images are (re)loading, so you can't navigate easily
  • same thing when saving the changes: everything needs to reload again from scratch and layout jumps again all over the place
Mar 28 2016, 7:24 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol added a comment to T10685: Audit flow improvements.

One of the fundamental features I really like about Phab is how everything is linked nicely: from diffs to tasks to commits to wiki etc... Seems like Audits are surprisingly silo'ed from the rest.

Mar 28 2016, 2:28 AM · Audit, Feature Request
swisspol renamed T10685: Audit flow improvements from Improve Audit flow by linking commits to Audit flow improvements.
Mar 28 2016, 2:27 AM · Audit, Feature Request
swisspol created T10685: Audit flow improvements.
Mar 28 2016, 2:27 AM · Audit, Feature Request

Mar 27 2016

swisspol added a comment to T10682: Applications have no profile photos when they author transactions.

A generic Phab icon would be fine for a first pass at improving this IMO.

Mar 27 2016, 7:02 PM · Restricted Project, Harbormaster, Bug Report
swisspol updated the task description for T10682: Applications have no profile photos when they author transactions.
Mar 27 2016, 5:05 PM · Restricted Project, Harbormaster, Bug Report
swisspol created T10682: Applications have no profile photos when they author transactions.
Mar 27 2016, 5:04 PM · Restricted Project, Harbormaster, Bug Report
swisspol created T10680: If Audit app is uninstalled, you can still add comments to a commit and "raise concern" but it fails with 404.
Mar 27 2016, 4:57 PM · Bug Report

Mar 23 2016

swisspol added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

Thanks! I shall use these powers responsibly 😄

Mar 23 2016, 3:00 AM · Feature Request
swisspol added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

Oops... sorry, can't believe I missed that! I was looking in "Commit Hook: Branches/Tags/Bookmarks" instead of "Commit Content".

Mar 23 2016, 2:18 AM · Feature Request
swisspol created T10653: Add Herald condition to act on pushing commits that have more than 1 parent.
Mar 23 2016, 1:07 AM · Feature Request

Mar 15 2016

swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Understood. I'm of the very same opinion when it comes to adding settings / preferences to a product. It shouldn't be a way to avoid taking a decision or pushing the problem to the user.

Mar 15 2016, 4:09 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Naive question, but would it be possible to have a new "disable security theater" setting and have Phab then do "Unique URL Hash + Fully Cacheable Resources" like everyone else?

Mar 15 2016, 3:57 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

I've rebooted the Windows VM and haven't seen this issue in a few days. So we're good. Thanks for the help.

Mar 15 2016, 3:52 PM · Restricted Project, Harbormaster, Bug Report

Mar 11 2016

swisspol created T10568: Report partially failed builds better in Diffusion history.
Mar 11 2016, 9:49 PM · Restricted Project, Harbormaster, Diffusion, Feature Request

Mar 8 2016

r0bbie awarded T5116: Amazon SES mailer does not allow specifying endpoint a Like token.
Mar 8 2016, 5:01 PM · Mail

Mar 7 2016

swisspol added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

It should not require more than 60 seconds, but rather less than 1 second. Only the Jenkins instance running inside a Windows VM has this intermittent bug though. So it still sounds like a reasonable explanation: maybe Jenkins in Windows gets suspended if not used for some time or the VM itself is paged out on the host HW and takes forever to become responsive, who knows...

Mar 7 2016, 5:52 PM · Restricted Project, Harbormaster, Bug Report

Mar 3 2016

swisspol added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

BTW I realized I forgot to specify in the description of the task that what I'd like to know is why do the logs look like this and what is error 28? Does this come from Phabricator? Is there a lower-level log one could look at?

Mar 3 2016, 5:19 PM · Restricted Project, Harbormaster, Bug Report
swisspol added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

Actually all build plans show these duplicate steps. Is this an (unrelated) bug?

Mar 3 2016, 5:17 PM · Restricted Project, Harbormaster, Bug Report
swisspol added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

OK I just noticed this build plan as 2 duplicate steps (with the same 1.1 identifier)? That certainly shouldn't be the case. Did something get corrupted?

Mar 3 2016, 5:16 PM · Restricted Project, Harbormaster, Bug Report
swisspol created T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Mar 3 2016, 5:15 PM · Restricted Project, Harbormaster, Bug Report

Feb 23 2016

arcdigital awarded T5116: Amazon SES mailer does not allow specifying endpoint a Like token.
Feb 23 2016, 10:55 PM · Mail

Feb 19 2016

swisspol added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

Great, thanks @epriestley!

Feb 19 2016, 6:45 PM · Macros, Remarkup, Bug Report
swisspol added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

Is this the only case of remarkup syntax that is tied to having an app enabled? This should really be documented in https://secure.phabricator.com/book/phabricator/article/remarkup/.

Feb 19 2016, 6:34 PM · Macros, Remarkup, Bug Report
swisspol added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

Yeah, I don't think it used to be like this ~1 year ago.

Feb 19 2016, 6:30 PM · Macros, Remarkup, Bug Report
swisspol added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

Our instance is "hyper" BTW if this helps.

Feb 19 2016, 6:28 PM · Macros, Remarkup, Bug Report
swisspol added a comment to T10394: Font awesome icons not rendering in remarkup on Phacility.

Yes, Macro is uninstalled.

Feb 19 2016, 6:28 PM · Macros, Remarkup, Bug Report
swisspol renamed T10394: Font awesome icons not rendering in remarkup on Phacility from Font awesome icons not rendering in markdown on Phacility to Font awesome icons not rendering in remarkup on Phacility.
Feb 19 2016, 6:24 PM · Macros, Remarkup, Bug Report
swisspol created T10394: Font awesome icons not rendering in remarkup on Phacility.
Feb 19 2016, 6:24 PM · Macros, Remarkup, Bug Report

Feb 2 2016

swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

FWIW I'd be happy to trade performance for security by obscurity aka Facebook model etc... when it comes to files stored in Phabricator - because right now on Phacility, the current approach makes wiki pages with numerous image files feel slow since images are not cached at all. And we don't have anything that sensitive. Maybe a config setting could allow this?

Feb 2 2016, 3:27 AM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol created T10261: Images in Phriction are served with `no-cache` cache-control on Phacility.
Feb 2 2016, 12:59 AM · Bug Report

Jan 17 2016

swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

If I switch the setting to ["http","https","mailto","hyper","itms-services"], then the exception is gone. So I guess the format is a JSON array, not object. But like I said above, hyperlinks don't work at all.

Jan 17 2016, 3:42 PM · Phacility
swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

Ah and when I attempt to save the doc, I get this error:

Unhandled Exception ("InvalidArgumentException")
Jan 17 2016, 3:13 PM · Phacility
swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

Still doesn't seem to work: all links are broken in Phriction:

pasted_file (45×607 px, 9 KB)

Jan 17 2016, 3:12 PM · Phacility
swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

What's the format for setting? I tried ["http","https","mailto","hyper"] but it didn't work and actually breaks all links.

Jan 17 2016, 7:30 AM · Phacility

Jan 14 2016

swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

I'm not sure what you mean by "from the instance panel"? Is it the instance's regular config page?

Jan 14 2016, 9:33 PM · Phacility
swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

Ah. I searched for something like this in config but forgot about the /config/all/ page.

Jan 14 2016, 9:20 PM · Phacility
swisspol updated the task description for T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.
Jan 14 2016, 7:38 PM · Phacility
swisspol created T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.
Jan 14 2016, 7:37 PM · Phacility

Jan 10 2016

swisspol added a comment to T10110: Floating images in Phriction can make everything else afterwards float... forever.

Great, thanks much for the incredible responsiveness 😄

Jan 10 2016, 6:40 PM · Remarkup, Bug Report

Jan 9 2016

swisspol added a comment to T10110: Floating images in Phriction can make everything else afterwards float... forever.

@epriestley Are you sure inline works?

{F60 width=160, layout=inline}  {F60 width=160, layout=inline} {F60 width=160, layout=inline}
Jan 9 2016, 11:43 PM · Remarkup, Bug Report
swisspol added a comment to T10110: Floating images in Phriction can make everything else afterwards float... forever.

Yep, table works, thanks for the idea!

Jan 9 2016, 9:37 PM · Remarkup, Bug Report
swisspol added a comment to T10110: Floating images in Phriction can make everything else afterwards float... forever.

Is there any markup command to "clear the float"?

Jan 9 2016, 8:39 PM · Remarkup, Bug Report
swisspol created T10110: Floating images in Phriction can make everything else afterwards float... forever.
Jan 9 2016, 8:38 PM · Remarkup, Bug Report

Dec 7 2015

renatomassaro awarded T5116: Amazon SES mailer does not allow specifying endpoint a Like token.
Dec 7 2015, 3:59 PM · Mail

Nov 1 2015

mholden awarded T5891: Add button to notification panel to concatenate notifications on the same objects a Love token.
Nov 1 2015, 9:43 PM · Notifications
tycho.tatitscheff awarded T5891: Add button to notification panel to concatenate notifications on the same objects a Love token.
Nov 1 2015, 5:58 PM · Notifications

Oct 15 2015

jithinvmohan awarded P1158 <img> support in remarkup a Love token.
Oct 15 2015, 5:16 PM

Oct 2 2015

john.sandall awarded T5116: Amazon SES mailer does not allow specifying endpoint a Like token.
Oct 2 2015, 4:24 PM · Mail

Sep 4 2015

sketchbookgames awarded T5356: Add ability to display secondary projects in task bubbles on Workboards a Like token.
Sep 4 2015, 4:06 PM · Workboards

Aug 6 2015

swisspol awarded D13811: Unprototype Harbormaster a Love token.
Aug 6 2015, 2:37 PM

Jul 30 2015

swisspol created T9027: Diffusion wrongly attached a Differential revision to a commit following arc backout.
Jul 30 2015, 11:07 PM · Diffusion
swisspol awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Jul 30 2015, 5:20 PM · Projects, Workboards, Wikimedia
swisspol added a comment to T4863: Allow Workboard Cards to be customized for display.

Yes, please add a workboard setting to display all projects on card. My previous request above is almost a year old and user demand has not diminished.

Jul 30 2015, 5:20 PM · Projects, Workboards, Wikimedia
swisspol renamed T9024: In workboard view, show bubbles for other projects in the tasks from Show bubbles for other projects tasks are in in workboard view to In workboard view, show bubbles for other projects in the tasks.
Jul 30 2015, 5:04 PM · Workboards
swisspol created T9024: In workboard view, show bubbles for other projects in the tasks.
Jul 30 2015, 5:03 PM · Workboards