Page MenuHomePhabricator
Feed Advanced Search

Apr 4 2016

paladox added a comment to T10717: arc land does not work on windows.

@chad @epriestley arcanist works straight of the master branch in cmd on windows for me. But git for windows does not work.

Apr 4 2016, 11:30 AM · Windows, Bug Report (Needs Information), Arcanist
paladox updated subscribers of T10717: arc land does not work on windows.
Apr 4 2016, 11:22 AM · Windows, Bug Report (Needs Information), Arcanist
paladox updated subscribers of T10717: arc land does not work on windows.

@hach-que thanks for your suggestion, you helped me. I get different directors from different command line so cmd throughs C:\Program Files\Git\cmd\git.ex whereas git for windows throughs /mingw64/bin/git

Apr 4 2016, 11:22 AM · Windows, Bug Report (Needs Information), Arcanist
paladox created T10718: Please add an option to arc diff or arc land that can create revisions only and not push.
Apr 4 2016, 11:15 AM · Arcanist, Feature Request

Apr 3 2016

paladox added a comment to T10717: arc land does not work on windows.
In T10717#168288, @chad wrote:

I tried to reproduce everything. I have never personally developed on Windows, so everything was done from scratch.

Apr 3 2016, 11:09 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

Yes. It seems it may not be able to find the git. Since git for windows updated a lot of things so I doint know if that check works now. But also I doint know if your check will find git in the 64-bit folder or 32-bit.

Apr 3 2016, 10:52 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@epriestley and @chad ive done some digging at it seems to be this

Apr 3 2016, 10:41 PM · Windows, Bug Report (Needs Information), Arcanist
paladox set the repository for D15597: Fix arc on windows not working with proc_open to rARC Arcanist.
Apr 3 2016, 10:08 PM
paladox added a comment to T10717: arc land does not work on windows.

I'm also not trying to waste your time.

Apr 3 2016, 10:07 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

You did not test the patch. As I noted, the patch runs git fetch --queit instead of git fetch --quiet.

no.png (222×595 px, 32 KB)

You also ignored the large explanatory comment immediately above the changed code which explains why it uses passthru and the specific problem that passthru solves, with a reference to the original issue.

Apr 3 2016, 10:02 PM · Windows, Bug Report (Needs Information), Arcanist
paladox updated the diff for D15597: Fix arc on windows not working with proc_open.
Apr 3 2016, 9:45 PM
paladox added a comment to T10717: arc land does not work on windows.

You did not test the patch. As I noted, the patch runs git fetch --queit instead of git fetch --quiet.

no.png (222×595 px, 32 KB)

You also ignored the large explanatory comment immediately above the changed code which explains why it uses passthru and the specific problem that passthru solves, with a reference to the original issue.

Apr 3 2016, 9:38 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@paladox, your interactions with this upstream have consistently wasted our time and energy.

I warned you about untested patches in D14813. D15597 obviously hasn't been tested either since it misspells --quiet.

You need to read Support Resources, Contributing Bug Reports, and Providing Reproduction Steps very carefully and follow the rules they set out. You need to apply common sense, critical thinking, and basic software engineering skills in interactions with this upstream. If you are unable to do these things, you need to stop interacting with the upstream.

Apr 3 2016, 8:19 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad it seems to be working now

Apr 3 2016, 7:20 PM · Windows, Bug Report (Needs Information), Arcanist
paladox updated subscribers of D15597: Fix arc on windows not working with proc_open.
Apr 3 2016, 7:20 PM
paladox added a comment to D15597: Fix arc on windows not working with proc_open.

Unit tests failed because they used the make command on windows that is not supported yet but soon Ubuntu will be available on windows so we will be able to use that command hopefully.

Apr 3 2016, 7:20 PM
paladox retitled D15597: Fix arc on windows not working with proc_open from to Fix arc on windows not working with proc_open.
Apr 3 2016, 7:19 PM
paladox added a comment to T10717: arc land does not work on windows.

And doing

Apr 3 2016, 6:23 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

Oh ok, I'm not sure why I'm getting it and your not.

Apr 3 2016, 6:16 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad or we could use exec for windows and proc_open for everyone else.

Apr 3 2016, 6:01 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad yes. But php wouldn't stop working like that because of the windows version unless it would.

Apr 3 2016, 5:54 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

Could we add something to bypass proc_open since it seems to be a bug on windows.

Apr 3 2016, 5:49 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

Yep it is passthru proc_open(): proc_open(): CreateProcess causing the problem.

Apr 3 2016, 5:47 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad ive tested it now on your test differential still same problem, I'm using revision https://github.com/phacility/arcanist/commit/57f6fb59d73994d90cd94143787424ce0fdbf73b so it would have failed with proc_open if I was to use the latest revision.

Apr 3 2016, 5:41 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad I will test now.

Apr 3 2016, 5:37 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

It seems arc land carn't find any revisions I created or wont create any.

Apr 3 2016, 5:36 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad how do I get the Arcanist version.

Apr 3 2016, 5:36 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad what details do I give you about my envrioment, because it is setup the same as everyone else.

Apr 3 2016, 5:22 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

when I run arc land it doesn't detect the revision so I have to manually select it.

Apr 3 2016, 5:22 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad the installer just installs the files it doesn't do anything else so all the files are from phabricator except from installer.

Apr 3 2016, 5:16 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad ok.

Apr 3 2016, 4:52 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.
In T10717#168249, @chad wrote:

Is this what you installed? From the page it looks clear that 7.0.4 is a Developer install, not a Stable/Production Install.

pasted_file (295×984 px, 47 KB)

Apr 3 2016, 4:31 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad I get it even on php 5.6

Apr 3 2016, 4:30 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad ok ive installed php 7 64bit from http://windows.php.net/download/ and this is the error I still get

Apr 3 2016, 4:26 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

@chad the php is based on the official one. Just modified a bit to run with wamstack. Unless it is not modified.

Apr 3 2016, 4:03 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T10717: arc land does not work on windows.

Other people having problems with proc_open https://github.com/mikehaertl/phpwkhtmltopdf/issues/56

Apr 3 2016, 3:36 PM · Windows, Bug Report (Needs Information), Arcanist
paladox created T10717: arc land does not work on windows.
Apr 3 2016, 3:34 PM · Windows, Bug Report (Needs Information), Arcanist
paladox added a comment to T4964: Windows installer for Arcanist.

@epriestley and @mattflaschen I have created a windows installer here https://github.com/paladox/Arcanist-installer-for-windows

Apr 3 2016, 12:18 PM · Windows, Arcanist, Setup, Wikimedia

Apr 2 2016

paladox added a comment to T10712: Add support for zuul.

the current features I think that need supporting is

Apr 2 2016, 4:59 PM · Differential, Feature Request
paladox added a comment to T10712: Add support for zuul.

@epriestley well I'm not sure if Harbormaster has a ui but zuul does and makes it so easy.

Apr 2 2016, 4:53 PM · Differential, Feature Request
paladox added a comment to T4964: Windows installer for Arcanist.

There are free installers that create the installation we want like

Apr 2 2016, 4:46 PM · Windows, Arcanist, Setup, Wikimedia
paladox added a project to T10712: Add support for zuul: Differential.
Apr 2 2016, 4:13 PM · Differential, Feature Request
paladox created T10712: Add support for zuul.
Apr 2 2016, 4:12 PM · Differential, Feature Request
paladox created T10711: Create a windows installer for installing arc on windows.
Apr 2 2016, 4:06 PM · Differential, Feature Request

Apr 1 2016

paladox retitled D15563: This is to test from to This is to test.
Apr 1 2016, 6:30 PM
paladox added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

I doint know if we can make it an array.

Apr 1 2016, 6:06 PM · Wikimedia, Restricted Project, Diffusion
paladox added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

@20after4 and @epriestley may we can do

Apr 1 2016, 6:02 PM · Wikimedia, Restricted Project, Diffusion

Mar 16 2016

paladox updated subscribers of D14813: Fix replicating open patches.
Mar 16 2016, 7:21 PM · Diffusion

Mar 3 2016

paladox added a comment to T8612: Improve handling of "large" changesets.

Oh ok, is there a way to set it to unlimited so that a user can choose to do it per file but yes it is unlikely a user will review a million changes but it is always good to check.

Mar 3 2016, 8:07 PM · Restricted Project, Performance, Differential
paladox added a comment to T8612: Improve handling of "large" changesets.

Yes that's what I would like to see please, please allow it to show that over large commits please.

Mar 3 2016, 7:46 PM · Restricted Project, Performance, Differential
paladox added a comment to T8612: Improve handling of "large" changesets.

@epriestley oh because on https://phabricator.wikimedia.org/rAPAW76c6444cfb64e872b8b15688a8999d96af84a406 it dosent do that yet it is only chaning a 100 files.

Mar 3 2016, 7:01 PM · Restricted Project, Performance, Differential
paladox added a comment to T8612: Improve handling of "large" changesets.

Please could you add do something like hide huge changes by default and add a button that will let you see the change please.

Please not, as that already exists. See ""Download Raw Diff"" in the upper right corner of the link you provided.

Mar 3 2016, 6:33 PM · Restricted Project, Performance, Differential
paladox added a comment to T8612: Improve handling of "large" changesets.

@chad no but gitblit can also be a application, https://github.com/gitblit/gitblit its built on java. https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FCentralAuth.git

Mar 3 2016, 6:24 PM · Restricted Project, Performance, Differential
paladox added a comment to T8612: Improve handling of "large" changesets.

Yes there that but if you are on a fast server then that time will be reduced, what about allowing to view per file diff meaning that all of it is hiden but having a user select per file diff that would improve everything and allow for loading quick.

Mar 3 2016, 6:23 PM · Restricted Project, Performance, Differential
paladox added a comment to T8612: Improve handling of "large" changesets.

Hi viewing a diff here https://phabricator.wikimedia.org/rAPAW76c6444cfb64e872b8b15688a8999d96af84a406 causes no diff to show because it is too big.

Mar 3 2016, 6:02 PM · Restricted Project, Performance, Differential

Jan 22 2016

paladox added a comment to T10207: Question: How do you create a mirror to github.

Where do I ask questions.

Jan 22 2016, 5:45 PM · Bug Report
paladox created T10207: Question: How do you create a mirror to github.
Jan 22 2016, 5:38 PM · Bug Report

Dec 18 2015

paladox added a comment to D14813: Fix replicating open patches.

@epriestley I am not sure what I did fixes the problem or if I edited the wrong file.

@paladox: Please test your patches yourself first, before making reviewers spend their time.

Dec 18 2015, 8:42 PM · Diffusion
paladox added inline comments to D14813: Fix replicating open patches.
Dec 18 2015, 5:08 PM · Diffusion

Dec 17 2015

paladox updated the diff for D14813: Fix replicating open patches.

Some minor changes.

Dec 17 2015, 9:33 PM · Diffusion
paladox added a comment to D14813: Fix replicating open patches.

@epriestley is there any way to support system.gitconfig or phabricator.gitconfig file that would allow us to specify which refs to pull allowing us to choose our refs without needing to hard code them.

Dec 17 2015, 9:12 PM · Diffusion
paladox added a comment to D14813: Fix replicating open patches.

@epriestley I am not sure what I did fixes the problem or if I edited the wrong file.

Dec 17 2015, 8:57 PM · Diffusion
paladox added a reviewer for D14813: Fix replicating open patches: epriestley.
Dec 17 2015, 8:56 PM · Diffusion
paladox changed the visibility for D14813: Fix replicating open patches.
Dec 17 2015, 8:55 PM · Diffusion

Dec 11 2015

paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

Hi this files.viewable-mime-types doesn't seem to apply to desktop since testing using an iPhone 6 plus using safari and using a windows 10, edge and internet explorer the iPhone seems to register files.viewable-mime-types and follows what ever is set in it but on desktop it doesn't since for example going to https://phabricator.wikimedia.org/F3069835 on iPhone and then click download it lets you view the raw without needing to download but doing the same on desktop doesn't it downloads the file instead of viewing the file in raw.

Dec 11 2015, 6:25 PM · Diffusion

Dec 8 2015

paladox added a comment to T9934: Add support for downloading zip files or compressed files.

Well this is a feature request not a bug request. There is no problem. This feature would be really useful for users that want to download the whole repo for reasons a user may want to upload the files to his or her server doing git clone will take a few minutes because what if the user doesn't have any software that uses git to download the repo. It may take longer if the user doesn't know how to use the software and how to use for example git clone.

Dec 8 2015, 5:22 PM · Diffusion, Differential, Feature Request
paladox added a comment to T9934: Add support for downloading zip files or compressed files.

Well so that users could just like download zip files not needing to have git or any other program to be able to download the files. Gerrit support this and Wikimedia is moving to phabricator soon.

Dec 8 2015, 5:09 PM · Diffusion, Differential, Feature Request
paladox added projects to T9934: Add support for downloading zip files or compressed files: Differential, Diffusion.
Dec 8 2015, 4:51 PM · Diffusion, Differential, Feature Request
paladox created T9934: Add support for downloading zip files or compressed files.
Dec 8 2015, 4:50 PM · Diffusion, Differential, Feature Request

Nov 26 2015

paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

I am asking phabricator. Since viewing raw php files doesn't work on deskop or laptop. So I am not sure what to set.

Nov 26 2015, 4:39 PM · Diffusion
paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

Hi the workaround works for mobile devices not desktops and laptops.

Nov 26 2015, 4:15 PM · Diffusion

Nov 6 2015

paladox added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

Probaly because the paths are hardcoded please see https://github.com/phacility/phabricator/blob/master/src/applications/diffusion/query/lowlevel/DiffusionLowLevelGitRefQuery.php#L43

Nov 6 2015, 3:41 PM · Wikimedia, Restricted Project, Diffusion
paladox updated the task description for T9726: Hardcode some more refs/ paths.
Nov 6 2015, 3:12 PM · Differential, Diffusion
paladox added a project to T9726: Hardcode some more refs/ paths: Differential.
Nov 6 2015, 3:12 PM · Differential, Diffusion
paladox added a project to T9726: Hardcode some more refs/ paths: Diffusion.
Nov 6 2015, 3:11 PM · Differential, Diffusion
paladox created T9726: Hardcode some more refs/ paths.
Nov 6 2015, 3:11 PM · Differential, Diffusion

Nov 5 2015

paladox created T9721: Support replicator other repos.
Nov 5 2015, 7:14 PM · Wikimedia, Diffusion
paladox added a comment to T4292: Implement repository replication.

Is there any way on replicating from gerrit to phabricator like refs/changes/

Nov 5 2015, 6:51 PM · Restricted Project, Diffusion

Nov 4 2015

paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

This is what it currently looks like

Nov 4 2015, 7:46 PM · Diffusion
paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

Would you be able to do it in a config file or would it have to be done online throught the admin pref for phabricator if it is done through config then Wikimedia open source the file so that any one can propose to change what it does.

Nov 4 2015, 7:42 PM · Diffusion
paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

And how would it be set.

Nov 4 2015, 7:24 PM · Diffusion
paladox added a comment to T8170: Diffusion -> show raw file doesn't always render text.

How can you support all files that can gitblit can view in raw.

Nov 4 2015, 7:24 PM · Diffusion
paladox added a project to T9712: By default allow users to review there own patchs: Diffusion.
Nov 4 2015, 6:48 PM · Diffusion, Differential
paladox created T9712: By default allow users to review there own patchs.
Nov 4 2015, 6:48 PM · Diffusion, Differential
paladox added a comment to T9708: By default allow viewing php files in raw in plain text.

Here is a file shown in raw format

Nov 4 2015, 6:43 PM · Diffusion
paladox added a comment to T9708: By default allow viewing php files in raw in plain text.

Yes I mean in raw when you click on certain files and you click raw it allows you to view them in plain text if you click on any other files such as php it requires you to download the file to view it. Please change it so we can view it as plain text in browser. like gitblit does.

Nov 4 2015, 6:38 PM · Diffusion
paladox created T9708: By default allow viewing php files in raw in plain text.
Nov 4 2015, 10:57 AM · Diffusion

Jun 18 2015

paladox added a comment to T4213: Provide custom themes, skinning, or custom CSS.

Could the images be updated to reflect the recent changes to phabricator. since it looks much modern then that.

Jun 18 2015, 8:24 PM · Design
paladox updated the task description for T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:22 PM · Design
paladox created T8606: Support customised skins and logo.
Jun 18 2015, 8:17 PM · Design

May 28 2015

paladox updated the task description for T8337: Creating and changing theme.
May 28 2015, 1:42 PM · Design
paladox created T8337: Creating and changing theme.
May 28 2015, 1:42 PM · Design

Feb 15 2015

paladox triaged T7274: Support uploading on a mobile as Unbreak Now! priority.
Feb 15 2015, 11:36 AM · Mobile, Files
paladox added a comment to T7274: Support uploading on a mobile.

I am not sure which project this goes into.

Feb 15 2015, 11:36 AM · Mobile, Files
paladox created T7274: Support uploading on a mobile.
Feb 15 2015, 11:35 AM · Mobile, Files