@chad @epriestley arcanist works straight of the master branch in cmd on windows for me. But git for windows does not work.

@hach-que thanks for your suggestion, you helped me. I get different directors from different command line so cmd throughs C:\Program Files\Git\cmd\git.ex whereas git for windows throughs /mingw64/bin/git

In T10717#168288, @chad wrote:

I tried to reproduce everything. I have never personally developed on Windows, so everything was done from scratch.

• Windows 10
• Installed git from https://git-scm.com/download/win (2.8.0)
• Installed PHP from http://windows.php.net/download/ (5.6.20, Non thread safe)
• Installed phabricator, arcanist, libphutil from master/HEAD over ssh
• Add PHP/Arcanist to global paths
• Un-comment libcurl in php.ini
• Install arcanist certificate
• use arc patch to pull down patch (see D15596)
• use arc land to push to master (see 7694a6729f6a)

Yes. It seems it may not be able to find the git. Since git for windows updated a lot of things so I doint know if that check works now. But also I doint know if your check will find git in the 64-bit folder or 32-bit.

@epriestley and @chad ive done some digging at it seems to be this

I'm also not trying to waste your time.

In T10717#168291, @epriestley wrote:

You did not test the patch. As I noted, the patch runs git fetch --queit instead of git fetch --quiet.

You also ignored the large explanatory comment immediately above the changed code which explains why it uses passthru and the specific problem that passthru solves, with a reference to the original issue.

In T10717#168291, @epriestley wrote:

You did not test the patch. As I noted, the patch runs git fetch --queit instead of git fetch --quiet.

You also ignored the large explanatory comment immediately above the changed code which explains why it uses passthru and the specific problem that passthru solves, with a reference to the original issue.

In T10717#168285, @epriestley wrote:

@paladox, your interactions with this upstream have consistently wasted our time and energy.

I warned you about untested patches in D14813. D15597 obviously hasn't been tested either since it misspells --quiet.

You need to read Support Resources, Contributing Bug Reports, and Providing Reproduction Steps very carefully and follow the rules they set out. You need to apply common sense, critical thinking, and basic software engineering skills in interactions with this upstream. If you are unable to do these things, you need to stop interacting with the upstream.

@chad it seems to be working now

Unit tests failed because they used the make command on windows that is not supported yet but soon Ubuntu will be available on windows so we will be able to use that command hopefully.

And doing

Oh ok, I'm not sure why I'm getting it and your not.

@chad or we could use exec for windows and proc_open for everyone else.

@chad yes. But php wouldn't stop working like that because of the windows version unless it would.

Could we add something to bypass proc_open since it seems to be a bug on windows.

Yep it is passthru proc_open(): proc_open(): CreateProcess causing the problem.

@chad ive tested it now on your test differential still same problem, I'm using revision https://github.com/phacility/arcanist/commit/57f6fb59d73994d90cd94143787424ce0fdbf73b so it would have failed with proc_open if I was to use the latest revision.

@chad I will test now.

It seems arc land carn't find any revisions I created or wont create any.

@chad how do I get the Arcanist version.

@chad what details do I give you about my envrioment, because it is setup the same as everyone else.

when I run arc land it doesn't detect the revision so I have to manually select it.

@chad the installer just installs the files it doesn't do anything else so all the files are from phabricator except from installer.

@chad ok.

In T10717#168249, @chad wrote:

Is this what you installed? From the page it looks clear that 7.0.4 is a Developer install, not a Stable/Production Install.

@chad I get it even on php 5.6

@chad ok ive installed php 7 64bit from http://windows.php.net/download/ and this is the error I still get

@chad the php is based on the official one. Just modified a bit to run with wamstack. Unless it is not modified.

Other people having problems with proc_open https://github.com/mikehaertl/phpwkhtmltopdf/issues/56

@epriestley and @mattflaschen I have created a windows installer here https://github.com/paladox/Arcanist-installer-for-windows

the current features I think that need supporting is

@epriestley well I'm not sure if Harbormaster has a ui but zuul does and makes it so easy.

There are free installers that create the installation we want like

I doint know if we can make it an array.

@20after4 and @epriestley may we can do

Oh ok, is there a way to set it to unlimited so that a user can choose to do it per file but yes it is unlikely a user will review a million changes but it is always good to check.

Yes that's what I would like to see please, please allow it to show that over large commits please.

@epriestley oh because on https://phabricator.wikimedia.org/rAPAW76c6444cfb64e872b8b15688a8999d96af84a406 it dosent do that yet it is only chaning a 100 files.

In T8612#163196, @aklapper wrote:

In T8612#163189, @paladox wrote:

Please could you add do something like hide huge changes by default and add a button that will let you see the change please.

Please not, as that already exists. See ""Download Raw Diff"" in the upper right corner of the link you provided.

@chad no but gitblit can also be a application, https://github.com/gitblit/gitblit its built on java. https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FCentralAuth.git

Yes there that but if you are on a fast server then that time will be reduced, what about allowing to view per file diff meaning that all of it is hiden but having a user select per file diff that would improve everything and allow for loading quick.

Hi viewing a diff here https://phabricator.wikimedia.org/rAPAW76c6444cfb64e872b8b15688a8999d96af84a406 causes no diff to show because it is too big.

Where do I ask questions.

In D14813#168741, @aklapper wrote:

In D14813#168571, @paladox wrote:

@epriestley I am not sure what I did fixes the problem or if I edited the wrong file.

@paladox: Please test your patches yourself first, before making reviewers spend their time.

Some minor changes.

@epriestley is there any way to support system.gitconfig or phabricator.gitconfig file that would allow us to specify which refs to pull allowing us to choose our refs without needing to hard code them.

@epriestley I am not sure what I did fixes the problem or if I edited the wrong file.

Hi this files.viewable-mime-types doesn't seem to apply to desktop since testing using an iPhone 6 plus using safari and using a windows 10, edge and internet explorer the iPhone seems to register files.viewable-mime-types and follows what ever is set in it but on desktop it doesn't since for example going to https://phabricator.wikimedia.org/F3069835 on iPhone and then click download it lets you view the raw without needing to download but doing the same on desktop doesn't it downloads the file instead of viewing the file in raw.

Well this is a feature request not a bug request. There is no problem. This feature would be really useful for users that want to download the whole repo for reasons a user may want to upload the files to his or her server doing git clone will take a few minutes because what if the user doesn't have any software that uses git to download the repo. It may take longer if the user doesn't know how to use the software and how to use for example git clone.

Well so that users could just like download zip files not needing to have git or any other program to be able to download the files. Gerrit support this and Wikimedia is moving to phabricator soon.

I am asking phabricator. Since viewing raw php files doesn't work on deskop or laptop. So I am not sure what to set.

Hi the workaround works for mobile devices not desktops and laptops.

Probaly because the paths are hardcoded please see https://github.com/phacility/phabricator/blob/master/src/applications/diffusion/query/lowlevel/DiffusionLowLevelGitRefQuery.php#L43

Is there any way on replicating from gerrit to phabricator like refs/changes/

This is what it currently looks like

Would you be able to do it in a config file or would it have to be done online throught the admin pref for phabricator if it is done through config then Wikimedia open source the file so that any one can propose to change what it does.

And how would it be set.

How can you support all files that can gitblit can view in raw.

Here is a file shown in raw format

Yes I mean in raw when you click on certain files and you click raw it allows you to view them in plain text if you click on any other files such as php it requires you to download the file to view it. Please change it so we can view it as plain text in browser. like gitblit does.

Could the images be updated to reflect the recent changes to phabricator. since it looks much modern then that.

I am not sure which project this goes into.