Differential D20038

Require MFA to edit MFA providers
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:45 PM.

Details

Reviewers

Maniphest Tasks

T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI
T13222: 2018 Week 48-51 Bonus Content

Commits

rPd8d4efe89e85: Require MFA to edit MFA providers

Summary

Depends on D20037. Ref T13222. Ref T7667. Although administrators can now disable MFA from the web UI, at least require that they survive MFA gates to do so. T7667 (bin/auth lock) should provide a sturdier approach here in the long term.

Test Plan

Created and edited MFA providers, was prompted for MFA.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 25 2019, 6:45 PM

Harbormaster completed remote builds in B21701: Diff 47847.Jan 25 2019, 6:46 PM

epriestley requested review of this revision.Jan 25 2019, 6:46 PM

epriestley added a child revision: D20039: Bring Duo MFA upstream.Jan 25 2019, 9:22 PM

amckinley accepted this revision.Jan 28 2019, 5:00 PM

This revision is now accepted and ready to land.Jan 28 2019, 5:00 PM

Closed by commit rPd8d4efe89e85: Require MFA to edit MFA providers (authored by epriestley). · Explain WhyJan 28 2019, 5:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/__phutil_library_map__.php (3 lines)
A	M	src/applications/auth/engine/PhabricatorAuthFactorProviderMFAEngine.php (10 lines)
M		src/applications/auth/storage/PhabricatorAuthFactorProvider.php (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47847	97118e8		Jan 25 2019, 6:45 PM	★	★
Diff 2	47867	44a0b3e	rPd8d4efe89e85a31850164bfa7bd234d9d230c517	Jan 28 2019, 5:44 PM	★	★

Status	Author	Revision
Closed	epriestley	D20043 Allow MFA enrollment guidance to be customized
Closed	epriestley	D20039 Bring Duo MFA upstream
Closed	epriestley	D20038 Require MFA to edit MFA providers
Closed	epriestley	D20037 Replace "Show Secret" in Passphrase with one-shot MFA
Closed	epriestley	D20036 Convert "Rename User" from session MFA to one-shot MFA
Closed	epriestley	D20035 Get rid of "throwResult()" for control flow in MFA factors
Closed	epriestley	D20034 Add more factor details to the Settings factor list
Closed	epriestley	D20033 Update documentation for MFA, including administrator guidance
Closed	epriestley	D20032 Expand outbound mailer documentation to mention SMS and include Twilio
Closed	epriestley	D20031 Allow MFA providers to be deprecated or disabled

Diff 47867

View Options

src/__phutil_library_map__.php

View Options

src/applications/auth/engine/PhabricatorAuthFactorProviderMFAEngine.php

View Options

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Require MFA to edit MFA providersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47867

src/__phutil_library_map__.php

src/applications/auth/engine/PhabricatorAuthFactorProviderMFAEngine.php

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Require MFA to edit MFA providers
ClosedPublic
Actions

Revision Contents
Changeset List