Differential D20004

Move "options(MYSQLI_OPT_LOCAL_INFILE, ...)" call after "real_connect()"
ClosedPublic
Actions

Authored by epriestley on Jan 21 2019, 3:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 5:40 PM

	Unknown Object (File)
	Thu, Jan 23, 9:22 PM

	Unknown Object (File)
	Thu, Jan 23, 9:22 PM

	Unknown Object (File)
	Thu, Jan 23, 9:22 PM

	Unknown Object (File)
	Thu, Jan 23, 2:54 PM

	Unknown Object (File)
	Wed, Jan 22, 12:01 PM

	Unknown Object (File)
	Tue, Jan 21, 9:23 AM

	Unknown Object (File)
	Jan 9 2025, 9:35 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13238: Disallow MYSQLI_OPT_LOCAL_INFILE

Commits

rPHU1d3b33d4ccbf: Move "options(MYSQLI_OPT_LOCAL_INFILE, ...)" call after "real_connect()"

Summary

Fixes T13238. PHP overwrites this setting inside "real_connect()", so we need to apply it after connecting.

Test Plan

Locally, tested that "options()" after "real_connect()" works as expected.
See also PHP upstream bug report: https://bugs.php.net/bug.php?id=77496

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 21 2019, 3:38 PM

Harbormaster completed remote builds in B21618: Diff 47762.Jan 21 2019, 3:39 PM

epriestley requested review of this revision.Jan 21 2019, 3:39 PM

amckinley accepted this revision.Jan 21 2019, 6:00 PM

This revision is now accepted and ready to land.Jan 21 2019, 6:00 PM

Closed by commit rPHU1d3b33d4ccbf: Move "options(MYSQLI_OPT_LOCAL_INFILE, ...)" call after "real_connect()" (authored by epriestley). · Explain WhyJan 21 2019, 6:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

storage/

connection/

mysql/

AphrontMySQLiDatabaseConnection.php

17 lines

Diff 47766

View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Move "options(MYSQLI_OPT_LOCAL_INFILE, ...)" call after "real_connect()"ClosedPublicActions