The points with are solved in this Diff

Ah thanks

I wouldn't expect this to have changed that -- see T4345.

Is it expected that I still receive "Unknown Object" emails? I thought that this task would've solved this issue. Specifically, I received the following email from this install:

These changes were fairly sweeping, so please let me know if you see anything suspicious with mail/feed/notifications.

This seems to be working correctly in HEAD. In particular:

As far as I can tell, we're missing these:

One thing I caught is that things which use Transactions now need to implement ApplicationTransactionInterface. At least one object (PhameBlog) does not. I'll check the rest of the codebase and see if there are any more.

I suppose using a logged-out viewer might be fine, since we'll use the omnipotent viewer if metamta.one-mail-per-recipient is not set, and essentially all installs that use mailing lists probably have this setting configured off.

This change is potentially going to make mailing lists useless for nonpublic installs. Our immediate options are:

Not actually meaningfully stateful:

These Editors are the only ones with state properties:

I hope facilities for supporting non-Gregorian calendar systems such as Persian calendar or Hijri calendar is built into architecture of Phabricator.

See-Also: https://phabricator.wikimedia.org/T493

Just gonna push this over there.

Very true, you are the boss man :D

More just that we'd like to reduce the number of config values we have, and we could possibly get this "for free" if T4103 has "global defaults for all available settings/preferences".

Makes sense, but changing language based on role seems kind of weird, I guess it can be desired in some cases, but either way, you need a way to set the "master"/default value that those roles would inherit

It's vaguely possible that we won't need a separate setting for this after T4103, which is part of the reason I didn't implement it.

We consider the Translation framework to be a "prototype".

Yeah, thanks, tha double quote is the answer. The generater tool is broken currently (i18n extract) I submit a patch somtime to fix this.
The generator extracts string in the following version:

I don't believe we support (take bugs, requests) translating your own instance, though you may if you choose.

Just adding my thoughts.

I can help translating phabricator to Polish (pl_PL).

Actually, T4411 has come along far enough that I wouldn't know that at HEAD.

This is the upstream ticket tracking https://phabricator.wikimedia.org/T84941.

Completed with D11121

Some minor inlines, I'll just fix these in the pull. Thanks!

• Fixed linting issue

Reworked this a bit. This method allows to make translation backword compatible and only filter keys with NULL value. The clean() would be overwritten from translation class to define own cleaner function.

This behaves incorrectly for the translation "0", and I think this filtering should just occur in the translation provider itself. See T6845.

Just have your translation provider class do something like:

Works properly with HTMLoutput

@hach-que and I talked about the policy half of this on IRC recently -- here's a formal task if you want to keep an eye on it.

There's some code which makes an effort to do this already, although I think it never really got hooked up. A few general things here: