Page MenuHomePhabricator
Feed Advanced Search

Jun 11 2015

epriestley renamed T8503: Feed query may fail to progress while paging on 32-bit systems from Awarding a token breaks parts of conduit to Feed query may fail to progress while paging on 32-bit systems.
Jun 11 2015, 4:43 PM · Conduit
epriestley added a comment to T8513: `differential.querydiffs` returns array instead of object when lacking permissions.

I'm also not sure how well arc patch handoff has been working for you, but T8090 has some discussion of some more reliable approaches we're evaluating and moving toward.

Jun 11 2015, 4:41 PM · Conduit
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Jun 11 2015, 4:39 PM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T8513: `differential.querydiffs` returns array instead of object when lacking permissions into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Jun 11 2015, 4:39 PM · Conduit
epriestley added a comment to T8513: `differential.querydiffs` returns array instead of object when lacking permissions.

This is an artifact of the PHP json_encode() method's rules for guessing whether a PHP array is an JSON object or a JSON list.

Jun 11 2015, 4:39 PM · Conduit
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Restricted Differential Revision.
Jun 11 2015, 4:34 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 11 2015, 4:23 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley updated the task description for T8498: Integrate Spaces into shared infrastructure.
Jun 11 2015, 2:44 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 11 2015, 2:30 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 11 2015, 2:06 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 11 2015, 2:02 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

Thanks! 99% sure that's the fix, then: you're on a 32-bit system and the 'int' type can't represent the 64-bit chronologicalKey.

Jun 11 2015, 1:25 PM · Conduit
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

It's possible that the paging code is breaking somehow, although I still haven't been able to reproduce this and can't see any way it could. Can you log the value of $cursor passed to getPagingValueMap() each time through the loop? It should look like this:

Jun 11 2015, 1:11 PM · Conduit
epriestley closed T8502: Add Audit/Review status to Maniphest as Wontfix.

We aren't interested in making this a default.

Jun 11 2015, 12:59 PM · Maniphest
catalindazoot awarded T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction a Mountain of Wealth token.
Jun 11 2015, 12:55 PM · Herald
epriestley added a comment to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

Thanks! I think D13245 should really fix this.

Jun 11 2015, 12:54 PM · Herald
epriestley closed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction as Resolved by committing Restricted Diffusion Commit.
Jun 11 2015, 12:53 PM · Herald
epriestley closed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction, a subtask of T8455: Herald rules with mailing lists are broken after mailing list -> user migration, as Resolved.
Jun 11 2015, 12:53 PM · Herald, Mailing Lists, Restricted Project
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Although T4207 is sort of related, in that it proposes a new kind of "parent/child" relationship (distinct from "blocks / blocked by").

Jun 11 2015, 12:52 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Oh, sorry, I completely misread, ignore me.

Jun 11 2015, 12:47 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

See T4207 for task graphs.

Jun 11 2015, 12:47 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a revision to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction: Unknown Object (Differential Revision).
Jun 11 2015, 12:45 PM · Herald
epriestley closed T8512: Test Task #4 as Invalid.
Jun 11 2015, 12:20 PM
epriestley created T8512: Test Task #4.
Jun 11 2015, 12:19 PM
epriestley closed T8511: Test Task #3 as Wontfix.
Jun 11 2015, 12:19 PM
epriestley created T8511: Test Task #3.
Jun 11 2015, 12:19 PM
epriestley closed T8507: SKIP STAGING as Wontfix.

There is no way to disable this.

Jun 11 2015, 12:08 PM

Jun 10 2015

epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 10 2015, 11:57 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley shifted T8376: Develop Spaces (v1) from the S1 Core space to the S3 Hyperspace space.
Jun 10 2015, 11:52 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 10 2015, 11:51 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

You can likely work around it in the meantime by setting isEmailVerified to 1 in that table. (I expect D13239 will land in the next few hours.)

Jun 10 2015, 9:16 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Sorry, bad at reading. Yeah, that's the issue. D13239 will fix things.

Jun 10 2015, 9:15 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Oh, is auth.email-domains set?

Jun 10 2015, 9:15 PM · Restricted Project, Auth
epriestley added a comment to T8442: Build Space switching UI.

I poked at this a bit, but it doesn't feel great to me, at least with the current header design:

Jun 10 2015, 8:39 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley renamed T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages from login fail to Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.
Jun 10 2015, 8:30 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

D13239 will fix this in some cases.

Jun 10 2015, 8:29 PM · Restricted Project, Auth
epriestley added a revision to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages: Unknown Object (Differential Revision).
Jun 10 2015, 8:24 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Maybe. Do you have approval queues on, or email verification on?

Jun 10 2015, 8:16 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

I can't reproduce this locally.

Jun 10 2015, 8:12 PM · Restricted Project, Auth
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

(If you can, set debug.time-limit to 10 and then repro it; it should give you a more useful stack trace.)

Jun 10 2015, 8:07 PM · Conduit
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

Can you reproduce this by calling feed.query manually from the web UI?

Jun 10 2015, 8:06 PM · Conduit
epriestley added a revision to T8377: Build the core "Spaces" Application: Unknown Object (Differential Revision).
Jun 10 2015, 7:42 PM · Spaces, Wikimedia, Policy
epriestley closed T8484: Maniphest query, order by "Date Updated", inverse ordering as Resolved by committing Restricted Diffusion Commit.
Jun 10 2015, 7:21 PM · Maniphest
epriestley added a comment to T8502: Add Audit/Review status to Maniphest.

No problem, let us know if you run into anything else.

Jun 10 2015, 6:10 PM · Maniphest
epriestley added a comment to T8502: Add Audit/Review status to Maniphest.

You can use maniphest.statuses in Config to create, remove, or change statuses.

Jun 10 2015, 6:04 PM · Maniphest
epriestley added a revision to T8377: Build the core "Spaces" Application: Restricted Differential Revision.
Jun 10 2015, 4:07 PM · Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

I'm also still not totally sure that we need/want icons. I'm probably going to do a diff where we just use the icon everywhere and see if that looks reasonable or not. If it's better than names, we can go from there.

Jun 10 2015, 4:00 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

Hmm.. I'm not sure if we'd pick up enough generic/flexible icons to justify adding it. A lot of the icons seem not-generic-enough or duplicated in Font Awesome.

Jun 10 2015, 3:52 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

After thinking about this, I sort of like reserving some of the more geometric shapes for Badges (T6526), since v1 is probably going to have to use icons.

Jun 10 2015, 3:34 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley closed T8500: Test Task 2 as Invalid.
Jun 10 2015, 2:56 PM
epriestley added a comment to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

I can't reproduce this. I created T8499 and immediately received mail about it to my "molepeople" list:

Jun 10 2015, 2:55 PM · Herald
epriestley created T8500: Test Task 2.
Jun 10 2015, 2:51 PM
epriestley closed T8499: Molepeople Test as Invalid.
Jun 10 2015, 2:48 PM
epriestley created T8499: Molepeople Test.
Jun 10 2015, 2:48 PM
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 10 2015, 2:39 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8424: Integrate Spaces into the core policy infrastructure as Resolved.

This looks like it's done, although we may revisit it after T8434 has a more solid path forward.

Jun 10 2015, 2:33 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8424: Integrate Spaces into the core policy infrastructure, a subtask of T8376: Develop Spaces (v1), as Resolved.
Jun 10 2015, 2:33 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8491: Show a file in Diffusion without knowing the branch.

If you want to pick some unobjectionable "default" token which is not a valid tag or branch name in Git or Mercurial (and, ideally, unlikely to ever be a valid ref in any VCS) I'm happy to implement that and shove it in the documentation. Not great, but seems least-bad to me.

Jun 10 2015, 1:55 PM · Restricted Project, Diffusion
epriestley added a comment to T8491: Show a file in Diffusion without knowing the branch.

I think the original form only worked by accident, we don't use it in the UI anywhere. This behavior likely changed when I fixed T7100.

Jun 10 2015, 1:52 PM · Restricted Project, Diffusion
epriestley added a comment to T8493: Integrate Spaces into more applications.

I'm not sure how much I'd trust a !space command to be honest.

Jun 10 2015, 1:40 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8498: Integrate Spaces into shared infrastructure.
Jun 10 2015, 12:42 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8493: Integrate Spaces into more applications.

I think the difference with the Wikimedia Procurement use case is that tasks with files are created via email (i.e. a provider sends an offer to an email address).

Jun 10 2015, 12:33 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8493: Integrate Spaces into more applications.

At HEAD, the underlying use case discussed on that task should already be secure:

Jun 10 2015, 12:23 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8441: Integrate Spaces into ApplicationSearch.

Here's how it works slightly-ahead-of-HEAD:

Jun 10 2015, 12:08 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8493: Integrate Spaces into more applications: Unknown Object (Differential Revision).
Jun 10 2015, 12:17 AM · Spaces, Wikimedia, Policy, Prioritized

Jun 9 2015

epriestley added a revision to T8493: Integrate Spaces into more applications: Unknown Object (Differential Revision).
Jun 9 2015, 11:56 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 9 2015, 11:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8493: Integrate Spaces into more applications.
Jun 9 2015, 10:59 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8441: Integrate Spaces into ApplicationSearch as Resolved.

I believe this is effectively complete. We'll probably look at revising the control itself at some point, but I think it's likely fine until we do a more complete iteration on these UIs as part of T6943.

Jun 9 2015, 10:46 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8441: Integrate Spaces into ApplicationSearch, a subtask of T8376: Develop Spaces (v1), as Resolved.
Jun 9 2015, 10:46 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8455: Herald rules with mailing lists are broken after mailing list -> user migration as Resolved.

Presuming resolved, yell if anyone's still running into issues.

Jun 9 2015, 10:31 PM · Herald, Mailing Lists, Restricted Project
epriestley merged T8490: Batch editing work board returns a 502 into T5166: Expand the BulkJob tool.
Jun 9 2015, 8:47 PM · Restricted Project, Phacility, Daemons
epriestley merged task T8490: Batch editing work board returns a 502 into T5166: Expand the BulkJob tool.
Jun 9 2015, 8:47 PM · Workboards
epriestley closed T8483: Odd text in inline comment transaction as Resolved by committing Restricted Diffusion Commit.
Jun 9 2015, 8:30 PM · Restricted Project, Transactions, Differential
epriestley added a revision to T8483: Odd text in inline comment transaction: Unknown Object (Differential Revision).
Jun 9 2015, 8:28 PM · Restricted Project, Transactions, Differential
epriestley claimed T8483: Odd text in inline comment transaction.

This has been implicated in other crimes by @csilvers.

Jun 9 2015, 8:19 PM · Restricted Project, Transactions, Differential
epriestley added a comment to T8478: Loading Conpherence handles may recurse indefinitely.

I'll find a way!

Jun 9 2015, 7:59 PM
epriestley closed T8478: Loading Conpherence handles may recurse indefinitely as Resolved.

I'm tentatively going to close this out, but yell if the "Private Correspondence" thing sucks and we can find another approach or find ways to refine it. I sleep better at night knowing handles aren't loading other handles, though.

Jun 9 2015, 7:35 PM
epriestley assigned T8481: Storing secret file in paste to lpriestley.

Implement a new subclass of PassphraseCredentialType which works like PassphraseCredentialTypePassword but stores a large block of text (like a configuration file, or a secret will, or the eldritch words of command which must not fall on mortal ears). This could be called "Note" or "Block" or "Blob" or something similar.

Jun 9 2015, 6:57 PM · Passphrase, Paste
epriestley assigned T8483: Odd text in inline comment transaction to lpriestley.

You've hit this too, do you want to try to figure it out?

Jun 9 2015, 6:55 PM · Restricted Project, Transactions, Differential
epriestley assigned T8486: Implement mentions in Pholio to lpriestley.

This is probably a one-line implements PhabricatorMentionableInterface on PholioMock.

Jun 9 2015, 6:54 PM · Pholio
epriestley assigned T8487: Link in Documentation Does Not Exist to lpriestley.
  • One possible cause of this is the application not being installed. If so, the documentation should make this more clear.
  • Another possible cause is the active link to phabricator.example.com being confusing.
  • The current modern approach to communicating how to get places is to use the {nav X > Y} element to show the user how to navigate: Applications → OAuth Server → Create Application. This is more resistant to UI/URI changes and teaches the user how to use the application.
Jun 9 2015, 6:54 PM · Documentation
epriestley assigned T8484: Maniphest query, order by "Date Updated", inverse ordering to lpriestley.
  • Add an 'outdated' (or similar) key after 'updated'.
    • It should map to the vector array('-updated', '-id').
    • Give 'updated' and 'outdated' human-readable names which better reflect their meanings.
    • It should appear after 'updated' in the order list.
Jun 9 2015, 6:51 PM · Maniphest
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 9 2015, 6:47 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 9 2015, 6:47 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8488: Remove "room" vs "message" distinction.

Oh, I guess T5681 is the better fit, although the two are closely related.

Jun 9 2015, 6:43 PM · Conpherence
epriestley added a comment to T8488: Remove "room" vs "message" distinction.

(And likewise for View Policy.)

Jun 9 2015, 6:42 PM · Conpherence
epriestley added a comment to T8488: Remove "room" vs "message" distinction.

Folding this entire distinction into a modal choice at creation time seems reasonable to me.

Jun 9 2015, 6:41 PM · Conpherence
epriestley added a comment to T8483: Odd text in inline comment transaction.

It's technically accurate!

Jun 9 2015, 1:16 PM · Restricted Project, Transactions, Differential
epriestley added a comment to T8481: Storing secret file in paste.

I plan to add a "note" or "text" type to Passphrase to handle this, but there isn't a good approach now.

Jun 9 2015, 12:48 PM · Passphrase, Paste
joshuaspence awarded T8479: PHPExcel requires XMLWriter Extension a Pterodactyl token.
Jun 9 2015, 8:02 AM · Maniphest
epriestley added a revision to T8478: Loading Conpherence handles may recurse indefinitely: Unknown Object (Differential Revision).
Jun 9 2015, 1:38 AM
epriestley added a comment to T8478: Loading Conpherence handles may recurse indefinitely.

I think I can cheat it in in like 3 lines of code so maybe we can try it and see if it sticks out.

Jun 9 2015, 1:32 AM
epriestley added a comment to T8478: Loading Conpherence handles may recurse indefinitely.

I think the current state is good and would want to keep it in all the non-handle UIs (menu, Conpherence, column, etc.). I'm pretty sure the only places you actually see a Conpherence handle right now are:

Jun 9 2015, 1:28 AM

Jun 8 2015

epriestley closed T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage() as Resolved by committing Restricted Diffusion Commit.
Jun 8 2015, 10:40 PM · Differential
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 8 2015, 10:18 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8478: Loading Conpherence handles may recurse indefinitely.

static title for untitled threads

Jun 8 2015, 10:10 PM
epriestley added a revision to T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage(): Unknown Object (Differential Revision).
Jun 8 2015, 10:07 PM · Differential
epriestley added a comment to T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage().

Well, I think I figured this one out. No one look at the diff, it's real embarrassing.

Jun 8 2015, 10:03 PM · Differential
epriestley updated subscribers of T8478: Loading Conpherence handles may recurse indefinitely.

@btrahan, per D13216, I'd ideally like to stop this class of problem by getting rid of the need for Conpherence threads to load other handles in order to load their own handles (I believe they're the only case where we do that) but that seems a bit tricky since we need them to generate the titles of some threads.

Jun 8 2015, 10:01 PM