Page MenuHomePhabricator
Feed Advanced Search

Jun 18 2015

joshuaspence added a comment to T8599: Exceptions about after extending from Phobject.

Hm, in your original report the stack trace doesn't mention DrydockConstants.

Jun 18 2015, 8:34 AM · Infrastructure, Drydock
mikn added a comment to T8599: Exceptions about after extending from Phobject.

Ah, to recreate this you only need to add a build plan with a "Lease Host" step and you will get this fatal. The class referenced in the first message in the stack trace will be DrydockConstants and not PhabricatorWorkerArchiveTaskQuery though.

Jun 18 2015, 8:28 AM · Infrastructure, Drydock
joshuaspence added a revision to T8599: Exceptions about after extending from Phobject: Restricted Differential Revision.
Jun 18 2015, 8:26 AM · Infrastructure, Drydock
joshuaspence claimed T8599: Exceptions about after extending from Phobject.
Jun 18 2015, 8:14 AM · Infrastructure, Drydock
mikn added a project to T8599: Exceptions about after extending from Phobject: Infrastructure.
Jun 18 2015, 7:34 AM · Infrastructure, Drydock

Jun 15 2015

epriestley added a comment to T8543: Prevent write queries from executing on "r" connections in LiskDAO.

(Just clarifying the title since I thought "write protection" might mean something like makeEphemeral().)

Jun 15 2015, 1:05 PM · Restricted Project, Infrastructure
epriestley renamed T8543: Prevent write queries from executing on "r" connections in LiskDAO from Add write protection for LiskDAO to Prevent write queries from executing on "r" connections in LiskDAO.
Jun 15 2015, 1:05 PM · Restricted Project, Infrastructure
epriestley added a comment to T8543: Prevent write queries from executing on "r" connections in LiskDAO.

Yep, this is correct. Context is that there's no difference today between 'r' and 'w' connections. Distinguishing between them (primarily so we can send some reads to a replica) has always been a theoretical far-future goal, and I think we're mostly consistent about connection use in practice, so this piece hasn't been built yet. Building it would make eventual replica reads easier.

Jun 15 2015, 1:01 PM · Restricted Project, Infrastructure
joshuaspence created T8543: Prevent write queries from executing on "r" connections in LiskDAO.
Jun 15 2015, 11:06 AM · Restricted Project, Infrastructure

Jun 11 2015

aklapper added a project to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Wikimedia.
Jun 11 2015, 11:48 AM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
aklapper created T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Jun 11 2015, 11:48 AM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
Mnkras updated the task description for T8505: Extending testing functionality.
Jun 11 2015, 3:05 AM · libphutil, Infrastructure

Jun 10 2015

joshuaspence created T8505: Extending testing functionality.
Jun 10 2015, 9:36 PM · libphutil, Infrastructure
SalmonKiller added a comment to T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.

I have the same exception when I run ./bin/lipsum generate with the same error message.

Jun 10 2015, 1:58 AM · Paste, Infrastructure

Jun 9 2015

joshuaspence added a comment to T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.

OK, after creating a user I made some progress... but now I hit this:

Jun 9 2015, 8:20 AM · Paste, Infrastructure
joshuaspence added a comment to T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.

Ah actually, this seems to only be an issue when there are no issues in the database.

Jun 9 2015, 8:19 AM · Paste, Infrastructure
joshuaspence created T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.
Jun 9 2015, 8:18 AM · Paste, Infrastructure

Jun 8 2015

joshuaspence created T8477: `./bin/storage probe` truncate table names.
Jun 8 2015, 9:09 PM · Infrastructure
joshuaspence added a comment to T8462: Move object destruction to taskmaster daemons.

I don't, but it maybe stops bad things from happening in cases where destruction takes a bad time? I was destroying a Diviner book and it took a long time so I ^Ced it and ran it again with --trace. I wasn't too worried in this case because Diviner books don't utilize a lot of infrastructure. But for other objects, this could be problematic maybe?

Jun 8 2015, 8:04 PM · Infrastructure, Daemons
epriestley added a comment to T8462: Move object destruction to taskmaster daemons.

Why do you need to destroy enough objects for this to matter?

Jun 8 2015, 1:38 PM · Infrastructure, Daemons
joshuaspence created T8462: Move object destruction to taskmaster daemons.
Jun 8 2015, 2:45 AM · Infrastructure, Daemons

Jun 5 2015

angie added a project to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Project.
Jun 5 2015, 7:47 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley closed T8326: Scripts may try to access PhabricatorStartup, but can not as Resolved by committing Restricted Diffusion Commit.
Jun 5 2015, 12:26 AM · Infrastructure

Jun 4 2015

epriestley closed T8331: phlog can be improved as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 6:49 PM · Infrastructure
epriestley added a revision to T8326: Scripts may try to access PhabricatorStartup, but can not: Restricted Differential Revision.
Jun 4 2015, 6:49 PM · Infrastructure
epriestley claimed T8331: phlog can be improved.

Hitting this again.

Jun 4 2015, 12:46 PM · Infrastructure

Jun 1 2015

epriestley added a comment to T8331: phlog can be improved.

I think it was that phlog($ex) gives us the stack trace of the phlog() call, but if we have to pick one stack trace, the stack trace of the exception is more useful.

Jun 1 2015, 1:21 PM · Infrastructure
joshuaspence placed T8331: phlog can be improved up for grabs.

Having a look at this and I can't actually remember what the issue is.

Jun 1 2015, 1:17 PM · Infrastructure

May 28 2015

joshuaspence claimed T8331: phlog can be improved.
May 28 2015, 12:37 AM · Infrastructure

May 27 2015

joshuaspence created T8331: phlog can be improved.
May 27 2015, 10:53 PM · Infrastructure
epriestley added a comment to T8326: Scripts may try to access PhabricatorStartup, but can not.

A clean-ish but very non-general fix would be to load PhabricatorStartup explicitly before using it in code which might be hit on a non-web pathway. It looks like PhabricatorAccessControlTestCase.php already does this.

May 27 2015, 5:47 PM · Infrastructure
epriestley created T8326: Scripts may try to access PhabricatorStartup, but can not.
May 27 2015, 5:44 PM · Infrastructure

May 21 2015

epriestley added a revision to T8243: Escape console output more thoroughly: Restricted Differential Revision.
May 21 2015, 3:23 PM · Infrastructure

May 20 2015

epriestley edited subtasks for T5752: Navigation menus should work correctly on mobile by default, added: T8099: Mid-2015 Phabricator Redesign; removed: T8239: 2015 Redesign.
May 20 2015, 2:25 PM · ApplicationEditor, Infrastructure, PHUI, Mobile

May 18 2015

Erethon added a comment to T8243: Escape console output more thoroughly.

There is an excellent paper by H D Moore [1] on the subject of security in
terminal emulators regarding control characters. After reading it, I got
inspired and created a couple of proof of concept 'attacks'.

May 18 2015, 11:38 PM · Infrastructure
epriestley created T8243: Escape console output more thoroughly.
May 18 2015, 5:54 PM · Infrastructure
epriestley added a project to T5752: Navigation menus should work correctly on mobile by default: Infrastructure.
May 18 2015, 4:47 PM · ApplicationEditor, Infrastructure, PHUI, Mobile

May 15 2015

btrahan closed T6956: Give PhabricatorDestructionEngine a getViewer() method to reduce omnipotence calls as Resolved by committing Restricted Diffusion Commit.
May 15 2015, 9:07 PM · Infrastructure
btrahan claimed T6956: Give PhabricatorDestructionEngine a getViewer() method to reduce omnipotence calls.
May 15 2015, 9:02 PM · Infrastructure
btrahan added a revision to T6956: Give PhabricatorDestructionEngine a getViewer() method to reduce omnipotence calls: Restricted Differential Revision.
May 15 2015, 9:02 PM · Infrastructure

May 12 2015

joshuaspence added a comment to T8165: Investigate high CPU usage.

I don't know that the requests are slow, just that they are CPU intensive (or maybe there are a lot of them?)

May 12 2015, 9:45 PM · Performance
epriestley added a comment to T8165: Investigate high CPU usage.

In theory, the new "Multimeter" tool may be helpful in understanding this, although we probably need to at least let you put an explicit date window on queries.

May 12 2015, 12:02 PM · Performance
joshuaspence claimed T8165: Investigate high CPU usage.
May 12 2015, 9:35 AM · Performance
joshuaspence created T8165: Investigate high CPU usage.
May 12 2015, 8:02 AM · Performance

May 7 2015

epriestley triaged T7954: Make it easier to upload XHProf profiles as Wishlist priority.
May 7 2015, 1:42 PM · Infrastructure, XHProf

May 6 2015

lpriestley reassigned T8024: Update Calendar event date selection controls from lpriestley to epriestley.
May 6 2015, 1:55 AM · Infrastructure

May 4 2015

epriestley added a comment to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.

Yeah, real apps might be overkill for this.

May 4 2015, 8:35 PM · Infrastructure
joshuaspence added a comment to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.

That sounds reasonable, although a CLI script could suffice I think. ./bin/phid types for example.

May 4 2015, 8:27 PM · Infrastructure
epriestley added a comment to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.

Now that PhabricatorApplicationConfigurationPanel is modular, I'm inclined to do this:

May 4 2015, 4:04 PM · Infrastructure

May 3 2015

epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
May 3 2015, 5:32 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
May 3 2015, 5:28 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
May 3 2015, 5:24 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
May 3 2015, 1:47 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley renamed T6930: Build Multimeter, a "why is Phabricator slow?" toolset from Create a "why is Phabricator slow?" toolset to Build Multimeter, a "why is Phabricator slow?" toolset.
May 3 2015, 1:47 PM · Restricted Project, Performance, Infrastructure, Phacility

May 2 2015

epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
May 2 2015, 11:45 AM · Restricted Project, Performance, Infrastructure, Phacility

Apr 30 2015

epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
Apr 30 2015, 7:30 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
Apr 30 2015, 6:36 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
Apr 30 2015, 5:38 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Restricted Differential Revision.
Apr 30 2015, 3:19 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley claimed T6930: Build Multimeter, a "why is Phabricator slow?" toolset.
Apr 30 2015, 11:53 AM · Restricted Project, Performance, Infrastructure, Phacility

Apr 15 2015

epriestley closed T7803: Implement a composite query which unifies cursor paging across subqueries as Wontfix.

I think I'm going to give up and use offset paging.

Apr 15 2015, 3:20 PM · Typeahead, Infrastructure

Apr 12 2015

epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 11:49 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 11:29 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 11:02 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 10:34 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 9:21 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 8:28 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 8:04 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 6:55 PM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 3:59 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 3:35 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 3:20 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 3:04 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 2:41 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 2:29 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 2:10 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 2:02 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 1:45 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 1:40 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 12:52 AM · Typeahead, Infrastructure
epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 12 2015, 12:24 AM · Typeahead, Infrastructure

Apr 11 2015

epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 11 2015, 4:08 PM · Typeahead, Infrastructure

Apr 10 2015

epriestley added a revision to T7803: Implement a composite query which unifies cursor paging across subqueries: Restricted Differential Revision.
Apr 10 2015, 5:33 PM · Typeahead, Infrastructure
epriestley created T7803: Implement a composite query which unifies cursor paging across subqueries.
Apr 10 2015, 4:29 PM · Typeahead, Infrastructure

Apr 6 2015

btrahan closed T7255: Typeahead shows Source classes for uninstalled applications as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 10:25 PM · Typeahead, Infrastructure
btrahan triaged T7255: Typeahead shows Source classes for uninstalled applications as Wishlist priority.
Apr 6 2015, 7:23 PM · Typeahead, Infrastructure
btrahan claimed T7255: Typeahead shows Source classes for uninstalled applications.
Apr 6 2015, 7:23 PM · Typeahead, Infrastructure
btrahan added a revision to T7255: Typeahead shows Source classes for uninstalled applications: Restricted Differential Revision.
Apr 6 2015, 7:23 PM · Typeahead, Infrastructure

Mar 29 2015

epriestley added a project to T7255: Typeahead shows Source classes for uninstalled applications: Typeahead.
Mar 29 2015, 11:53 PM · Typeahead, Infrastructure

Mar 23 2015

epriestley closed T7485: Clicking one specific greyed out button has no effect as Resolved by committing Restricted Diffusion Commit.
Mar 23 2015, 4:10 PM · Infrastructure

Mar 22 2015

epriestley created T7642: Make ContentSource a property of $viewer.
Mar 22 2015, 1:19 PM · Infrastructure

Mar 21 2015

epriestley renamed T7485: Clicking one specific greyed out button has no effect from Clicking a greyed out button has no effect to Clicking one specific greyed out button has no effect.
Mar 21 2015, 12:06 PM · Infrastructure
epriestley added a revision to T7485: Clicking one specific greyed out button has no effect: Restricted Differential Revision.
Mar 21 2015, 12:05 PM · Infrastructure

Mar 7 2015

joshuaspence added a comment to T7485: Clicking one specific greyed out button has no effect.

Specifically, I would expect to see something like this:

Mar 7 2015, 2:02 AM · Infrastructure
joshuaspence updated the task description for T7485: Clicking one specific greyed out button has no effect.
Mar 7 2015, 1:48 AM · Infrastructure
joshuaspence created T7485: Clicking one specific greyed out button has no effect.
Mar 7 2015, 1:47 AM · Infrastructure

Mar 2 2015

cburroughs added a comment to T7408: Consider dropping support for older versions of PHP.

FWIW RHEL6 is on php 5.3.3.

Mar 2 2015, 4:00 PM · Restricted Project, Infrastructure

Mar 1 2015

epriestley added a subtask for T7408: Consider dropping support for older versions of PHP: T7413: Build an opt-in "report stats to upstream" workflow to collect version/usage data.
Mar 1 2015, 4:23 PM · Restricted Project, Infrastructure
epriestley added a comment to T7408: Consider dropping support for older versions of PHP.

My general thoughts are:

Mar 1 2015, 2:54 PM · Restricted Project, Infrastructure
Mnkras added a comment to T7408: Consider dropping support for older versions of PHP.

I vote for it.
For Namespaces, that is a huge undertaking, you basically scrap the current autoloading, probably go with a PSR-4 autoloader, and add namespaces and "use" to a bunch of files at once.

Mar 1 2015, 5:18 AM · Restricted Project, Infrastructure