Page MenuHomePhabricator
Feed Advanced Search

Jul 30 2019

epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Ops, Restricted Project, Phacility

Jul 24 2019

epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 24 2019, 6:11 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

There's currently a bug (likely related to D20652 or D20654?) where normal edits aren't respecting card order correctly during the redraw. I suspect this is just an order parameter getting lost somewhere.

Jul 24 2019, 5:31 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 24 2019, 5:29 PM · Workboards (v3), User Delight, Wikimedia
epriestley closed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion as Resolved.

Everything has made it to master now so I suspect we're in good shape here.

Jul 24 2019, 5:04 PM · Auth
epriestley closed T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Resolved by committing Restricted Diffusion Commit.
Jul 24 2019, 4:25 PM · Harbormaster
epriestley added a revision to T13348: "Restart All Builds" is misleading in the presence of non-restartable builds: Unknown Object (Differential Revision).
Jul 24 2019, 3:14 PM · Harbormaster
epriestley closed T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Resolved by committing Restricted Diffusion Commit.
Jul 24 2019, 2:09 PM · Feed
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Adjusting log_warnings = 2 in production (to get connection aborts into the error log) is also possibly desirable, although the background level of connection abortions (general network flakiness, server restarts during deploy, wait_timeout on very long-running demons?) may be high enough that this is more noise than signal.

Jul 24 2019, 2:03 PM · Ops, Restricted Project, Phacility

Jul 23 2019

epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: Unknown Object (Differential Revision).
Jul 23 2019, 11:03 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

To reproduce this easily:

Jul 23 2019, 10:57 PM · Feed
epriestley triaged T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Low priority.
Jul 23 2019, 10:47 PM · Feed
epriestley triaged T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Normal priority.
Jul 23 2019, 1:18 PM · Harbormaster
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

We could also consider these things:

Jul 23 2019, 1:10 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

So actual actionable stuff here is:

Jul 23 2019, 1:04 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?) to During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
Jul 23 2019, 12:59 PM · Ops, Restricted Project, Phacility

Jul 22 2019

epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Bumping max_allowed_packet to 1G in the server config resolved things. The export process then spent a long time doing a bin/files migration (which could use a progress bar, maybe) and is now doing a dump (which could too, although I'm less sure of how we'd build one).

Jul 22 2019, 11:52 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
190722 18:55:55 [Warning] Aborted connection 6 to db: '<instance>_differential' user: 'root' host: 'localhost' (Got a packet bigger than 'max_allowed_packet' bytes)
Jul 22 2019, 6:59 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I adjusted innodb_log_file_size to 1GB and attempted the import again, but ran into the same issue.

Jul 22 2019, 6:16 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?).
Jul 22 2019, 6:13 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 22 2019, 5:05 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 22 2019, 4:38 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "go away" on large dumps? to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size".
Jul 22 2019, 4:27 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

The "age of the last checkpoint" error appears to primarily implicate innodb_log_file_size, which is currently set to the default value (5MB):

Jul 22 2019, 4:26 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I'll also double check wait_timeout and interactive_timeout...

Jul 22 2019, 4:01 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Aha! The MySQL error log actually appears to have something useful:

Jul 22 2019, 3:55 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Run it with source ...;

Jul 22 2019, 3:54 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Unzip the dump before running it.

Jul 22 2019, 3:45 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Look at the unzipped dump and see if line 13935 is bad in some obvious way.

Jul 22 2019, 3:40 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Whatever the resolution is here might also motivate tailoring our restore/import instructions, since this error is pretty opaque and the next steps aren't obvious.)

Jul 22 2019, 3:21 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Internally, see also PHI1329.)

Jul 22 2019, 3:18 PM · Ops, Restricted Project, Phacility
epriestley triaged T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting as Low priority.
Jul 22 2019, 3:18 PM · Ops, Restricted Project, Phacility

Jul 20 2019

Krinkle awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Orange Medal token.
Jul 20 2019, 7:07 PM · Auth

Jul 19 2019

aklapper awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Love token.
Jul 19 2019, 11:07 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Not all of this has landed yet, but once it does:

Jul 19 2019, 10:55 PM · Auth
epriestley triaged T13346: Make "bin/auth lock" also lock "Customize Messages" in Auth as Low priority.
Jul 19 2019, 10:36 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 10:30 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 10:05 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 9:51 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 9:41 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 6:17 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 5:27 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 5:21 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 5:02 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 4:42 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

It may be useful to provide helper methods to support normalizing these actor types (e.g., email addresses should be case-insensitive).

Jul 19 2019, 4:34 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 4:28 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 4:02 PM · Auth
epriestley added a comment to T13279: Build Charting for Facts.

Yeah, this is still in a transitional state, it's just been stalled for a bit (not blocked by anything, just other stuff has been getting attention). The two major issues I'm aware of right now are:

Jul 19 2019, 3:54 PM · Plans, Facts
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 2:41 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Unknown Object (Differential Revision).
Jul 19 2019, 2:17 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Another general note is that we also require users go through this flow if they're setting a password for the first time on an account which does not already have a password. For example, this workflow will set up the "set your own password" flow:

Jul 19 2019, 1:10 PM · Auth

Jul 18 2019

epriestley closed T13345: Ferret does not match documents with no title as Resolved by committing Restricted Diffusion Commit.
Jul 18 2019, 5:37 PM · Search
epriestley added a revision to T13345: Ferret does not match documents with no title: Unknown Object (Differential Revision).
Jul 18 2019, 5:22 PM · Search
epriestley triaged T13345: Ferret does not match documents with no title as Low priority.
Jul 18 2019, 5:16 PM · Search
epriestley closed T13342: Support export of "date" and "remarkup" custom fields as Resolved by committing Restricted Diffusion Commit.
Jul 18 2019, 4:59 PM · Custom Fields, Data Exporters
epriestley triaged T13344: "Disable/Enable Provider" action in Auth does not entirely respect "auth.locked" setting as Low priority.
Jul 18 2019, 4:38 PM · Auth
epriestley claimed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Rough intentions here:

Jul 18 2019, 2:49 PM · Auth
am9obgo awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Jul 18 2019, 2:36 PM · Conpherence (v4)

Jul 17 2019

epriestley added a revision to T13342: Support export of "date" and "remarkup" custom fields: Unknown Object (Differential Revision).
Jul 17 2019, 10:57 PM · Custom Fields, Data Exporters
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Potentially don't allow the "Send a login link to your email address" action at all if the corresponding Phab account is already only linked to external accounts for authentication and the installation does not use passwords? But I might lack technical understanding here.

Jul 17 2019, 10:47 PM · Auth
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

We also need --enable-zip to get the zip extension, to get the ZipArchive class, so "Export to Excel" works. See upcoming change on T13342.

Jul 17 2019, 10:27 PM · Infrastructure
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 8:09 PM · Workboards (v3), User Delight, Wikimedia
epriestley moved T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from vNext to Far Future on the Aphlict board.
Jul 17 2019, 6:30 PM · Aphlict, Phacility, Ops
epriestley moved T7013: Support bulk transmission of notification frames in internal Aphlict protocol from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:29 PM · Aphlict, Conpherence
epriestley closed T10823: Aphlict admin server doesn't connect when SSL cert and key are supplied as Wontfix.

This is super old and doesn't have any apparent reproduction instructions.

Jul 17 2019, 6:29 PM · Aphlict, Bug Report
epriestley moved T12908: Allow verbosity of Aphlict log to be reduced from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:28 PM · Aphlict, Feature Request
epriestley added a comment to T4900: Workboards updating in real time.

a logical clock to complement the wall-time clocks

Jul 17 2019, 6:25 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

From D20653:

Jul 17 2019, 6:15 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 6:04 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 5:53 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 5:39 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13342: Support export of "date" and "remarkup" custom fields as Normal priority.
Jul 17 2019, 4:40 PM · Custom Fields, Data Exporters

Jul 15 2019

epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Oh, sorry, I misread which half you were asking about.

Jul 15 2019, 8:53 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Yeah, diffusion.rawdiffquery and diffusion.filecontentquery both do this.

Jul 15 2019, 8:18 PM · Restricted Project, Auth, Conduit
epriestley triaged T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Low priority.
Jul 15 2019, 6:42 PM · Phortune, Phacility

Jul 14 2019

epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

An adjacent issue is that PhabricatorMarkupCache is not currently marked as having cache persistence (PhabricatorConfigTableSchema::PERSISTENCE_CACHE), so the data dumps even when we do not intend to dump data for readthrough caches.

Jul 14 2019, 10:22 PM · Infrastructure
epriestley triaged T13340: "PeopleDatasource" improperly uses "closed" state to sort bot/mailing list results to the bottom of the list as Low priority.
Jul 14 2019, 3:07 PM · Typeahead

Jul 12 2019

20after4 awarded T13322: Allow parent projects to have direct members a Love token.
Jul 12 2019, 6:23 PM · Projects
epriestley closed T10127: Migrating repository between storage hosts in a cluster as Resolved.

I assume this is being done already in the Phacility cluster on some level when repositories get really large, but I'm not particularly sure how to perform this migration.

Jul 12 2019, 5:11 PM · Clusters, Feature Request
epriestley updated the task description for T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.
Jul 12 2019, 5:05 PM · Diffusion, Conduit
epriestley added a project to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases: Diffusion.
Jul 12 2019, 5:04 PM · Diffusion, Conduit
epriestley triaged T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases as Normal priority.
Jul 12 2019, 5:04 PM · Diffusion, Conduit
epriestley triaged T13338: Provide "differential.diff.edit" with an option to create a diff from an uploaded file source as Normal priority.
Jul 12 2019, 4:39 PM · Differential, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T550: Build an SSH conduit client, as Resolved.
Jul 12 2019, 4:28 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings as Resolved.

Deprecate conduit sessions and conduit.connect.
Support direct token-based auth (?token=abdef123) and make this the standard.

Jul 12 2019, 4:28 PM · Restricted Project, Auth, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T9124: Support uploading build log data via the Harbormaster API, as Resolved.
Jul 12 2019, 4:28 PM · Restricted Project, Harbormaster
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls, as Resolved.
Jul 12 2019, 4:28 PM · Conpherence, Phabot
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T7288: configuring certificates for bots is hard/confusing, as Resolved.
Jul 12 2019, 4:28 PM · Documentation
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T6633: 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters, as Resolved.
Jul 12 2019, 4:28 PM · Arcanist
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T10803: PhabricatorApplicationTransactionPublishWorker task failing due to malformed UTF-8, as Resolved.
Jul 12 2019, 4:28 PM · Bug Report (Needs Information)
epriestley triaged T13337: Resolve structural problems with Conduit API methods related to large input/output sizes and binary data as Low priority.
Jul 12 2019, 4:23 PM · Conduit
epriestley triaged T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE as Low priority.
Jul 12 2019, 4:02 PM · Infrastructure

Jul 11 2019

epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

D20647 should fix this. It isn't very satisfying as a general resolution.

Jul 11 2019, 9:50 PM · Javelin
epriestley renamed T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way from Exception "Attempting to add more metadata after metadata has been locked" when trying to view a specific Pholio mockup to Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 11 2019, 9:41 PM · Javelin
epriestley added a revision to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way: Restricted Differential Revision.
Jul 11 2019, 9:40 PM · Javelin
epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

The renderHTMLFooter() method does a bunch of Javascript stuff and isn't actually related to the page footer, but PHUIRemarkupView and renderObjectRefForAnyMedia() were enough of a hint that think I have a reproduction case locally now -- let me figure out what I actually did and this will likely be fairly easy to fix.

Jul 11 2019, 7:53 PM · Javelin

Jul 10 2019

epriestley triaged T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Wishlist priority.
Jul 10 2019, 10:11 PM · Remarkup