Page MenuHomePhabricator
Feed Advanced Search

Nov 29 2016

epriestley added a comment to T11930: Users don't realise that they must link their account.

If the only way to register is Google, it should be impossible to create more than one account per Google account.

Nov 29 2016, 9:37 PM · NUX, Auth
epriestley added a comment to T11930: Users don't realise that they must link their account.

Why is registration disabled?

Nov 29 2016, 9:36 PM · NUX, Auth
joshuaspence added a project to T11930: Users don't realise that they must link their account: NUX.
Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence added a comment to T11930: Users don't realise that they must link their account.

To provide some additional context, we originally allowed users to register their own accounts, but we eventually disabled this because we ended up with around 30 duplicate accounts (users with more than one account). I think that this happened because users had listed an alias address in their Phabricator settings, but Google was using a canonical email address to authenticate, which didn't map to any existing user accounts (we have a lot of users that have aliases set up. For example, abraham@mycompany.com would be an alias for the canonical alincoln@mycompany.com address).

Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence created T11930: Users don't realise that they must link their account.
Nov 29 2016, 9:32 PM · NUX, Auth

Nov 7 2016

epriestley merged T11828: LDAP username change does not update externalaccount table into T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
Nov 7 2016, 3:08 PM · Auth

Oct 31 2016

• nashrafeeg updated Q507: Integrate with custom oauth provider from to Integrate with custom oauth provider .
Oct 31 2016, 12:20 PM · Auth

Oct 12 2016

epriestley added a comment to T4806: Give installs more control over session expiry / prompt for reauth before taking security actions.

Why are users logging into sensitive accounts on shared computers? This action seems inherently unsafe to me.

Oct 12 2016, 3:56 PM · Restricted Project, Auth
leoluk added a comment to T4806: Give installs more control over session expiry / prompt for reauth before taking security actions.

Specific attack scenario: Phabricator is used to host proprietary code. Someone logs into Phabricator on a shared computer and forgets to log out. That shared computer is now forever logged into his account, allowing anyone using it to access said proprietary code. If the cookie would expire or at least be session-only, the risk would be significantly lower.

Oct 12 2016, 10:15 AM · Restricted Project, Auth

Oct 10 2016

• WoolenWang added a comment to T4256: Support Azure as an auth provider.
Oct 10 2016, 11:25 AM · Auth

Sep 30 2016

jcarrillo7 added a comment to T10700: Disable a Username change for the Registration via a Provider.

Thanks for the info!

Sep 30 2016, 10:42 PM · Auth, Feature Request
chad added a comment to T10700: Disable a Username change for the Registration via a Provider.

It's years away if that, and we wouldn't remove an event handler for registration without significant architecture to move it to.

Sep 30 2016, 6:00 PM · Auth, Feature Request
chad added a comment to T10700: Disable a Username change for the Registration via a Provider.

We always do give warnings, yes. I would recommend subscribing to the weekly Changelog.

Sep 30 2016, 5:48 PM · Auth, Feature Request
jcarrillo7 added a comment to T10700: Disable a Username change for the Registration via a Provider.
In T10700#196511, @chad wrote:

It's a solution you can have in production today, at no cost. Evan noted above we have no immediate plans to remove/replace.

Sep 30 2016, 5:47 PM · Auth, Feature Request
chad added a comment to T10700: Disable a Username change for the Registration via a Provider.

It's a solution you can have in production today, at no cost. Evan noted above we have no immediate plans to remove/replace.

Sep 30 2016, 5:37 PM · Auth, Feature Request
jcarrillo7 added a comment to T10700: Disable a Username change for the Registration via a Provider.

@chad is this really a solution? The events documentation clearly states

Sep 30 2016, 5:32 PM · Auth, Feature Request
chad added a comment to T10700: Disable a Username change for the Registration via a Provider.

@jcarrillo7 see T10700#167773 for solution.

Sep 30 2016, 5:19 PM · Auth, Feature Request
chad merged task T11716: External Auth source should be able to lock username and real name attributes when adding a user into T10700: Disable a Username change for the Registration via a Provider.
Sep 30 2016, 5:18 PM · Auth, Feature Request
chad merged T11716: External Auth source should be able to lock username and real name attributes when adding a user into T10700: Disable a Username change for the Registration via a Provider.
Sep 30 2016, 5:18 PM · Auth, Feature Request
chad added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.

actually, maybe can be done with an EventHandler, I'm reading the code here:

Sep 30 2016, 5:16 PM · Auth, Feature Request
chad added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.

PhabricatorRegistrationProfile is what you want, you can lock email, username, and real name.

Sep 30 2016, 5:14 PM · Auth, Feature Request
jcarrillo7 added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.
In T11716#196494, @chad wrote:

I think you can lock this yourself now by using your own AuthAdapter.

Sep 30 2016, 5:11 PM · Auth, Feature Request
jcarrillo7 added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.
In T11716#196493, @chad wrote:

some users decided to use a different username on phabricator

How did they change their username?

Sep 30 2016, 5:09 PM · Auth, Feature Request
chad added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.

I think you can lock this yourself now by using your own AuthAdapter.

Sep 30 2016, 5:06 PM · Auth, Feature Request
chad added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.

some users decided to use a different username on phabricator

Sep 30 2016, 5:04 PM · Auth, Feature Request
jcarrillo7 added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.

@chad I updated the description. I hope this is more of a root problem.

Sep 30 2016, 4:57 PM · Auth, Feature Request
jcarrillo7 updated the task description for T11716: External Auth source should be able to lock username and real name attributes when adding a user.
Sep 30 2016, 4:57 PM · Auth, Feature Request
chad added a comment to T11716: External Auth source should be able to lock username and real name attributes when adding a user.

This doesn't really describe a root problem, see Describing Root Problems. This information is required, so that we may group multiple requests with similar or related problems.

Sep 30 2016, 4:39 PM · Auth, Feature Request
chad closed T7634: How to create a login method with a custom icon? as Invalid.
Sep 30 2016, 4:30 PM · Restricted Project, Auth
jcarrillo7 updated the task description for T11716: External Auth source should be able to lock username and real name attributes when adding a user.
Sep 30 2016, 8:34 AM · Auth, Feature Request
jcarrillo7 created T11716: External Auth source should be able to lock username and real name attributes when adding a user.
Sep 30 2016, 8:14 AM · Auth, Feature Request

Sep 7 2016

epriestley added a comment to T10961: JIRA instructions are a bit out of date with modern JIRA.

We also say "Only supports JIRA 6" but that means "JIRA 6 or newer", since JIRA 7 works fine.

Sep 7 2016, 5:07 PM · Auth, Documentation

Aug 27 2016

epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

Basically, if you want to see this implemented, please describe an attack scenario you're concerned about in detail.

Aug 27 2016, 2:17 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

This is technically easy for us to implement, I'd just like a real security justification for it. From the first link, the justification seems to be:

Aug 27 2016, 1:32 PM · Security, Auth
reed added a comment to T9770: It is possible to use the same 2FA token more than once.

See https://github.com/tinfoil/devise-two-factor/issues/30 and https://github.com/mdp/rotp/issues/44 for some discussion about this issue (also discussed a bit on oss-security mailing list as http://www.openwall.com/lists/oss-security/2015/06/20/4).

Aug 27 2016, 8:33 AM · Security, Auth

Aug 25 2016

bgamari added a comment to T4587: Generate SSH keys for users.

GHC would also find support for importing keys from Github useful; we are currently working on rolling out a Diffusion-hosted staging area for use with Harbormaster but the need for contributors to submit their key to yet another Phab feels like unnecessary friction.

Aug 25 2016, 7:12 PM · Auth, Passphrase

Aug 22 2016

jcarrillo7 added a comment to T11514: Authentication should have a way to customize the credentials name.

Ah yes I forgot about the fun of internationalization. Btw those fragments are correct 👍🏻 (I speak Spanish).

Aug 22 2016, 10:48 PM · Auth, LDAP, Feature Request
epriestley added a comment to T11514: Authentication should have a way to customize the credentials name.

Strings with sentence fragments like that can be difficult to translate in the normal human language sense, see:

Aug 22 2016, 10:34 PM · Auth, LDAP, Feature Request
jcarrillo7 added a comment to T11514: Authentication should have a way to customize the credentials name.

The translation.override settings seems to be the easiest path forward. I definitely don't want to be modifying the source if I can help it.

Aug 22 2016, 10:15 PM · Auth, LDAP, Feature Request
epriestley added a comment to T11514: Authentication should have a way to customize the credentials name.

This is probably something we'll need in the very long run for T6703 (if we legitimately let you connect to two different LDAP servers, it would be silly to have two "Login with LDAP" dialogs) but, yeah, using translation.override or just editing PhabricatorLDAPAuthProvider might be the shortest path today.

Aug 22 2016, 10:04 PM · Auth, LDAP, Feature Request
chad added a comment to T11514: Authentication should have a way to customize the credentials name.

Can you just override the translation? /config/edit/translation.override/

Aug 22 2016, 9:59 PM · Auth, LDAP, Feature Request
jcarrillo7 added a comment to T11514: Authentication should have a way to customize the credentials name.

Essentially I would like to customize the "Login or register with LDAP" here to be "Login or register with OpenDirectory"

Login.png (808×1 px, 51 KB)

Aug 22 2016, 9:26 PM · Auth, LDAP, Feature Request
jcarrillo7 created T11514: Authentication should have a way to customize the credentials name.
Aug 22 2016, 9:24 PM · Auth, LDAP, Feature Request
• cgdd0039 added a comment to T2549: Support linking multiple external accounts from the same provider with one Phabricator account.
  • I deleted the @mierle account.
  • It's currently not possible to link a Phabricator account to more than one external account of a given type (where "type" is one of "Facebook", "Google", "GitHub", etc.). In hindsight this was an architectural mistake, but I didn't think about it at the time and left us with a mess to clean up. It will be resolved by {T1536}, which is a sort of umbrella task for remedying various missteps on the auth pathway. We've made some progress on that, but it will be at least a little while before it lands.
Aug 22 2016, 8:07 AM · Restricted Project, Restricted Project, LDAP, Auth, OAuthServer

Aug 8 2016

chad closed T11441: Add IMAP authentication support as Invalid.

Closing as invalid since we have no idea what this request is even for. IMAP is a mail protocol, and I'm not sure what you're asking us to do with it.

Aug 8 2016, 2:49 AM · Auth, Feature Request

Aug 7 2016

chad added a comment to T11441: Add IMAP authentication support.

See Contributing Feature Requests and Describing Root Problems for what information we require in a feature request.

Aug 7 2016, 11:46 PM · Auth, Feature Request
imsoftware created T11441: Add IMAP authentication support.
Aug 7 2016, 11:18 PM · Auth, Feature Request

Aug 5 2016

eadler added a project to T9515: Build a "quorum" mechanism and associated UI: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Notifications, Phacility, Auth
eadler added a project to T5504: Figure out how to render external accounts in the UI: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Auth
eadler added a project to T5351: Phabricator shows "Anyone can register an account" even if no registration-enabled auth providers exist: Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Auth
eadler added a project to T5591: Add default domain to Google auth: Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Restricted Project, Auth
eadler added a project to T7634: How to create a login method with a custom icon?: Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Auth

Jul 26 2016

fooishbar added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

@epriestley Missed a spot: D16325

Jul 26 2016, 10:28 AM · Mobile, Auth, Feature Request
fooishbar added a revision to T11365: TOTP challenge entry not marked numeric-only on mobile: Restricted Differential Revision.
Jul 26 2016, 10:26 AM · Mobile, Auth, Feature Request

Jul 24 2016

epriestley closed T11365: TOTP challenge entry not marked numeric-only on mobile as Resolved by committing Restricted Diffusion Commit.
Jul 24 2016, 4:13 AM · Mobile, Auth, Feature Request

Jul 23 2016

epriestley added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

D16323 uses <input type="text" pattern="\d*" />, which appears to have the best behavior.

Jul 23 2016, 8:32 PM · Mobile, Auth, Feature Request
epriestley added a revision to T11365: TOTP challenge entry not marked numeric-only on mobile: Restricted Differential Revision.
Jul 23 2016, 8:30 PM · Mobile, Auth, Feature Request
epriestley added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

On iOS 9.2 in the simulator, <input type="number" /> gives you this keyboard:

Jul 23 2016, 8:27 PM · Mobile, Auth, Feature Request
epriestley added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

Oh, there's a "Toggle Software Keyboard" option that I somehow disabled.

Jul 23 2016, 8:22 PM · Mobile, Auth, Feature Request
epriestley added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

On iPhone Simulator, the behavior of <input type="number" /> appears to be "draw the keyboard for 1 frame and then immediately hide it".

Jul 23 2016, 8:19 PM · Mobile, Auth, Feature Request
chad added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

Looks like an iPhone with Gboard keyboard.

Jul 23 2016, 8:18 PM · Mobile, Auth, Feature Request
epriestley added a comment to T11365: TOTP challenge entry not marked numeric-only on mobile.

Offhand, do you know if <input type="number" /> has the desired behavior on your device?

Jul 23 2016, 8:11 PM · Mobile, Auth, Feature Request
epriestley claimed T11365: TOTP challenge entry not marked numeric-only on mobile.
Jul 23 2016, 8:07 PM · Mobile, Auth, Feature Request

Jul 22 2016

chad added a project to T11365: TOTP challenge entry not marked numeric-only on mobile: Mobile.
Jul 22 2016, 6:34 PM · Mobile, Auth, Feature Request
chad edited projects for T11365: TOTP challenge entry not marked numeric-only on mobile, added: Feature Request, Auth; removed Bug Report.
Jul 22 2016, 6:31 PM · Mobile, Auth, Feature Request

Jul 8 2016

epriestley triaged T11277: Provide a generic SSH public key store for users as Wishlist priority.
Jul 8 2016, 11:34 AM · Auth, Feature Request

Jul 7 2016

epriestley closed T5275: Activate Twitter as External Auth Provider for https://secure.phabricator.com as Wontfix.

We haven't gotten to this in two years and haven't really seen other interest. We already support ~8 providers.

Jul 7 2016, 6:18 PM · Auth

Jul 4 2016

eadler moved T2549: Support linking multiple external accounts from the same provider with one Phabricator account from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:19 PM · Restricted Project, Restricted Project, LDAP, Auth, OAuthServer
eadler moved T4184: API does not contain user.create from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, FreeBSD, Auth, Conduit
eadler moved T4806: Give installs more control over session expiry / prompt for reauth before taking security actions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, Auth
eadler moved T10095: provide administrators more hints to track down initial failed logins from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:06 PM · Restricted Project, Restricted Project, Auth, Feature Request
eadler moved T1205: Allow grey users in some form or other from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:06 PM · Restricted Project, People, Auth, Wikimedia
eadler moved T9512: "Change Password" should prompt users to "Reset Password" if no password has been set from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:06 PM · Restricted Project, Auth
eadler moved T8630: Prompt users when they login with an account that has changed email addresses from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:06 PM · Restricted Project, Auth
eadler moved T6549: Backup codes for multi-factor authentication from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:06 PM · Restricted Project, Auth
eadler moved T5953: Build a modular user account batch importer from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:06 PM · Restricted Project, Auth, Projects
eadler moved T814: Support HTTP Basic Auth as an authentication mechanism from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:05 PM · Restricted Project, OpenStack, Auth

Jul 2 2016

epriestley closed T10785: Allow custom third-party auth providers to implement autologin as Resolved.

The upstream part of this is working in production, and this is now accounted for.

Jul 2 2016, 3:13 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley removed a project from T7441: Support OAuth providers in the cluster: Prioritized.

A substantial number of users have linked Google accounts in production and we haven't heard about any issues, so I think that aspect of things is in good shape.

Jul 2 2016, 3:04 PM · Auth, Phacility

Jun 23 2016

epriestley merged T10525: "Ghost" user created in external accounts table under certain circumstances into T5953: Build a modular user account batch importer.
Jun 23 2016, 12:49 PM · Restricted Project, Auth, Projects
epriestley merged task T10525: "Ghost" user created in external accounts table under certain circumstances into T5953: Build a modular user account batch importer.
Jun 23 2016, 12:49 PM · LDAP, Auth, Bug Report
epriestley added a comment to T10525: "Ghost" user created in external accounts table under certain circumstances.

I'm just going to merge this into T5953. The LDAP importer is a contributed patch from yesteryear which we wouldn't bring upstream today, and unlikely to see improvements outside of a more formal upstream effort in T5953.

Jun 23 2016, 12:49 PM · LDAP, Auth, Bug Report

Jun 21 2016

andypuettmann added a comment to T10221: upgrading to ubuntu 15.10 breaks google authentication.

also affected by this, same report/errormessage.

Jun 21 2016, 9:33 PM · Auth, Bug Report

Jun 17 2016

epriestley closed T10917: Build Glorious High-Security Notification/Audit Infrastructure as Resolved.

I believe this is resolved and accounted for, let us know if anyone runs into issues.

Jun 17 2016, 2:01 AM · Auth, Prioritized, Security, Feature Request

Jun 16 2016

angel added a comment to T11156: Exception on auth configuration.

Pulled and working! Thanks a lot!

Jun 16 2016, 1:12 PM · Auth, Bug Report
epriestley added a comment to T11156: Exception on auth configuration.

This should be fixed at HEAD of master. Let us know if you're still seeing issues after updating.

Jun 16 2016, 1:06 PM · Auth, Bug Report
epriestley closed T11156: Exception on auth configuration as Resolved by committing Restricted Diffusion Commit.
Jun 16 2016, 1:04 PM · Auth, Bug Report
epriestley added a comment to T11156: Exception on auth configuration.

Thanks for the report! This should be fixed once D16128 is reviewed, likely later today.

Jun 16 2016, 10:47 AM · Auth, Bug Report
epriestley added a revision to T11156: Exception on auth configuration: Restricted Differential Revision.
Jun 16 2016, 10:46 AM · Auth, Bug Report
epriestley claimed T11156: Exception on auth configuration.
Jun 16 2016, 10:46 AM · Auth, Bug Report
angel added a project to T11156: Exception on auth configuration: Auth.
Jun 16 2016, 8:44 AM · Auth, Bug Report

Jun 13 2016

epriestley moved T7441: Support OAuth providers in the cluster from The Queue to Paused on the Prioritized board.
Jun 13 2016, 5:48 PM · Auth, Phacility
epriestley added a comment to T7441: Support OAuth providers in the cluster.

I enabled Google for central auth since I think everything we need for it to work already works fine in the cluster, although it's possible some of the invite flow stuff is a little shaky.

Jun 13 2016, 5:39 PM · Auth, Phacility
epriestley moved T7441: Support OAuth providers in the cluster from Paused to The Queue on the Prioritized board.
Jun 13 2016, 2:21 PM · Auth, Phacility

Jun 6 2016

epriestley moved T10785: Allow custom third-party auth providers to implement autologin from Backlog to Paused on the Prioritized board.
Jun 6 2016, 8:32 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley claimed T10785: Allow custom third-party auth providers to implement autologin.
Jun 6 2016, 8:15 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley added a comment to T10785: Allow custom third-party auth providers to implement autologin.

Here's the new AuthProvider code for OAuth2 autologin after D16060:

Jun 6 2016, 8:14 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley added a revision to T10785: Allow custom third-party auth providers to implement autologin: Restricted Differential Revision.
Jun 6 2016, 8:13 PM · Prioritized, Auth, Restricted Project, Feature Request
eadler moved T10785: Allow custom third-party auth providers to implement autologin from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 6 2016, 8:09 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley added a project to T10785: Allow custom third-party auth providers to implement autologin: Prioritized.

I'm going to support third-party (as here) and OAuth2 (easy) but we have no use cases for other stuff right now (mostly OAuth1 on Twitter/Jira/Bitbucket, I think).

Jun 6 2016, 8:02 PM · Prioritized, Auth, Restricted Project, Feature Request