I spent like 20 minutes on this in the redesign and couldn't figure it out.

Yeah, I think the existing "Edit" page should really be more like the "Manage" page in Projects that anyone who can see the repository can see.

Also, view the edit history: https://phabricator.wikimedia.org/T128679

Oh, there are also really two issues here, but only one that I think is actually hard:

Yeah, that's broadly the "think about" part in the task title -- I don't have a good answer. I'm not quite sure how to reconcile diffusion.edit with the current multi-page form.

Doesn't making an edit endpoint that is similar to the ApplicationEditor endpoint bypass the multi-page setup (And lets people shoot themselves if the foot)? RepositoryCreateController seems to be fully transactions-based now.

Broadly, here are the general issues we've currently seen with Diffusion URIs:

It has been greatly improved.

sorry i might have let the interns play with the board for marketing purposes

Oh, never mind, I figured it out. :3

@chad Was that just testing something, or a vote for this as a substantial problem?

I just added about 100 staging repositories by hand. I hope I spelled everything right!

D15302 was the change I was most worried about here, and it seems to have been entirely straightforward. I now expect to move forward like this:

For repositories with a short name like "codebase", I imagine users would prefer /diffusion/codebase/ over /diffusion/123/ as the canonical URI.

My planned pathway forward here is:

Thank you very much for the quick fix. I already updated my Phabricator installation and it works perfectly now.

Ugh, the lint stuff also uses PhabricatorRepositoryBranch, although I suppose they can be moved off separately.

Per Q314, we also need to fix the coverage table. I'm not grossly disgusted with the +J{...} hack in D15286 but I think we need to add some kind of table to replace branchID like this:

I can't reproduce this. Here's what I did:

I think this should be fixed in HEAD, let me know if I missed anything. Thanks for the report (and the patches; I did approximately the same thing in D15282).