Page MenuHomePhabricator
Feed Advanced Search

Jun 5 2015

epriestley added a comment to T8448: Relative dates for saved searches.

No problem!

Jun 5 2015, 7:41 PM · Restricted Project
epriestley added a comment to T8444: Increase typeahead speed.

Oh, you may have to click "(All)" under Request to expand that column to make it look like the screenshot.

Jun 5 2015, 7:21 PM · Typeahead, PHUI, Restricted Project
epriestley added a comment to T8444: Increase typeahead speed.

These execute with a median speed of about 150ms on this install, for the ~1,200 requests made in the last 24 hours (this is across all typeahead source types).

Jun 5 2015, 7:21 PM · Typeahead, PHUI, Restricted Project
epriestley added a comment to T8448: Relative dates for saved searches.

Specifically, when we visited, @liza requested this and then executed a working relative date search, so I assume this was just from an out-of-date list of requests.

Jun 5 2015, 7:13 PM · Restricted Project
epriestley added a comment to T8448: Relative dates for saved searches.

Oh, I suppose it could be.

Jun 5 2015, 7:12 PM · Restricted Project
epriestley added a comment to T8448: Relative dates for saved searches.

This already works. "2 months ago" and "1 week ago" both work exactly like that.

Jun 5 2015, 7:10 PM · Restricted Project
epriestley added a comment to T8376: Develop Spaces (v1).

A very rough version of things is available to play around with on this install, now. I've created two spaces:

Jun 5 2015, 6:29 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a member for Space Test Users: epriestley.
Jun 5 2015, 6:26 PM
epriestley removed a member for Space Test Users: epriestley.
Jun 5 2015, 6:26 PM
epriestley added a member for Space Test Users: epriestley.
Jun 5 2015, 6:25 PM
epriestley removed a member for Space Test Users: epriestley.
Jun 5 2015, 6:25 PM
epriestley created Space Test Users.
Jun 5 2015, 6:23 PM
epriestley updated the task description for T8442: Build Space switching UI.
Jun 5 2015, 5:42 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

Note that you'll be able to search for objects in a specific space using the query interface (T8441) independent of any global settings. So you can always explicitly search for stuff in the "Operations" (or whatever else) space, the product question here is just whether we need additional global/default settings to make "switching into a space" an (optionally) more all-consuming operation.

Jun 5 2015, 5:38 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley created T8442: Build Space switching UI.
Jun 5 2015, 5:36 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley edited the content of Roadmap.
Jun 5 2015, 5:18 PM
epriestley moved T8441: Integrate Spaces into ApplicationSearch from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 5:17 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 5:10 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

Thanks for writing that up!

Jun 5 2015, 5:05 PM · Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 4:24 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 4:24 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 4:06 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 4:06 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8441: Integrate Spaces into ApplicationSearch.

(This is only partially blocked by work described in T7715, but I'm linking it here for completeness and to make it easier for me to dig up.)

Jun 5 2015, 4:03 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a subtask for T8441: Integrate Spaces into ApplicationSearch: T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Jun 5 2015, 4:02 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a parent task for T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: T8441: Integrate Spaces into ApplicationSearch.
Jun 5 2015, 4:02 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 3:20 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8441: Integrate Spaces into ApplicationSearch.
Jun 5 2015, 3:19 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8437: Still can change the task's status to "resolved" while the blocking tasks are not as Wontfix.

This is intentional. This increases flexibility and we aren't currently aware of any problems which are best solved by preventing this.

Jun 5 2015, 2:31 PM
epriestley moved T8434: Accommodate the "Security" workflow from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 2:24 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

Users who don't understand it. And - off the top of my head - I'd quite like our custom 'security' option simply be the name of a pre-defined policy (we don't want unprivileged users to be able to set arbitrary policies, that can only result in a mess), but I haven't really thought through all of the implications of this.

Jun 5 2015, 2:07 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

From https://phabricator.wikimedia.org/T76401, maybe that's actually ideal/desirable, and @chasemp's concerns aren't related to this use case (or perhaps are allayed by "hard spaces")?

Jun 5 2015, 1:44 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

How would you like the flow where you give permission to new users to work? In T4411, @chasemp expressed some concerns about using CC/Subscribers for this (particularly, that users can add other users to CC). Do you share those concerns, or is adding users to CC to give them rights satisfactory for you?

Jun 5 2015, 1:37 PM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 1:19 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

unless the Nuance entry was basically just a special task, where we could have to option to continue as normal while including the reporter

Jun 5 2015, 12:49 PM · Wikimedia, Policy, Prioritized
epriestley updated subscribers of T8376: Develop Spaces (v1).

Development Log

Jun 5 2015, 12:02 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8434: Accommodate the "Security" workflow.

Yeah, the "Security" use case is letting users see objects in a Space they normally don't have access to because they have some special relationship to those objects (for example, giving users access to security tasks if they reported them).

Jun 5 2015, 11:38 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 3:49 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 3:06 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 2:56 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jun 5 2015, 2:19 AM · Wikimedia, Policy, Prioritized
epriestley created T8434: Accommodate the "Security" workflow.
Jun 5 2015, 2:18 AM · Wikimedia, Policy, Prioritized
epriestley deleted Nerdjumbo.
Jun 5 2015, 1:57 AM
epriestley deleted M2Q.
Jun 5 2015, 1:57 AM
epriestley moved T8424: Integrate Spaces into the core policy infrastructure from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 1:48 AM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T7114: $_SERVER stuff from the preamble is getting overwritten in PhabricatorStartup as Resolved by committing Restricted Diffusion Commit.
Jun 5 2015, 12:27 AM · Setup
epriestley closed T8326: Scripts may try to access PhabricatorStartup, but can not as Resolved by committing Restricted Diffusion Commit.
Jun 5 2015, 12:26 AM · Infrastructure
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 5 2015, 12:21 AM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8433: Destroying a Diviner book is very slow.

Looks like the feed_storynotification queries are the slowest ones; there's no objectPHID key on that table.

Jun 5 2015, 12:17 AM · Diviner

Jun 4 2015

epriestley added a comment to T4245: Make repository URIs slightly prettier.

Note that it takes your money immediately -- not when a specific goal is reached (so it's not like Kickstarter) -- but I'll, uh, do this proportionately sooner relative to how much funding I3 gets I guess, unless someone wants to separately prioritize making Fund work like Kickstarter.

Jun 4 2015, 9:38 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T8401: Unable to query Diviner atoms by PHID.

Yeah, that seems reasonable to me.

Jun 4 2015, 8:54 PM · Diviner
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 8:45 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8428: Allow packages to be disabled.
Jun 4 2015, 8:32 PM · Owners
epriestley added a comment to T8427: Make owners typeahead browsable so installs can have more than 100 packages.

Unclear if this is really a 100-package limit, but some kind of limiting is probably happening.

Jun 4 2015, 8:31 PM · Owners
epriestley created T8427: Make owners typeahead browsable so installs can have more than 100 packages.
Jun 4 2015, 8:30 PM · Owners
epriestley renamed T8424: Integrate Spaces into the core policy infrastructure from '"><img src=x onerror=alert(1);> to Integrate Spaces into the core policy infrastructure.
Jun 4 2015, 7:55 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 7:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 7:36 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 7:19 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7114: $_SERVER stuff from the preamble is getting overwritten in PhabricatorStartup: Unknown Object (Differential Revision).
Jun 4 2015, 6:59 PM · Setup
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 6:59 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8331: phlog can be improved as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 6:49 PM · Infrastructure
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Unknown Object (Differential Revision).
Jun 4 2015, 6:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8326: Scripts may try to access PhabricatorStartup, but can not: Unknown Object (Differential Revision).
Jun 4 2015, 6:49 PM · Infrastructure
epriestley created T8424: Integrate Spaces into the core policy infrastructure.
Jun 4 2015, 6:44 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

They're a function of an individual commit instead of being a function of the repository as a whole, so we'd have to do a lot more work to support them (it's not meaningful to, say, "list all tags in the repository", as it is with Git), and I suspect they're not used much in the wild because of how they work. I'm not sure if this is true or not.

Jun 4 2015, 5:29 PM · Mercurial, Diffusion
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 4 2015, 5:03 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8415: Transaction requires a handle that it did not load as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 1:05 PM · Transactions
epriestley claimed T8331: phlog can be improved.

Hitting this again.

Jun 4 2015, 12:46 PM · Infrastructure
epriestley added a comment to T8415: Transaction requires a handle that it did not load.

T8415

Jun 4 2015, 12:42 PM · Transactions
epriestley added a comment to T8415: Transaction requires a handle that it did not load.

I think you need to add a mention.

Jun 4 2015, 12:42 PM · Transactions
epriestley added a comment to T8415: Transaction requires a handle that it did not load.

Thanks, looking at this now.

Jun 4 2015, 12:42 PM · Transactions
epriestley updated subscribers of T8362: Set date time account preferences.
Jun 4 2015, 12:30 PM · User Preferences, Calendar
epriestley merged task T8414: Dates are rendered incorrectly for Australia/Melbourne timezone into T8362: Set date time account preferences.
Jun 4 2015, 12:30 PM
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users as Resolved.

See T8398 for any followup issues.

Jun 4 2015, 2:43 AM · FreeBSD, Mailing Lists, Mail
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users, a subtask of T6367: Send email with recipient's language and access levels, not sender's, as Resolved.
Jun 4 2015, 2:43 AM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T8398: Upgrading: Changes to Mailing Lists.

This migrated cleanly on this install, although we only had one real mailing list plus a handful of old invalid test lists (although these errored out correctly). If you run into problems with the migration or otherwise, let me know.

Jun 4 2015, 2:41 AM · Installing & Upgrading, People, Mail, Guides
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

These changes were fairly sweeping, so please let me know if you see anything suspicious with mail/feed/notifications.

Jun 4 2015, 2:40 AM · Wikimedia, Security, Localization, Mail
epriestley closed T6367: Send email with recipient's language and access levels, not sender's as Resolved.

This seems to be working correctly in HEAD. In particular:

Jun 4 2015, 2:31 AM · Wikimedia, Security, Localization, Mail
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T7047: Add user preference for diffs in emails, as Resolved.
Jun 4 2015, 2:31 AM · Restricted Project, Differential, Mail, Diffusion
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
Jun 4 2015, 2:31 AM · Spaces, Wikimedia, Policy
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T5791: Write Herald rules for outbound mail, as Resolved.
Jun 4 2015, 2:31 AM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley closed T8408: Test Bug as Resolved.

Can't find any problems.

Jun 4 2015, 2:24 AM · Unknown Object (Project)
epriestley added a project to T8408: Test Bug: Unknown Object (Project).
Jun 4 2015, 2:08 AM · Unknown Object (Project)
epriestley added a comment to T8408: Test Bug.

NOW I AM TESTING

Jun 4 2015, 2:07 AM · Unknown Object (Project)
epriestley added a comment to T8408: Test Bug.

I like testing.

Jun 4 2015, 2:05 AM · Unknown Object (Project)
epriestley created T8408: Test Bug.
Jun 4 2015, 2:05 AM · Unknown Object (Project)
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users as Resolved by committing Restricted Diffusion Commit.
Jun 4 2015, 1:43 AM · FreeBSD, Mailing Lists, Mail
epriestley closed T8387: Convert Mailing Lists into special users, similar to bot users, a subtask of T6367: Send email with recipient's language and access levels, not sender's, as Resolved.
Jun 4 2015, 1:43 AM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T8392: Enable Captcha on LDAP.
In T8392#118222, @chad wrote:

Why don't we fix the Recaptcha module to work on LDAP?

Jun 4 2015, 1:40 AM

Jun 3 2015

epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

You can also use "Return to Subscription" from an invoice/order directly, although it's in a sort of unusual place (upper right corner) that we don't use very often in other applications. My intent was to make it more visible, but maybe it's actually less visible.

Jun 3 2015, 11:59 PM · Phacility, Phortune
epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

You can get here via Billing > Subscriptions > Instance.

Jun 3 2015, 11:57 PM · Phacility, Phortune
epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

Some screenshots if that wasn't clear:

Jun 3 2015, 11:49 PM · Phacility, Phortune
epriestley added a comment to T8406: How do you change your payment method in Phortune? (Phacility case).

If you don't have automatic payment set up, choose a different payment method the next time you manually pay the invoice.

Jun 3 2015, 11:46 PM · Phacility, Phortune
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 3 2015, 9:24 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

As far as I can tell, we're missing these:

Jun 3 2015, 9:23 PM · Wikimedia, Security, Localization, Mail
epriestley added a comment to T6367: Send email with recipient's language and access levels, not sender's.

One thing I caught is that things which use Transactions now need to implement ApplicationTransactionInterface. At least one object (PhameBlog) does not. I'll check the rest of the codebase and see if there are any more.

Jun 3 2015, 9:13 PM · Wikimedia, Security, Localization, Mail
epriestley added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jun 3 2015, 9:03 PM · Wikimedia, Security, Localization, Mail
epriestley removed a reviewer for D13093: a new commit and test phabricator: Blessed Reviewers.
Jun 3 2015, 7:46 PM
epriestley updated the task description for T8398: Upgrading: Changes to Mailing Lists.
Jun 3 2015, 7:04 PM · Installing & Upgrading, People, Mail, Guides