Page MenuHomePhabricator
Feed Advanced Search

May 3 2015

joshuaspence created T8049: Improve parsing of variables embedded in strings in XHPAST.
May 3 2015, 11:38 PM · XHPAST
joshuaspence claimed T7453: Trigger notifications when a dependent differential is closed.
May 3 2015, 9:58 PM · Differential
joshuaspence claimed T7603: Remove the deprecated "Repositories" application.
May 3 2015, 9:51 PM · Repositories, Diffusion
joshuaspence claimed T7604: Remove "Arcanist Projects".
May 3 2015, 9:51 PM · Diffusion
joshuaspence claimed T7674: Remove support for arc commit hooks.
May 3 2015, 9:49 PM · Lint, Arcanist
joshuaspence claimed T8038: "Ref" syntax doesn't support "and".
May 3 2015, 9:41 PM · Transactions
joshuaspence claimed T8042: PhutilUnitTestEngine can't execute a single test path.
May 3 2015, 9:41 PM · Arcanist
joshuaspence added a revision to T8038: "Ref" syntax doesn't support "and": Unknown Object (Differential Revision).
May 3 2015, 9:29 PM · Transactions
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
May 3 2015, 7:57 AM · libphutil, Arcanist
joshuaspence added a revision to T7977: Associate Symbols with Repositories directly (Instead of arc projects): Unknown Object (Differential Revision).
May 3 2015, 7:50 AM · Symbols
joshuaspence added a revision to T7977: Associate Symbols with Repositories directly (Instead of arc projects): Unknown Object (Differential Revision).
May 3 2015, 7:37 AM · Symbols
joshuaspence added a revision to T7977: Associate Symbols with Repositories directly (Instead of arc projects): Unknown Object (Differential Revision).
May 3 2015, 7:32 AM · Symbols
joshuaspence added a revision to T7977: Associate Symbols with Repositories directly (Instead of arc projects): Unknown Object (Differential Revision).
May 3 2015, 7:22 AM · Symbols
joshuaspence added a revision to T7977: Associate Symbols with Repositories directly (Instead of arc projects): Unknown Object (Differential Revision).
May 3 2015, 7:00 AM · Symbols
joshuaspence added a revision to T7977: Associate Symbols with Repositories directly (Instead of arc projects): Unknown Object (Differential Revision).
May 3 2015, 3:45 AM · Symbols
joshuaspence closed T7220: Repository without Arcanist project fails for symbols import as Resolved by committing Restricted Diffusion Commit.
May 3 2015, 3:23 AM · Diffusion
joshuaspence updated the task description for T8043: Maybe interpret monograms that are provided as a URL.
May 3 2015, 1:07 AM · Remarkup
joshuaspence created T8043: Maybe interpret monograms that are provided as a URL.
May 3 2015, 12:03 AM · Remarkup

May 2 2015

joshuaspence created T8042: PhutilUnitTestEngine can't execute a single test path.
May 2 2015, 11:57 PM · Arcanist
joshuaspence created T8038: "Ref" syntax doesn't support "and".
May 2 2015, 7:26 AM · Transactions
joshuaspence added a comment to T1751: Consider ways to improve revert handling.

One possibility here is to reopen a Maniphest task if a "fixes" commit is reverted. I'm not sure whether this behavior is desirable.

May 2 2015, 5:01 AM · Restricted Project, Diffusion, Differential
joshuaspence added a revision to T1751: Consider ways to improve revert handling: Unknown Object (Differential Revision).
May 2 2015, 4:26 AM · Restricted Project, Diffusion, Differential

May 1 2015

joshuaspence merged task T6888: Extending revert edges into T1751: Consider ways to improve revert handling.
May 1 2015, 8:02 AM · Maniphest, Differential
joshuaspence merged T6888: Extending revert edges into T1751: Consider ways to improve revert handling.
May 1 2015, 8:02 AM · Restricted Project, Diffusion, Differential
joshuaspence created T8017: Maniphest Reports aren't mobile friendly.
May 1 2015, 7:52 AM · Mobile, Maniphest
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

There is no relevant "explain why" link because there is no transaction for someone added a commit: rPPfd5a74ad3fa1 on D19839 or someone added a differential revision: D19839 on rPPfd5a74ad3fa1.

May 1 2015, 12:04 AM · Differential, Diffusion

Apr 30 2015

joshuaspence created T8007: Commit was associated with unrelated diff.
Apr 30 2015, 11:34 PM · Differential, Diffusion
joshuaspence added a revision to T1751: Consider ways to improve revert handling: Unknown Object (Differential Revision).
Apr 30 2015, 9:56 PM · Restricted Project, Diffusion, Differential
joshuaspence added a revision to T6888: Extending revert edges: Unknown Object (Differential Revision).
Apr 30 2015, 9:56 PM · Maniphest, Differential
joshuaspence added a comment to T7447: Bring inline comments forward across revision updates.

I don't know @epriestley, I found it really confusing to have my comment on a different line entirely.

Apr 30 2015, 8:37 PM · Prioritized, Differential
joshuaspence added a revision to T2226: Include a setup test for gzip enabled on the server: Unknown Object (Differential Revision).
Apr 30 2015, 1:29 PM · Setup

Apr 29 2015

joshuaspence added a comment to T7993: PHUITagView icons wrap over newline.

Personally, I felt that (at least in the case of my screenshot) it would be better to push the entire tag to the second line.

Apr 29 2015, 10:18 PM · PHUI
joshuaspence added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

When I first read the title of this ticket, I thought that you were going to add gamification.

Apr 29 2015, 10:15 PM · Restricted Project, Badges (v0), People
joshuaspence awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Apr 29 2015, 10:12 PM · Restricted Project, Badges (v0), People
joshuaspence created T7993: PHUITagView icons wrap over newline.
Apr 29 2015, 10:11 PM · PHUI
joshuaspence added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Could badges be used for policies? For example, Blessed Committers could be replaced with a badge potentially. This would (at least partially) solve T5602.

Apr 29 2015, 10:09 PM · Restricted Project, Badges (v0), People
joshuaspence added a revision to T7220: Repository without Arcanist project fails for symbols import: Unknown Object (Differential Revision).
Apr 29 2015, 1:55 PM · Diffusion

Apr 28 2015

epriestley awarded T7444: Code block header styling a Orange Medal token.
Apr 28 2015, 5:30 PM · Design, Remarkup

Apr 27 2015

joshuaspence claimed T7892: Investigate lint performance issues.
Apr 27 2015, 11:14 AM · Lint
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Apr 27 2015, 10:57 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Apr 27 2015, 9:20 AM · libphutil, Arcanist

Apr 26 2015

joshuaspence created T7954: Make it easier to upload XHProf profiles.
Apr 26 2015, 10:12 PM · Infrastructure, XHProf

Apr 25 2015

joshuaspence added a comment to T7917: Better Duplicate Icon?.

#1 gets my vote.

Apr 25 2015, 7:30 AM · Maniphest

Apr 23 2015

joshuaspence added a comment to T7892: Investigate lint performance issues.

Here's an updated profile, this time from linting rP:

Apr 23 2015, 11:57 AM · Lint
joshuaspence added a revision to T7892: Investigate lint performance issues: Unknown Object (Differential Revision).
Apr 23 2015, 1:44 AM · Lint
joshuaspence added a revision to T7892: Investigate lint performance issues: Unknown Object (Differential Revision).
Apr 23 2015, 1:38 AM · Lint
joshuaspence added a revision to T7892: Investigate lint performance issues: Unknown Object (Differential Revision).
Apr 23 2015, 1:29 AM · Lint
joshuaspence added a comment to T7892: Investigate lint performance issues.

It looks like the most significant function is AASTNode::getTokens.

Apr 23 2015, 12:36 AM · Lint
joshuaspence added a comment to T7892: Investigate lint performance issues.

Here is a better profile (F379444), see https://secure.phabricator.com/xhprof/profile/PHID-FILE-k7tcfv6t7e7o3itxfwns/.

Apr 23 2015, 12:33 AM · Lint
joshuaspence created T7892: Investigate lint performance issues.
Apr 23 2015, 12:33 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 23 2015, 12:30 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 23 2015, 12:28 AM · Lint

Apr 22 2015

joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

Can you remind me why we lint by linter instead of by path? As in, we lint all paths for a given linter before moving to the next linter.

Apr 22 2015, 9:07 PM · Arcanist
joshuaspence closed T7880: Notifications are broken as Invalid.

This has magically fixed itself.

Apr 22 2015, 10:55 AM · Aphlict
joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

you sir, are awesome.

Apr 22 2015, 10:50 AM · Arcanist
joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

Would this task be available for paid prioritization?

Apr 22 2015, 3:25 AM · Arcanist
joshuaspence added a comment to T7880: Notifications are broken.

Weird, the notifications did come through on my phone.

Apr 22 2015, 2:46 AM · Aphlict
joshuaspence added a comment to T7880: Notifications are broken.

Do you have the durable chat column open?

Apr 22 2015, 2:18 AM · Aphlict
joshuaspence added a comment to T7880: Notifications are broken.

Hmm, looking in the network tab in Chrome and I can't actually see a websocket connection.

Apr 22 2015, 2:16 AM · Aphlict
joshuaspence added a comment to T7880: Notifications are broken.

Could be related to this?

Apr 22 2015, 2:15 AM · Aphlict
joshuaspence added a comment to T7880: Notifications are broken.

Actually, our firewall might be blocking port 22280... that's one of the reasons that I run Aphlict over port 443.

Apr 22 2015, 2:14 AM · Aphlict
joshuaspence added a comment to T7880: Notifications are broken.

Actually, our firewall might be blocking port 22280... that's one of the reasons that I run Aphlict over port 443.

Apr 22 2015, 2:14 AM · Aphlict
joshuaspence created T7881: Undefined variable when viewing diff.
Apr 22 2015, 2:08 AM · Differential
joshuaspence added a comment to T7880: Notifications are broken.
In T7880#108085, @chad wrote:

I have no idea what "this morning" means time wise in NZ to CA, haha

Apr 22 2015, 2:05 AM · Aphlict
joshuaspence created T7880: Notifications are broken.
Apr 22 2015, 1:13 AM · Aphlict

Apr 15 2015

joshuaspence added a comment to T7830: Differential highlighting highlights wrong lines when setup warning is ignored by lackadaisical admins.
In T7830#107243, @chad wrote:

Issues with Workboards and Conpherence were resolved earlier this week.

Apr 15 2015, 11:36 PM · Setup, Differential
joshuaspence added a comment to T7830: Differential highlighting highlights wrong lines when setup warning is ignored by lackadaisical admins.

I can't remember exactly what the issue was, but there's something funky with work boards and setup issues as well.

Apr 15 2015, 11:33 PM · Setup, Differential
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 15 2015, 1:28 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 15 2015, 1:25 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 15 2015, 10:37 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 15 2015, 10:33 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 15 2015, 8:52 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 15 2015, 8:34 AM · Lint

Apr 14 2015

joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 14 2015, 11:29 AM · Lint

Apr 13 2015

joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 13 2015, 12:53 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 13 2015, 11:24 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 13 2015, 10:50 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 13 2015, 10:44 AM · Lint
joshuaspence added a comment to T7739: Redesign Lint/Unit properties .

T7045 is maybe relevant here.

Apr 13 2015, 9:24 AM · Restricted Project, Harbormaster, Differential
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 13 2015, 8:06 AM · Lint

Apr 12 2015

joshuaspence placed T7478: Inbound email is wrapped when sent from Gmail up for grabs.

I really wish that we could fix this as it drives me insane to the point that I try not to send inbound emails to Phabricator. I don't, however, have any ideas on how to tackle this. Specifically, I don't see how we can differentiate automatic line breaks inserted by Gmail from intentional line breaks inserted by the user.

Apr 12 2015, 9:43 PM · Mail
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:37 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:34 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:23 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 12 2015, 9:20 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:19 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 12 2015, 9:07 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:06 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:03 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:02 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:08 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:05 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:04 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:03 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 12 2015, 12:59 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:56 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:53 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:09 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:08 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:06 PM · Lint