When selecting lines inside of a diff, it seems that the yellow box to indicate which rows are highlighted is off-by-one.
This is in Chrome 42.0.2311.82 beta (64-bit) on OS X 10.10.3.
mattrobenolt | |
Apr 15 2015, 6:19 PM |
F377083: pasted_file | |
Apr 20 2015, 5:44 PM |
F372344: pasted_file | |
Apr 15 2015, 6:40 PM |
F372331: pasted_file | |
Apr 15 2015, 6:19 PM |
When selecting lines inside of a diff, it seems that the yellow box to indicate which rows are highlighted is off-by-one.
This is in Chrome 42.0.2311.82 beta (64-bit) on OS X 10.10.3.
@chad, updated browser/OS in description, and no, I can't reproduce here. We last updated to master yesterday, then again this morning hoping it was resolved.
Generally, we don't support non stable browsers. Does it reproduce with normal Chrome?
Yeah, I've tested in every browser I have on my computer. Chrome, Firefox, and Safari. All the same issue.
Do you have any special settings for "monospaced font" https://secure.phabricator.com/settings/panel/display/ ?
It seems to be all diffs. But I can confirm later today if I find any that don't cause a problem.
Are you an administrator, with an "Unresolved Setup Issues..." banner showing on every page?
(This token is meant to go on epriestley's comment, but we can't do that yet either...)
Just a small and unnecessary rhetorical question here: do people really leave setup warnings & ignore them? I mean - i fix every setup warning the moment they appear and assumed same is true for everybody. I really wish that @chad's wish for airraid.wav would come true ;)
In fairness to the admins, we pushed a "deprecated Conduit methods called in the last 30 days" warning recently which often isn't easy to fix since you may have to chase people down or update things.
I can't remember exactly what the issue was, but there's something funky with work boards and setup issues as well.
This is exactly why we have the banner on our install. :) Normally, we don't have outstanding issues.
This has definitely fixed the issue, but introduced a new, much less annoying issue. :)
It seems to be that only on the Differential view, the little sidebar divider is now hovering over the banner.