If you have multiple bugs, please file them separately.

I did not change the PHP Code Sniffer release, I applied the patch proposed. But this is not the only one issue mentionned.

Updating PHP Code Sniffer makes the error go away, correct?

As far as i can see this can't work but is a bug in PHPCS. https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/CLI.php#L875
But i really don't understand why it works on your machine...

I think that this is already achievable with the ScriptAndRegexLinter. In addition, ArcanistXHPASTLinter also has this functionality (for PHP only). I feel that language specific linters would be better than just simply grep.

Yeah, in 5.6 this works.

richard @dev[~]
-> php -v
PHP 5.6.2-1 (cli) (built: Oct 17 2014 17:15:37) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans

Actually, this is perfectly fine in PHP 5.6 I believe.

Oh I didn't notice there's an existing ArcanistGoLintLinter. Thanks for pointing out. This is what I think missing:

• A linter that wraps go vet
• A linter that warps gofmt
• Add coverage support in ArcanistGoTestResultParser

What exactly are you looking for? There is an existing golang linter which wraps go lint.

Hi @chad, we're working on a a project using golang and phabricator. I can submit a diff to for those functionalities. Please let me know if it sounds good to you.

Closed by commit rARCb31e9c0cfee0.

Closed by commit rPHU9319f6d50d52.

+1

I'm inclined to maybe do away with it and just use new FutureIterator() explicitly everywhere? We don't really have that many callsites.

We should probably special case declare(), as declare(...); means something completely different from declare(...){}