In T6802#88402, @chad wrote:We don't have access to said task, feel free to reproduce here (or use screenshots).
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 23 2014
Dec 23 2014
epriestley added a revision to T6807: Edit Project page shows to logged in users but not logged out users despite public visibility: Restricted Differential Revision.
chad renamed T6807: Edit Project page shows to logged in users but not logged out users despite public visibility from "Edit project" page shows to logged in users but not logged out users despite public visibility to Edit Project page shows to logged in users but not logged out users despite public visibility.
Dec 20 2014
Dec 20 2014
also, could have similar differentiation in search results, workboards,
task lists on projects, feeds (i.e. side of front page), pages for
individual users with tasks changed by that user
Introducing pure red text in the header could be a useful first step, yes. We would need to think of a solution that doesn't conflict with other plans to put more emphasis in task resolutions i.e. T6500: Duplicated tasks should be marked more visibly as duplicates.
As a first pass, we could either go with something simple like text:
WikiChad added a comment to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Thanks for getting this so fast, we'll be sure to pull this into our next deployment.
Dec 19 2014
Dec 19 2014
btrahan closed T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer as Resolved.
Closed by commit rP8ac73b2bf351.
btrahan added a revision to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer: Restricted Differential Revision.
btrahan added a comment to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
I can only reproduce this by setting the Differential application to a restrictive policy such as administrators only. With default policy, uninstalling the Differential application does not reproduce this. Updated the task.
btrahan updated the task description for T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
btrahan claimed T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
I peeped the IRC log so I'll take a stab at this now.
Some other general thoughts:
chad renamed T6787: Clarify UI for Objects with a non-default Policy from Alternate style for custom policy objects to Clarify UI for Objects with a non-default Policy.
Ah, I missed that part. I do still think that "not default" is the right thing to cue -- for example, a more-open Almanac service in a field of admin-only-by-default services would be desirable to call out, rather than calling out the majority of services which have a tightly locked default.
In the description @qgil notes !public or !allusers, which is what I expect the default to be in most places. Though maybe "not default" is a more correct means of isolating changes.
Strictly as described, this would also leave 99% of tasks on 95% of installs red. I do think we could do a better job of surfacing cases where the policy deviates from the default policy, though, without being meaningless for the majority of users.
I think the core issue here is reasonable to solve, I'd probably want to resolve it consistently everywhere though (not just Maniphest). It also is likely important to solve at the comment box level as well, since people may not remember the object's policy before commenting.
chad renamed T6787: Clarify UI for Objects with a non-default Policy from Alternate style for non-public tasks to Alternate style for custom policy objects.
Dec 18 2014
Dec 18 2014
btrahan closed T5604: Properly integrate Maniphest with Subscribers, a subtask of T4411: Adding a CC to a Maniphest Task should give View rights for that user, as Resolved.
Dec 16 2014
Dec 16 2014
qgil moved T4411: Adding a CC to a Maniphest Task should give View rights for that user from Backlog to Important on the Wikimedia board.
qgil added a project to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Wikimedia.
Dec 15 2014
Dec 15 2014
qgil removed projects from T4830: Applications with Public permissions requiring users to login: Calendar, Applications, Wikimedia, Tokens, Audit.
Dec 13 2014
Dec 13 2014
chad added a comment to T6745: Default view policy isn't being followed for administrator drag-and-drop file uploads.
Wiki pages had been broken for a while. So if you haven't updated in the past month or maybe two there might have been a old issue you were seeing.
• e-m-albright closed T6745: Default view policy isn't being followed for administrator drag-and-drop file uploads as Invalid.
Ah, I'll have to double check on Monday when I can look again. My understanding from what you guys have said is even though the file I dropped onto the task's comment box says it's only visible to me, other users with access to that task can see it regardless?
Dec 11 2014
Dec 11 2014
btrahan reopened T5604: Properly integrate Maniphest with Subscribers, a subtask of T4411: Adding a CC to a Maniphest Task should give View rights for that user, as Open.
btrahan closed T5604: Properly integrate Maniphest with Subscribers, a subtask of T4411: Adding a CC to a Maniphest Task should give View rights for that user, as Resolved.
Dec 10 2014
Dec 10 2014
Dec 5 2014
Dec 5 2014
Thanks @chad! That's a sensible solution.
chad updated subscribers of T6463: Differential allows adding a reviewer who does not have access to it.
chad edited projects for T6697: Disallow adding reviewers who cannot view a revision, added: Differential, Policy; removed Diffusion.
Dec 4 2014
Dec 4 2014
qgil moved T6502: Policy to define who can move cards in a workboard from Backlog to Important on the Wikimedia board.
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
We'll allow namespace moves. The "global" namespace will just sort of be a default (and a namespace for existing objects to get put into when we build this), and not very special in other respects.
qgil added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
In T3820#50256, @epriestley wrote:
- A new namespace Interface defines object membership in a namespace. The policy filtering code acts on this immediately.
qgil updated the task description for T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Dec 2 2014
Dec 2 2014
• chasemp added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.
As usual, reasonable and clear. Thanks man.
epriestley added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.
@chasemp and I talked about this some more on IRC. We still don't have exactly the same viewpoint on where we should end up, but I think we can take an approach which everyone's onboard with for as long as possible and then possibly deviate a little at the end. Broadly, I want to implement the parts of this which would lock down or restrict capabilities first. Once we've implemented the heaviest set of restrictions, we can evaluate what holes we want to punch through them based on user feedback.
Nov 25 2014
Nov 25 2014
I think in the abstract locking down features because new users don't understand them sounds like the wrong solution to new users not understanding features. I also don't like to lock down features because of anticipated malicious use since the tools should be built first and foremost for good users, then bad users can be disabled and there is an audit trail for everything users do.
"Projects" as an app is likely one of our hardest to explain, and certainly onboarding would help. I'm just not sure there is any easy fix here. We've talked about renaming "Projects" as "Tags" which might help some with this specific issue.
In T6567#85161, @btrahan wrote:the users should educate themselves pretty quickly
Nov 24 2014
Nov 24 2014
I appreciate the context, which I'll summarize as "other tools have 1:1 mappings of projects to objects where the project dictates privacy."
Nov 21 2014
Nov 21 2014
In T6567#84997, @btrahan wrote:Do you know how come they have expectations that setting the policy on a project would later impact the policy of objects associated with the project?
A coarse solution is to create a project called "Users Who Can Prioritize Tasks", set that as the policy, and add anyone who should be able to edit priorities to that project.
chad closed T6564: Set default permissions for file uploads to same as File application as Resolved.
Closed by commit rP32b1ffdf894c.
Do you know how come they have expectations that setting the policy on a project would later impact the policy of objects associated with the project?
What about a policy to define who can edit the policy of projects?
chad added a revision to T6564: Set default permissions for file uploads to same as File application: Restricted Differential Revision.
chad added a revision to T6567: Add ability to set default Project Policy: Restricted Differential Revision.
Nov 19 2014
Nov 19 2014
Nov 15 2014
Nov 15 2014
Check out D7269
I presume if I could figure one out, I could do others.
T6564 is similar too, and could be resolved by introducing a default "Can View" for Files and using it on both the manual upload form and the drag-and-drop-onto-the-homepage flow.
ManiphestTask::initializeNewTask is an example of a Policy object that initializes the default policy relative to application settings. That's the tip of the iceberg as you'll need to make a few other changes; I think the method is a reasonable start but definitely ask more questions...!
@epriestley, is there an example implementation somewhere?
chad added a project to T6564: Set default permissions for file uploads to same as File application: Policy.
Nov 13 2014
Nov 13 2014
Nov 12 2014
Nov 12 2014
stevex added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Regarding UI: what about the possibility (not requirement) to assign a user a "default project" and a project a "default space" in order to have them "pre-compiled" when new entities are created by the user? (in big organizations often PM, users and developers belongs to one project only or work mainly for one at a time)
btrahan closed T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy as Resolved.
Closed by commit rP36c46d80f5a0.
epriestley added a comment to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
Ah, that makes sense.
btrahan added a revision to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy: Restricted Differential Revision.
btrahan added a comment to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
This repros at any new page, e.g. https://secure.phabricator.com/w/asdsadsadsadasd/
You may be able to implement this as an extension (subclass PhabricatorPolicyRule).
Nov 11 2014
Nov 11 2014
btrahan closed T6495: Phriction document titles are visible even if you can't see the document as Resolved.
Closed by commit rP9252d2a579e3.
Nov 10 2014
Nov 10 2014
Nov 9 2014
Nov 9 2014
btrahan added a revision to T6495: Phriction document titles are visible even if you can't see the document: Restricted Differential Revision.
btrahan closed T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/ as Resolved.
Closed by commit rP6f971a0fc4d8.
Nov 8 2014
Nov 8 2014
@epriestley, ok, that works too. You see, you wouldn't hire me as an engineer. :P
In T6502#83050, @chad wrote:I feel like 'Can Edit Workboard' should grant 'Can Edit Task'.
In T6502#83049, @qgil wrote:Is this summary correct, then?
When a user tries to move a card in a workboard...
I feel like 'Can Edit Workboard' should grant 'Can Edit Task'.
Is this summary correct, then?
Yep, exactly.
Oh Can Edit Workboard is a Project Policy, not a Maniphest Policy, correct?
(I think that would be a reasonable default, although the actual default-default would have to be "members of current project", which doesn't exist until T5681.)
Yeah, just set "Can Edit Workboard" to "Members of Project 'Security'".
Would there be any future path to ... say only Security can edit Security Workboard...
That said, I do think a separate permission is probably reasonable, but you'd need both ("Can Edit Workboard", "Can Edit Task") to drag.
Thinking on it a little more, I like it conceptually but think we can't get away with it:
Yeah, conceptually priority is also task management/planning like workboards and everything else is task definition.
Specifically, you'd lean toward requiring the separate policy only (you don't need to be able to edit the task, as long as you can edit the board)?
I'd lean towards separate policy. Editing a task is primarily changing the definition of a task, where Workboards are the planning/implementation of a Task.
It's supposed to be the "Can Edit" for the task, although that doesn't look like it's currently enforced (the UI sort of respects it, but not really).