Page MenuHomePhabricator
Feed Advanced Search

Dec 23 2014

epriestley added a revision to T6807: Edit Project page shows to logged in users but not logged out users despite public visibility: Restricted Differential Revision.
Dec 23 2014, 5:54 PM · Policy, Projects
chad renamed T6807: Edit Project page shows to logged in users but not logged out users despite public visibility from "Edit project" page shows to logged in users but not logged out users despite public visibility to Edit Project page shows to logged in users but not logged out users despite public visibility.
Dec 23 2014, 5:50 PM · Policy, Projects
Krenair added a comment to T6802: "Custom policy" for editing/viewing does not link to details.
In T6802#88402, @chad wrote:

We don't have access to said task, feel free to reproduce here (or use screenshots).

Dec 23 2014, 1:17 AM · Design, Policy
chad triaged T6802: "Custom policy" for editing/viewing does not link to details as Low priority.
Dec 23 2014, 1:10 AM · Design, Policy

Dec 20 2014

chad added a comment to T6787: Clarify UI for Objects with a non-default Policy.

We don't have any plans for that in vanilla Phabricator. T4863 covers customizing workboards, T418 covers customizing everything else. In general though T3820 is how we think installs should deal with mixed levels of permissions in a single install.

Dec 20 2014, 3:55 PM · Design, Policy, Wikimedia
jeremyb added a comment to T6787: Clarify UI for Objects with a non-default Policy.

also, could have similar differentiation in search results, workboards,
task lists on projects, feeds (i.e. side of front page), pages for
individual users with tasks changed by that user

Dec 20 2014, 1:45 PM · Design, Policy, Wikimedia
qgil added a comment to T6787: Clarify UI for Objects with a non-default Policy.

Introducing pure red text in the header could be a useful first step, yes. We would need to think of a solution that doesn't conflict with other plans to put more emphasis in task resolutions i.e. T6500: Duplicated tasks should be marked more visibly as duplicates.

Dec 20 2014, 1:38 PM · Design, Policy, Wikimedia
chad added a comment to T6787: Clarify UI for Objects with a non-default Policy.

As a first pass, we could either go with something simple like text:

Dec 20 2014, 4:59 AM · Design, Policy, Wikimedia
WikiChad added a comment to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

Thanks for getting this so fast, we'll be sure to pull this into our next deployment.

Dec 20 2014, 1:40 AM · Wikimedia, Differential, Diffusion, Support Impact, Policy

Dec 19 2014

btrahan closed T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer as Resolved.

Closed by commit rP8ac73b2bf351.

Dec 19 2014, 10:54 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan added a revision to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer: Restricted Differential Revision.
Dec 19 2014, 10:46 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan added a comment to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

I can only reproduce this by setting the Differential application to a restrictive policy such as administrators only. With default policy, uninstalling the Differential application does not reproduce this. Updated the task.

Dec 19 2014, 10:23 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan updated the task description for T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Dec 19 2014, 10:22 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan claimed T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

I peeped the IRC log so I'll take a stab at this now.

Dec 19 2014, 10:19 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
epriestley updated subscribers of T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Dec 19 2014, 7:28 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
epriestley created T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Dec 19 2014, 7:27 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
epriestley added a subtask for T6787: Clarify UI for Objects with a non-default Policy: T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Dec 19 2014, 5:33 PM · Design, Policy, Wikimedia
epriestley added a comment to T6787: Clarify UI for Objects with a non-default Policy.

Some other general thoughts:

Dec 19 2014, 5:32 PM · Design, Policy, Wikimedia
chad added a project to T6787: Clarify UI for Objects with a non-default Policy: Design.
Dec 19 2014, 5:30 PM · Design, Policy, Wikimedia
chad renamed T6787: Clarify UI for Objects with a non-default Policy from Alternate style for custom policy objects to Clarify UI for Objects with a non-default Policy.
Dec 19 2014, 5:27 PM · Design, Policy, Wikimedia
epriestley added a comment to T6787: Clarify UI for Objects with a non-default Policy.

Ah, I missed that part. I do still think that "not default" is the right thing to cue -- for example, a more-open Almanac service in a field of admin-only-by-default services would be desirable to call out, rather than calling out the majority of services which have a tightly locked default.

Dec 19 2014, 5:22 PM · Design, Policy, Wikimedia
chad added a comment to T6787: Clarify UI for Objects with a non-default Policy.

In the description @qgil notes !public or !allusers, which is what I expect the default to be in most places. Though maybe "not default" is a more correct means of isolating changes.

Dec 19 2014, 5:18 PM · Design, Policy, Wikimedia
epriestley added a comment to T6787: Clarify UI for Objects with a non-default Policy.

Strictly as described, this would also leave 99% of tasks on 95% of installs red. I do think we could do a better job of surfacing cases where the policy deviates from the default policy, though, without being meaningless for the majority of users.

Dec 19 2014, 5:16 PM · Design, Policy, Wikimedia
chad added a comment to T6787: Clarify UI for Objects with a non-default Policy.

I think the core issue here is reasonable to solve, I'd probably want to resolve it consistently everywhere though (not just Maniphest). It also is likely important to solve at the comment box level as well, since people may not remember the object's policy before commenting.

Dec 19 2014, 4:39 PM · Design, Policy, Wikimedia
chad renamed T6787: Clarify UI for Objects with a non-default Policy from Alternate style for non-public tasks to Alternate style for custom policy objects.
Dec 19 2014, 4:20 PM · Design, Policy, Wikimedia

Dec 18 2014

btrahan closed T5604: Properly integrate Maniphest with Subscribers, a subtask of T4411: Adding a CC to a Maniphest Task should give View rights for that user, as Resolved.
Dec 18 2014, 10:42 PM · Wikimedia, Policy

Dec 16 2014

qgil moved T4411: Adding a CC to a Maniphest Task should give View rights for that user from Backlog to Important on the Wikimedia board.
Dec 16 2014, 12:41 PM · Wikimedia, Policy
qgil added a project to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Wikimedia.
Dec 16 2014, 12:41 PM · Wikimedia, Policy

Dec 15 2014

qgil removed projects from T4830: Applications with Public permissions requiring users to login: Calendar, Applications, Wikimedia, Tokens, Audit.
Dec 15 2014, 11:01 PM · Facts, People, Policy

Dec 13 2014

chad added a comment to T6745: Default view policy isn't being followed for administrator drag-and-drop file uploads.

Wiki pages had been broken for a while. So if you haven't updated in the past month or maybe two there might have been a old issue you were seeing.

Dec 13 2014, 7:19 PM · Policy, Files
• e-m-albright closed T6745: Default view policy isn't being followed for administrator drag-and-drop file uploads as Invalid.

Ah, I'll have to double check on Monday when I can look again. My understanding from what you guys have said is even though the file I dropped onto the task's comment box says it's only visible to me, other users with access to that task can see it regardless?

Dec 13 2014, 7:14 PM · Policy, Files
chad added projects to T6745: Default view policy isn't being followed for administrator drag-and-drop file uploads: Files, Policy.
Dec 13 2014, 4:53 PM · Policy, Files

Dec 11 2014

btrahan reopened T5604: Properly integrate Maniphest with Subscribers, a subtask of T4411: Adding a CC to a Maniphest Task should give View rights for that user, as Open.
Dec 11 2014, 6:32 PM · Wikimedia, Policy
btrahan closed T5604: Properly integrate Maniphest with Subscribers, a subtask of T4411: Adding a CC to a Maniphest Task should give View rights for that user, as Resolved.
Dec 11 2014, 12:27 AM · Wikimedia, Policy

Dec 10 2014

epriestley created T6726: Files can recursively depend on one another, needing infinite policy checks.
Dec 10 2014, 7:36 PM · Files, Policy

Dec 5 2014

lfaraone added a comment to T6697: Disallow adding reviewers who cannot view a revision.

Thanks @chad! That's a sensible solution.

Dec 5 2014, 7:26 PM · Policy, Differential
chad updated subscribers of T6463: Differential allows adding a reviewer who does not have access to it.
Dec 5 2014, 6:23 AM · Policy, Differential
chad merged task T6697: Disallow adding reviewers who cannot view a revision into T6463: Differential allows adding a reviewer who does not have access to it.
Dec 5 2014, 6:23 AM · Policy, Differential
chad added projects to T6463: Differential allows adding a reviewer who does not have access to it: Differential, Policy.
Dec 5 2014, 6:23 AM · Policy, Differential
chad edited projects for T6697: Disallow adding reviewers who cannot view a revision, added: Differential, Policy; removed Diffusion.
Dec 5 2014, 6:20 AM · Policy, Differential

Dec 4 2014

qgil removed a project from T4850: Defining policies for "Project Members": Wikimedia.
Dec 4 2014, 1:00 PM · Restricted Project, Policy
qgil moved T6502: Policy to define who can move cards in a workboard from Backlog to Important on the Wikimedia board.
Dec 4 2014, 12:53 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

We'll allow namespace moves. The "global" namespace will just sort of be a default (and a namespace for existing objects to get put into when we build this), and not very special in other respects.

Dec 4 2014, 11:43 AM · Spaces, Policy, Wikimedia
qgil added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
  • A new namespace Interface defines object membership in a namespace. The policy filtering code acts on this immediately.
Dec 4 2014, 9:33 AM · Spaces, Policy, Wikimedia
qgil updated the task description for T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Dec 4 2014, 9:17 AM · Spaces, Policy, Wikimedia

Dec 2 2014

• chasemp added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

As usual, reasonable and clear. Thanks man.

Dec 2 2014, 10:16 PM · Wikimedia, Policy
epriestley added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

@chasemp and I talked about this some more on IRC. We still don't have exactly the same viewpoint on where we should end up, but I think we can take an approach which everyone's onboard with for as long as possible and then possibly deviate a little at the end. Broadly, I want to implement the parts of this which would lock down or restrict capabilities first. Once we've implemented the heaviest set of restrictions, we can evaluate what holes we want to punch through them based on user feedback.

Dec 2 2014, 7:43 PM · Wikimedia, Policy

Nov 25 2014

btrahan added a comment to T6567: Add ability to set default Project Policy.

I think in the abstract locking down features because new users don't understand them sounds like the wrong solution to new users not understanding features. I also don't like to lock down features because of anticipated malicious use since the tools should be built first and foremost for good users, then bad users can be disabled and there is an audit trail for everything users do.

Nov 25 2014, 9:30 PM · Policy, Projects
chad added a comment to T6567: Add ability to set default Project Policy.

"Projects" as an app is likely one of our hardest to explain, and certainly onboarding would help. I'm just not sure there is any easy fix here. We've talked about renaming "Projects" as "Tags" which might help some with this specific issue.

Nov 25 2014, 4:40 PM · Policy, Projects
qgil added a comment to T6567: Add ability to set default Project Policy.

the users should educate themselves pretty quickly

Nov 25 2014, 8:42 AM · Policy, Projects

Nov 24 2014

btrahan added a comment to T6567: Add ability to set default Project Policy.

I appreciate the context, which I'll summarize as "other tools have 1:1 mappings of projects to objects where the project dictates privacy."

Nov 24 2014, 5:26 PM · Policy, Projects

Nov 21 2014

qgil added a comment to T6567: Add ability to set default Project Policy.

Do you know how come they have expectations that setting the policy on a project would later impact the policy of objects associated with the project?

Nov 21 2014, 9:44 PM · Policy, Projects
chad added a comment to T4850: Defining policies for "Project Members".

A coarse solution is to create a project called "Users Who Can Prioritize Tasks", set that as the policy, and add anyone who should be able to edit priorities to that project.

Nov 21 2014, 7:39 PM · Restricted Project, Policy
chad closed T6564: Set default permissions for file uploads to same as File application as Resolved.
Nov 21 2014, 7:25 PM · Policy, Files, Wikimedia
chad closed T6567: Add ability to set default Project Policy as Resolved.

Closed by commit rP32b1ffdf894c.

Nov 21 2014, 7:22 PM · Policy, Projects
btrahan added a comment to T6567: Add ability to set default Project Policy.

Do you know how come they have expectations that setting the policy on a project would later impact the policy of objects associated with the project?

Nov 21 2014, 5:20 PM · Policy, Projects
qgil added a comment to T6567: Add ability to set default Project Policy.

What about a policy to define who can edit the policy of projects?

Nov 21 2014, 7:32 AM · Policy, Projects
chad added a revision to T6564: Set default permissions for file uploads to same as File application: Restricted Differential Revision.
Nov 21 2014, 5:17 AM · Policy, Files, Wikimedia
chad added a revision to T6567: Add ability to set default Project Policy: Restricted Differential Revision.
Nov 21 2014, 5:07 AM · Policy, Projects

Nov 19 2014

qgil added a subtask for T4830: Applications with Public permissions requiring users to login: T6594: Logged-out users can not access "View Raw" in comment dropdown menus.
Nov 19 2014, 9:11 PM · Facts, People, Policy

Nov 15 2014

btrahan added a comment to T6567: Add ability to set default Project Policy.

Check out D7269

Nov 15 2014, 6:22 PM · Policy, Projects
chad added a comment to T6567: Add ability to set default Project Policy.

I presume if I could figure one out, I could do others.

Nov 15 2014, 5:49 PM · Policy, Projects
epriestley added a comment to T6567: Add ability to set default Project Policy.

T6564 is similar too, and could be resolved by introducing a default "Can View" for Files and using it on both the manual upload form and the drag-and-drop-onto-the-homepage flow.

Nov 15 2014, 5:46 PM · Policy, Projects
btrahan added a comment to T6567: Add ability to set default Project Policy.

ManiphestTask::initializeNewTask is an example of a Policy object that initializes the default policy relative to application settings. That's the tip of the iceberg as you'll need to make a few other changes; I think the method is a reasonable start but definitely ask more questions...!

Nov 15 2014, 5:42 PM · Policy, Projects
chad updated subscribers of T6567: Add ability to set default Project Policy.

@epriestley, is there an example implementation somewhere?

Nov 15 2014, 5:31 PM · Policy, Projects
chad created T6567: Add ability to set default Project Policy.
Nov 15 2014, 5:19 PM · Policy, Projects
chad added a project to T6564: Set default permissions for file uploads to same as File application: Policy.
Nov 15 2014, 5:41 AM · Policy, Files, Wikimedia

Nov 13 2014

chad triaged T6524: Support "request is from IP / subnet" policy rule as Wishlist priority.
Nov 13 2014, 5:34 PM · Policy

Nov 12 2014

stevex added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Regarding UI: what about the possibility (not requirement) to assign a user a "default project" and a project a "default space" in order to have them "pre-compiled" when new entities are created by the user? (in big organizations often PM, users and developers belongs to one project only or work mainly for one at a time)

Nov 12 2014, 7:53 AM · Spaces, Policy, Wikimedia
btrahan closed T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy as Resolved.

Closed by commit rP36c46d80f5a0.

Nov 12 2014, 2:16 AM · Policy, Phriction
epriestley added a comment to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.

Ah, that makes sense.

Nov 12 2014, 2:15 AM · Policy, Phriction
btrahan added a revision to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy: Restricted Differential Revision.
Nov 12 2014, 2:15 AM · Policy, Phriction
btrahan added a comment to T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.

This repros at any new page, e.g. https://secure.phabricator.com/w/asdsadsadsadasd/

Nov 12 2014, 2:14 AM · Policy, Phriction
btrahan claimed T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
Nov 12 2014, 2:06 AM · Policy, Phriction
epriestley created T6527: On a totally empty Phriction wiki, default page shows "Unknown Object (????)" as policy.
Nov 12 2014, 1:51 AM · Policy, Phriction
chad placed T6524: Support "request is from IP / subnet" policy rule up for grabs.
Nov 12 2014, 1:41 AM · Policy
epriestley added a comment to T6524: Support "request is from IP / subnet" policy rule.

You may be able to implement this as an extension (subclass PhabricatorPolicyRule).

Nov 12 2014, 12:58 AM · Policy
hach-que created T6524: Support "request is from IP / subnet" policy rule.
Nov 12 2014, 12:53 AM · Policy

Nov 11 2014

btrahan closed T6495: Phriction document titles are visible even if you can't see the document as Resolved.

Closed by commit rP9252d2a579e3.

Nov 11 2014, 9:18 PM · Policy, Phriction

Nov 10 2014

chad triaged T6502: Policy to define who can move cards in a workboard as Normal priority.
Nov 10 2014, 4:31 AM · Projects, Wikimedia, Policy, Workboards

Nov 9 2014

btrahan added a revision to T6495: Phriction document titles are visible even if you can't see the document: Restricted Differential Revision.
Nov 9 2014, 2:41 AM · Policy, Phriction
btrahan closed T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/ as Resolved.

Closed by commit rP6f971a0fc4d8.

Nov 9 2014, 2:12 AM · Policy, Phriction

Nov 8 2014

qgil added a comment to T6502: Policy to define who can move cards in a workboard.

@epriestley, ok, that works too. You see, you wouldn't hire me as an engineer. :P

Nov 8 2014, 7:42 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.
In T6502#83050, @chad wrote:

I feel like 'Can Edit Workboard' should grant 'Can Edit Task'.

Nov 8 2014, 7:40 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.
In T6502#83049, @qgil wrote:

Is this summary correct, then?

When a user tries to move a card in a workboard...

Nov 8 2014, 7:38 PM · Projects, Wikimedia, Policy, Workboards
chad added a comment to T6502: Policy to define who can move cards in a workboard.

I feel like 'Can Edit Workboard' should grant 'Can Edit Task'.

Nov 8 2014, 7:28 PM · Projects, Wikimedia, Policy, Workboards
qgil added a comment to T6502: Policy to define who can move cards in a workboard.

Is this summary correct, then?

Nov 8 2014, 7:26 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Yep, exactly.

Nov 8 2014, 4:15 PM · Projects, Wikimedia, Policy, Workboards
chad added a comment to T6502: Policy to define who can move cards in a workboard.

Oh Can Edit Workboard is a Project Policy, not a Maniphest Policy, correct?

Nov 8 2014, 4:14 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

(I think that would be a reasonable default, although the actual default-default would have to be "members of current project", which doesn't exist until T5681.)

Nov 8 2014, 4:11 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Yeah, just set "Can Edit Workboard" to "Members of Project 'Security'".

Nov 8 2014, 4:10 PM · Projects, Wikimedia, Policy, Workboards
chad added a comment to T6502: Policy to define who can move cards in a workboard.

Would there be any future path to ... say only Security can edit Security Workboard...

Nov 8 2014, 3:59 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

That said, I do think a separate permission is probably reasonable, but you'd need both ("Can Edit Workboard", "Can Edit Task") to drag.

Nov 8 2014, 3:56 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Thinking on it a little more, I like it conceptually but think we can't get away with it:

Nov 8 2014, 3:54 PM · Projects, Wikimedia, Policy, Workboards
chad added a comment to T6502: Policy to define who can move cards in a workboard.

Yeah, conceptually priority is also task management/planning like workboards and everything else is task definition.

Nov 8 2014, 3:53 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Specifically, you'd lean toward requiring the separate policy only (you don't need to be able to edit the task, as long as you can edit the board)?

Nov 8 2014, 3:51 PM · Projects, Wikimedia, Policy, Workboards
chad added a comment to T6502: Policy to define who can move cards in a workboard.

I'd lean towards separate policy. Editing a task is primarily changing the definition of a task, where Workboards are the planning/implementation of a Task.

Nov 8 2014, 3:48 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

It's supposed to be the "Can Edit" for the task, although that doesn't look like it's currently enforced (the UI sort of respects it, but not really).

Nov 8 2014, 3:26 PM · Projects, Wikimedia, Policy, Workboards
qgil updated the task description for T6502: Policy to define who can move cards in a workboard.
Nov 8 2014, 3:20 PM · Projects, Wikimedia, Policy, Workboards
qgil updated the task description for T6502: Policy to define who can move cards in a workboard.
Nov 8 2014, 3:18 PM · Projects, Wikimedia, Policy, Workboards