Page MenuHomePhabricator
Create Task
Maniphest T6697

Disallow adding reviewers who cannot view a revision
Closed, DuplicatePublic
Actions

Description

Currently, I can be added as a reviewer/subscriber to a revision despite not having visibility on that revision, either due to repository restrictions or object-specific restrictions.

Related Objects

Event Timeline

lfaraone created this task.Dec 5 2014, 5:15 AM
lfaraone raised the priority of this task from to Needs Triage.
lfaraone updated the task description. (Show Details)
lfaraone added a project: Diffusion.
lfaraone added subscribers: lfaraone, jesseendahl.
chad added a subscriber: chad.Dec 5 2014, 6:19 AM

I don't believe we plan to pursue this. T4411 explains a bit how we're approaching this in Maniphest.

chad edited projects, added Differential, Policy; removed Diffusion.Dec 5 2014, 6:20 AM
chad closed this task as a duplicate of T6463: Differential allows adding a reviewer who does not have access to it.Dec 5 2014, 6:23 AM
lfaraone added a comment.Dec 5 2014, 7:26 PM

Thanks @chad! That's a sensible solution.

lfaraone awarded a token.Dec 5 2014, 7:27 PM
Phabricator · Built by Phacility