word

This is mostly a product question so maybe @chad has some input on expectations / reasonableness.

I'm done-ish for today but I figure I should slap this on the ole queue.

This should now (post rP3fa8b152b635) work.

Well, the link between projects and wiki pages is now severed.

Closed by commit rPc8d20d3c66f2.

I suspect this is resolved after T4029 etc? Or at least not the same as it used to be.

@btrahan, I think this is covered now?

Closed by commit rP6db25aa41c9d.

phriction.history and phriction.edit should probably wait on T5873 to make sure they end up looking like whatever all the other modern transaction-aware endpoints look like. And maybe phriction.create too. We could create phriction.query now fairly safely, although some discussion in T5873.

It worked, thanks.

It worked, thanks.

Closed by commit rPe58259b4f52b.

after you update one more delete will make things work as expected. Thanks for the report.

Closed by commit rP677e161865a4.

• D10756 added mailKey.
  • But does not retroactively assign mail keys.
  • After adjustment, the column type is bytes20, which will fill with "\0\0\0\0..." if not filled.
  • That's not valid BMP utf8.
  • D10756 added it as varchar(20) (equivalent to text20, not bytes20) so no issue. It was still incorrect, but not as problematic.

And these mailKeys cause document save exception, how so?

Ah, this is D10756.

Maybe storage adjust was changing collation of columns without actually converting content inside them to use that new collation?

I've just verified that all existing documents before storage adjust are not editable, even if I just have "test" word in them. I can create new and edit these new documents without issues.

I create page some time ago. Then made storage adjustments recently and tried to edit page content and got that error. In fact if I even add one word at the end I'm getting that error.

(I can reproduce by reverting D10798 and trying to edit the page to include emoji, as expected.)

I'm not sure what's causing the issue, but also can't reproduce it by reverting D10798 locally:

Ah, now I get it after reading description of D10798. I shouldn't have executed storage adjustments, because that resulted in that exception in first place.

Is there anything wrong in the content I'm trying to save? I've executed all storage adjustments, so I shouldn't be getting this error at all.

This will be fixed by D10798, which is waiting for D10800.

I think once the task is marked "resolved" you can expect this functionality to work and its potentially most expedient to just hang out until then. In the interim, there's a mountain of technical debt I am taking out, plus related features... Here's my current list

Nothing is usable yet.

I'm unclear on whether or not any of the recent changes are usable right now. Is there any way to actually limit access by project right now? It would be helpful if the task description was updated with a checklist of things that are (not) supported.

Definitely kick wiki weirdness my way; whether I broke it like in this case with my recent changes or its been an outstanding issue its time to fix this jonx.

Closed by commit rP0bf0449aaa7c.

Thanks @chad !

Replacing Project Pages with a customizable Dashboard seems like it'd solve most of these cases, at least.

Generally speaking, Phriction isn't our Product Management app. Workboards are, and maybe Dashboards to some other extent. We'd rather improve these to cover use cases that fit maybe how your company works, rather than pursue edge case use in Remarkup or Phriction. We have a lot planned around Workboards, and it is one of products we really want to have cover a lot of cases. Please take a look at Workboards and see what already is planned, and if something you'd think would benefit many Phabricator users is missing, feel free to file.

Oh at the end of a sentence about Security.

We don't apply Remarkup to headers/titles, if that's what you're referring to.

Just replicated that one on the test page :)

You know what it was? I wrote "#project." since it was at the end of a sentence. I'm not sure if that's a parser bug for the tags or just intended behavior.

@chad what about being able to add filters for tasks and the like in dashboards so you can put tasks for project x on the wiki page for the same project without having all of your other projects, etc, showing? Is there any chance that something like that will be implemented?

I can't reproduce this: https://secure.phabricator.com/w/test_page/

You can already build a custom query as a Dashboard and embed it in Remarkup. As far as providing additional 'views', we're not pursuing any at this time.

I actually came here to suggest practically the same thing. I like what @adinnaplus is saying, custom queries for dashboards / workboards would be absolutely amazing.

Short answer is Phriction pre-dates Policies, and when modernized will get this stuff on the cheap.

Can i bump and add a thing ?

• this mode should be visible in a new button full screen + preview because if we go in the full screen edit it's for long edit

same here, this option would be quite useful.
Two independent scrollable views. one to write and one for preview.
This can be placed side by side in the white space when you comment task, create it or in Phriction pages.

Created pull request: https://github.com/phacility/phabricator/pull/734

Sorry, came up with better search terms and found the canonical issue.