Page MenuHomePhabricator

Project hashtags don't link when followed by a period
Closed, ResolvedPublic

Description

Today if you write a hashtag project link in Phriction then it appears as nothing more than a normal hashtag, but it should be a link/reference to the project being referred to.

Project hashtag links don't work if they're followed by a period, e.g. Remarkup versus Remarkup.

Phabricator Version: 1120c465e480f503686ab503e2cf1e1f1b6cf16d

Event Timeline

tel raised the priority of this task from to Needs Triage.
tel updated the task description. (Show Details)
tel added a project: Phriction.
tel added a subscriber: tel.
chad claimed this task.

You know what it was? I wrote "#project." since it was at the end of a sentence. I'm not sure if that's a parser bug for the tags or just intended behavior.

I personally found it a little strange.

Just replicated that one on the test page :)

We don't apply Remarkup to headers/titles, if that's what you're referring to.

Oh at the end of a sentence about Security.

chad renamed this task from Project reference links should work in #phriction to Project hashtags don't link when followed by a period.Oct 28 2014, 11:38 PM
chad reopened this task as Open.
chad removed chad as the assignee of this task.
chad triaged this task as Normal priority.
chad edited projects, added Remarkup; removed Phriction.

Nope, Yup: this is what I mean

(Just saw @chad's newest comment)

Projects

Design Workboards Security.

tel added a project: Security.
tel updated the task description. (Show Details)
tel removed a project: Security.

See D8703 for previous work. We currently assume that #security. is a slug named security. (with a period), and allow this as a side effect of allowing slugs like #blog.phacility.com, which seems reasonable (e.g., allowing project names to be domain names or domain-like strings).

Consuming the period when it isn't followed by anything seems worse than treating it as punctuation, though -- that is, we should consume security.com from #security.com, but only security from #security.