Page MenuHomePhabricator
Feed Advanced Search

Oct 3 2014

chad added a comment to T4330: Associate Git commit to Maniphest task.

The arcanist workflow is actually pretty awesome, but yes it's a bit of a switch if it's new to you. The Maniphest integration from reading the docs looks like it only works with Revisions, and not Commits. I don't think we've have plans to add it to Commits, though it's likely possible at some point (not much/any interest has been seen).

Oct 3 2014, 10:14 PM · Maniphest, Diffusion
tgrosinger added a comment to T4330: Associate Git commit to Maniphest task.

I am not using differential right now (but will be in the future. Just testing things one at a time right now). I was hoping the links could be added just from a revision committed in Diffusion. Are they only added if you use Differential?

Oct 3 2014, 10:04 PM · Maniphest, Diffusion
tgrosinger added a comment to T4330: Associate Git commit to Maniphest task.

Unfortunately no. Is there something I need to enable to add this functionality?

Oct 3 2014, 10:03 PM · Maniphest, Diffusion
chad added a comment to T4330: Associate Git commit to Maniphest task.

Oh, sorry, I think I'm misunderstanding you. These links are established during code review (Differential), not Audit. Are you using a pre-commit workflow (Arcanist)?

Oct 3 2014, 10:03 PM · Maniphest, Diffusion
chad added a comment to T4330: Associate Git commit to Maniphest task.

Yes, and nothing appears on T7 for you?

Oct 3 2014, 9:59 PM · Maniphest, Diffusion
tgrosinger added a comment to T4330: Associate Git commit to Maniphest task.

I have tried a few different methods, and tried to model if after example commits found in this Phabricator instance that look like they worked. Is this what you meant by putting it in the summary section?

Oct 3 2014, 9:57 PM · Maniphest, Diffusion
chad added a comment to T4330: Associate Git commit to Maniphest task.

@tgrosinger our handy guide is here: T5132: Document the special syntax you can use in commit messages to cause effects (Sounds like you're not putting them in the Summary?)

Oct 3 2014, 9:47 PM · Maniphest, Diffusion
tgrosinger added a comment to T4330: Associate Git commit to Maniphest task.

I am getting links from Diffusion to the task (in the commit message, the T123 will be a link), but the link is never showing up in Maniphest. Any suggestions for troubleshooting? I am using "Closes T123" as the second line in the commit message. I have also tried with "Maniphest Tasks" and "Fixes"

Oct 3 2014, 9:18 PM · Maniphest, Diffusion
fabe added a revision to T2453: Populate the blame cache when parsing commits: Restricted Differential Revision.
Oct 3 2014, 5:49 PM · OS Students 2013, Diffusion
flashydave added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

The same problem exists in git and I have the same issue over acceptability of my users who happen to be familiar with ReviewBoard.

Oct 3 2014, 1:36 PM · KDE, Restricted Project, Diffusion, Differential
epriestley added a project to T4151: Cleanup and errata for repository hosting: Support Impact.

Support Impact The remaining stuff is pretty hard to use.

Oct 3 2014, 4:22 AM · Support Impact, Diffusion
epriestley added a project to T4801: Error with unclear next steps from `git push` to hosted repository: Support Impact.

Support Impact Substantial effect and unclear next steps.

Oct 3 2014, 4:17 AM · Git, Diffusion
epriestley added a project to T4946: Git checks for missing origin in 1.7.1 happen too late in the update process: Support Impact.

Support Impact This has cropped up a number of times and is surprising and broken.

Oct 3 2014, 4:15 AM · Support Impact, Diffusion, Repositories
epriestley closed T5538: Broken commit attachment as Resolved.

Presuming resolved.

Oct 3 2014, 4:02 AM · Diffusion
epriestley added a project to T6107: "Reply to inline comment" shortcut broken in Diffusion: Support Impact.

Support Impact This is broken.

Oct 3 2014, 3:40 AM · Support Impact, Diffusion

Oct 2 2014

epriestley closed T6119: Destroying a repository exceeds MySQL lock limits as Resolved.

Closed by commit rP0ddb1875087b.

Oct 2 2014, 9:44 PM · Diffusion
epriestley added a revision to T6119: Destroying a repository exceeds MySQL lock limits: Restricted Differential Revision.
Oct 2 2014, 8:26 PM · Diffusion
epriestley added a comment to T6119: Destroying a repository exceeds MySQL lock limits.

From what I can tell, the easiest way to resolve this is to increase innodb_buffer_pool_size. Generally, increasing innodb_buffer_pool_size is desirable anyway, because it will tend to improve performance overall.

Oct 2 2014, 7:58 PM · Diffusion
epriestley closed T6196: No Syntax Highlighting in Git Blame View as Wontfix.

Sorry, I can't reproduce this on this install or locally. Closing per https://secure.phabricator.com/book/phabricator/article/feedback/#unreproducible-problems

Oct 2 2014, 7:43 PM · Diffusion

Oct 1 2014

epriestley created T6221: "Fixes" should work in comment text on revisions, not just summary text.
Oct 1 2014, 3:37 PM · Diffusion, Daemons

Sep 30 2014

chad closed T6208: External bug-tracker not work as Invalid.
Sep 30 2014, 6:10 PM · Diffusion
chad removed a subtask for T6208: External bug-tracker not work: T6212: Diff on localized Windows produces unparsable diffs (newline information localization).
Sep 30 2014, 6:10 PM · Diffusion
• aish_chopra reopened T6208: External bug-tracker not work as "Open".
Sep 30 2014, 6:04 PM · Diffusion
• aish_chopra added a subtask for T6208: External bug-tracker not work: T6212: Diff on localized Windows produces unparsable diffs (newline information localization).
Sep 30 2014, 6:03 PM · Diffusion
• peapon updated subscribers of T6208: External bug-tracker not work.

@hach-que is correct. We do not interact directly with Bugzilla, and do not have any plans to build integrations in the near term.

I got, THS.

Sep 30 2014, 2:40 PM · Diffusion
epriestley closed T6208: External bug-tracker not work as Resolved.

@hach-que is correct. We do not interact directly with Bugzilla, and do not have any plans to build integrations in the near term.

Sep 30 2014, 11:49 AM · Diffusion
hach-que added a comment to T6208: External bug-tracker not work.

As far as I can tell, all this feature does is cause bug IDs like "ABC-123" in a commit message to be turned into links. It's not integration with an external bug tracker.

Sep 30 2014, 3:55 AM · Diffusion
• peapon updated the task description for T6208: External bug-tracker not work.
Sep 30 2014, 3:42 AM · Diffusion
• peapon created T6208: External bug-tracker not work.
Sep 30 2014, 3:42 AM · Diffusion

Sep 29 2014

timor added a comment to T6196: No Syntax Highlighting in Git Blame View.

Not reproducing here. When reproducing on our install, what happens is

Sep 29 2014, 11:06 AM · Diffusion

Sep 28 2014

fabe added a revision to T2450: Build a blame cache: Restricted Differential Revision.
Sep 28 2014, 3:59 PM · Diffusion
fabe added a comment to T2450: Build a blame cache.

Had some free time today and implemented this. The improvement however is not as big as i expected.
Doing a blame on phabricators __phutil_library_map__.php will take ~20sec without and ~15sec with the cache on my dev vm.

Sep 28 2014, 3:58 PM · Diffusion

Sep 26 2014

chad added a comment to T6196: No Syntax Highlighting in Git Blame View.

I'm sorry, I'm not able to reproduce this on this install. Does it reproduce here for you? Can you provide a list of steps to reproduce? What pygments are you running?

Sep 26 2014, 2:20 PM · Diffusion
timor added a comment to T6196: No Syntax Highlighting in Git Blame View.

Yes, turning off Blame, the syntax highlighting works again immediately.

Sep 26 2014, 2:10 PM · Diffusion
chad added a comment to T6196: No Syntax Highlighting in Git Blame View.

Do you have it pygments enabled/installed? https://secure.phabricator.com/book/phabricator/article/differential_faq/#how-can-i-enable-syntax

Sep 26 2014, 1:59 PM · Diffusion
timor updated the task description for T6196: No Syntax Highlighting in Git Blame View.
Sep 26 2014, 1:08 PM · Diffusion
timor created T6196: No Syntax Highlighting in Git Blame View.
Sep 26 2014, 1:08 PM · Diffusion

Sep 24 2014

epriestley closed T6171: Transaction abort on first push via SSH to empty Mercurial repository as Invalid.

I can't reproduce this and it sounds like you can't either.

Sep 24 2014, 8:43 PM · Mercurial, Diffusion
epriestley added a project to T6160: Don't show closed branches of mercurial repository: Mercurial.
Sep 24 2014, 8:36 PM · Mercurial, Diffusion
devurandom added a comment to T6171: Transaction abort on first push via SSH to empty Mercurial repository.

Today I updated phabricator with 212b0d2..8ebe9ce, and tried again and suddenly it is no longer reproducible…

Sep 24 2014, 5:10 PM · Mercurial, Diffusion
chad added projects to T6171: Transaction abort on first push via SSH to empty Mercurial repository: Diffusion, Mercurial.
Sep 24 2014, 4:29 PM · Mercurial, Diffusion

Sep 23 2014

epriestley updated subscribers of T5029: Fill in missing context for low-context diffs against tracked repositories.
Sep 23 2014, 1:07 PM · KDE, Restricted Project, Diffusion, Differential

Sep 22 2014

altendky added a comment to T4255: SVN property changes on directories not shown in Diffusion diff views?.

@davisoa I've been running each revision of D8478 since I put it in. Admittedly with only internal use by three people but I haven't been noticing any issues.

Sep 22 2014, 4:02 PM · Subversion, Diffusion
PhoneixS created T6160: Don't show closed branches of mercurial repository.
Sep 22 2014, 3:36 PM · Mercurial, Diffusion

Sep 19 2014

aik099 added a comment to T5886: Commit imported into wrong repository (as duplicate).

The http://qa.in-portal.org/rSIM16064 should be http://qa.in-portal.org/rTSIM16064 in previous comment.

Sep 19 2014, 9:00 AM · Diffusion
aik099 added a comment to T5886: Commit imported into wrong repository (as duplicate).

This continues to happen. For example:

Sep 19 2014, 8:59 AM · Diffusion

Sep 18 2014

epriestley closed T6127: Viewing file in editor doesn't work due wrong path as Wontfix.

iiam

Sep 18 2014, 8:14 PM · Audit, Diffusion
aik099 added a comment to T6127: Viewing file in editor doesn't work due wrong path.

If you have View in Editor functionality, then I suppose it worked at some point. I wonder how it was used knowing all problems that I've experienced with it.

Sep 18 2014, 8:11 PM · Audit, Diffusion
epriestley added a comment to T6127: Viewing file in editor doesn't work due wrong path.

We don't plan to support that.

Sep 18 2014, 8:10 PM · Audit, Diffusion
aik099 added a comment to T6127: Viewing file in editor doesn't work due wrong path.

You recommend that I create symlinks on my machine and name them like path in SVN repository? Won't it be easier to have per user setting, like editor url, where I specify from=>to replacements pairs to be applied to repository file path before giving it to %f in editor url.

Sep 18 2014, 8:05 PM · Audit, Diffusion
bluehawk created T6131: Mirror Status on repository edit view.
Sep 18 2014, 4:31 PM · Diffusion
epriestley added a comment to T6127: Viewing file in editor doesn't work due wrong path.

You can use a path like /path/to/editor_symlinks/%r, then symlink working copies using callsigns.

Sep 18 2014, 3:57 PM · Audit, Diffusion
aik099 updated the task description for T6127: Viewing file in editor doesn't work due wrong path.
Sep 18 2014, 3:42 PM · Audit, Diffusion
aik099 created T6127: Viewing file in editor doesn't work due wrong path.
Sep 18 2014, 3:41 PM · Audit, Diffusion
epriestley closed T6106: Unable to Open in External Editor when using custom protocols as Resolved.

Closed by commit rPHU6c29d5c8d169.

Sep 18 2014, 3:25 PM · Audit, Diffusion
epriestley added a revision to T6106: Unable to Open in External Editor when using custom protocols: Restricted Differential Revision.
Sep 18 2014, 3:16 PM · Audit, Diffusion
epriestley added a comment to T6106: Unable to Open in External Editor when using custom protocols.

See T5031.

Sep 18 2014, 3:10 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Also the comment textarea in Manifest doesn't clear when I hit Submit button.

Sep 18 2014, 3:07 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Usually host goes till the first ? or if that's missing till the end of the string.

Sep 18 2014, 3:06 PM · Audit, Diffusion
epriestley added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Specifically, this is a combination of parse_url() getting these URLs wrong, and then filtering we apply. Here's what parse_url() gets wrong:

Sep 18 2014, 3:02 PM · Audit, Diffusion
n008sch00l8us added a comment to T6118: Support for Mercurial extensions in hosted repositories.

Thanks Evan, the LockExtension has worked as desired for us using the fix suggested above. It would be great to have inbuilt support in the future for these.

Sep 18 2014, 8:50 AM · Mercurial, Diffusion
epriestley created T6119: Destroying a repository exceeds MySQL lock limits.
Sep 18 2014, 1:07 AM · Diffusion
epriestley updated subscribers of T6118: Support for Mercurial extensions in hosted repositories.
Sep 18 2014, 12:51 AM · Mercurial, Diffusion
epriestley merged task T5189: Can't push to a Mercurial repository hosted by Phabricator when the Lagrefiles extension is on. into T6118: Support for Mercurial extensions in hosted repositories.
Sep 18 2014, 12:51 AM · Diffusion
epriestley created T6118: Support for Mercurial extensions in hosted repositories.
Sep 18 2014, 12:51 AM · Mercurial, Diffusion

Sep 17 2014

chad removed a project from T2183: unify "table of contents" views between Differential and Diffusion: Design.
Sep 17 2014, 8:30 PM · Owners, Differential, Diffusion

Sep 16 2014

aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

I see.

Sep 16 2014, 6:36 PM · Audit, Diffusion
epriestley added a comment to T6106: Unable to Open in External Editor when using custom protocols.

We perform filtering after calling parse_url() to deal with cases it doesn't handle. This filtering gets these cases wrong.

Sep 16 2014, 5:47 PM · Audit, Diffusion
staticshock created T6107: "Reply to inline comment" shortcut broken in Diffusion.
Sep 16 2014, 5:46 PM · Support Impact, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Isn't parse_url function (http://php.net/manual/en/function.parse-url.php) used to parse url to determine protocol? I thought it handle that stuff without problems.

Sep 16 2014, 4:27 PM · Audit, Diffusion
epriestley added a comment to T6106: Unable to Open in External Editor when using custom protocols.

I think the underlying issue is with parsing URIs that don't have slashes in them. We assume the domain terminates with a slash, but idea://open?... does not. This causes us to incorrectly identify the URI protocol.

Sep 16 2014, 4:19 PM · Audit, Diffusion
chad added a revision to T6106: Unable to Open in External Editor when using custom protocols: Restricted Differential Revision.
Sep 16 2014, 4:03 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Probably somebody forgot to update language pack, when decision was made not to support more default editors :)

Sep 16 2014, 3:48 PM · Audit, Diffusion
chad added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Haha, well that's news to me!

Sep 16 2014, 3:46 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

We're not interested in adding more protocols, which is why it's extendible.

Sep 16 2014, 3:41 PM · Audit, Diffusion
chad added a comment to T6106: Unable to Open in External Editor when using custom protocols.

We're not interested in adding more protocols, which is why it's extendible. But, we should obviously resolve this bugs!

Sep 16 2014, 3:39 PM · Audit, Diffusion
chad added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Ok, I can reproduce that.

Sep 16 2014, 3:38 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

And original subject was to add the "idea" and "phpstorm" as allowed editor protocols as well.

Sep 16 2014, 3:37 PM · Audit, Diffusion
chad renamed T6106: Unable to Open in External Editor when using custom protocols from Add PhpStorm as one of possible editors to Unable to Open in External Editor when using custom protocols.
Sep 16 2014, 3:37 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Here is the link I've mentioned:

Phabricator_OpenInEditor_Error.png (442×430 px, 41 KB)

Sep 16 2014, 3:36 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Yes, I did restarted the server. As I said I have 2 problems in one:

Sep 16 2014, 3:34 PM · Audit, Diffusion
chad closed T6106: Unable to Open in External Editor when using custom protocols as Resolved.

Ah, nevermind. I can't reproduce this, I'm able to set new values (using your examples), restart the server, and they appear as options. Did you restart your server? We should now tell you to restart when config values change, but that is a more recent feature, so your instance might not have it yet.

Sep 16 2014, 3:32 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

This line phpstorm://open?file=%f&line=%l as seen on screenshot I've originally attached to a task.

Sep 16 2014, 3:32 PM · Audit, Diffusion
chad added a comment to T6106: Unable to Open in External Editor when using custom protocols.

What specifically are you setting in your Display Preferences under "Editor"?

Sep 16 2014, 3:28 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Nope, @hach-que. Your command gives following error:

Sep 16 2014, 2:22 PM · Audit, Diffusion
hach-que added a comment to T6106: Unable to Open in External Editor when using custom protocols.

I think it should maybe be:

Sep 16 2014, 2:13 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

Changing configuration allowed to save my new editor in Display Preferences. However when click on "Open in Editor" link in "View Options" a file on a commit page I get error dialog (url http://.../help/editorprotocol/):

Sep 16 2014, 1:34 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

I've managed to set new value from command line using this command:

./bin/config set uri.allowed-editor-protocols '{"http":true, "https":true, "txmt":true, "mvim":true, "vim":true, "subl":true, "emacs":true, "editor":true, "phpstorm":true, "idea":true}'
Sep 16 2014, 1:30 PM · Audit, Diffusion
aik099 added a comment to T6106: Unable to Open in External Editor when using custom protocols.

As advised I've tried to change configuration variable value, but got this error:

Sep 16 2014, 1:16 PM · Audit, Diffusion
aik099 updated the task description for T6106: Unable to Open in External Editor when using custom protocols.
Sep 16 2014, 1:10 PM · Audit, Diffusion
aik099 created T6106: Unable to Open in External Editor when using custom protocols.
Sep 16 2014, 1:09 PM · Audit, Diffusion

Sep 12 2014

btrahan added a revision to T5966: Move scripts/repository/reparse.php to bin/repository reparse: Restricted Differential Revision.
Sep 12 2014, 10:12 PM · Diffusion
btrahan claimed T5966: Move scripts/repository/reparse.php to bin/repository reparse.

I had a hiccup finding this the other day so I'm going to do this.

Sep 12 2014, 9:11 PM · Diffusion
chad closed T6080: Best practice for Audit and Diffusion as Resolved.
Sep 12 2014, 4:52 PM · Audit, Diffusion
holmboe added a comment to T6080: Best practice for Audit and Diffusion.
In T6080#9, @chad wrote:

We also now crosslink object mentions, so it will get linked on the original commit in the timeline as well.

pasted_file (159×545 px, 33 KB)

Sep 12 2014, 8:48 AM · Audit, Diffusion
chad added a comment to T6080: Best practice for Audit and Diffusion.

You also do not have put the > or any text specifically, we'll parse and link any commit hash.

Sep 12 2014, 7:11 AM · Audit, Diffusion
chad added a comment to T6080: Best practice for Audit and Diffusion.

Is your instance at HEAD? This is a very new feature.

Sep 12 2014, 7:05 AM · Audit, Diffusion
• taoqiping added a comment to T6080: Best practice for Audit and Diffusion.

But seems no crosslink in original commitment.

pasted_file (456×1 px, 59 KB)

Sep 12 2014, 5:52 AM · Audit, Diffusion
• taoqiping added a comment to T6080: Best practice for Audit and Diffusion.

It sounds good. It can be also recognized in SVN commit message. but just title looks strange.

Sep 12 2014, 5:49 AM · Audit, Diffusion
chad added a comment to T6080: Best practice for Audit and Diffusion.

We also now crosslink object mentions, so it will get linked on the original commit in the timeline as well.

Sep 12 2014, 3:52 AM · Audit, Diffusion