Page MenuHomePhabricator

Diff on localized Windows produces unparsable diffs (newline information localization)
Closed, DuplicatePublic

Description

When creating a diff with the gnuwin32 diff utility via svn diff --diff-cmd=diff missing trailing newlines are not necessarily written with \ No newline at end of file as Differential expects them.

On a Windows installation with German localisation set up, the gnuwin32 diff utility will automatically output missing newlines in diffs as \ Kein Zeilenumbruch am Dateiende..

I suggest making the Differential diff engine be more relaxed on interpreting diffs. It could merely check for a line starting with \ .

Is there a standard for the diff format that would warrand limiting it to the full english text?

Event Timeline

ite-klass raised the priority of this task from to Needs Triage.
ite-klass updated the task description. (Show Details)
ite-klass added a project: Differential.
ite-klass added a subscriber: ite-klass.