Page MenuHomePhabricator

Best practice for Audit and Diffusion
Closed, ResolvedPublic

Assigned To
Authored By
taoqiping
Sep 12 2014, 1:10 AM
Referenced Files
F202461: pasted_file
Sep 12 2014, 5:52 AM
F202459: pasted_file
Sep 12 2014, 5:49 AM
F202417: pasted_file
Sep 12 2014, 3:52 AM

Description

Sorry to raise here again as I post it at Question, but seems not active there, so post here to see if any result.

Because we have dynamic/developer repository, and arc seems a little hard to enforce into team at first beginning, So I want to enforce audit process as code review process in team.

But because audit is by commitment, if reviewer add some comments, and raise concern to author, then author fix comments and check-in again. but then the check-in will be another audit request and even with no relation with previous one. how can we make it behave like arc diff, to check those commitments in one series, and with full context in audit.

What is best practice here, any suggestion is appreciated.

Related Objects

Event Timeline

taoqiping raised the priority of this task from to Needs Triage.
taoqiping updated the task description. (Show Details)
taoqiping added projects: Diffusion, Audit.
taoqiping added a subscriber: taoqiping.

You should be doing pre-commit reviews, if that is the workflow you desire. That way if errors are found in code, they are fixed before they land in the repository. We have no means if you're only doing code audits, of knowing if one commit is just a fix for another commit (which, even if it is, should be re-reviewed).

I agree it should be re-reviewed.

But just looking forward to see if can add relationship between two or more commits because reviewer need to know the context, and can find easily in Phabricator which may fast the process and improve efficiency. We can bind them like concept parent commitment (first one), or even a task.

And also, we may want reviewer to see the comment easily, not by open two audit requests at same time. I just want to make the process smoothly, how do you think?

You can do this by referencing the commit it fixes in the commit message. Like:

This fixes a typo introduced in rPf4f8e9bb969028666b75252fc5fcdc714da521b2

We also now crosslink object mentions, so it will get linked on the original commit in the timeline as well.

pasted_file (159×545 px, 33 KB)

It sounds good. It can be also recognized in SVN commit message. but just title looks strange.

pasted_file (345×1 px, 45 KB)

But seems no crosslink in original commitment.

pasted_file (456×1 px, 59 KB)

Is your instance at HEAD? This is a very new feature.

You also do not have put the > or any text specifically, we'll parse and link any commit hash.

In T6080#9, @chad wrote:

We also now crosslink object mentions, so it will get linked on the original commit in the timeline as well.

pasted_file (159×545 px, 33 KB)

This is a really nice addition! Been hoping this would get in eventually.

chad claimed this task.