Page MenuHomePhabricator
Differential D20457

Move BlameController away from ancient "TABLE_COMMIT"
ClosedPublic
Actions

Authored by epriestley on Apr 22 2019, 6:47 PM.
Tags
None
Referenced Files
F13146992: D20457.id48831.diff
Fri, May 3, 11:48 AM
F13139017: D20457.diff
Fri, May 3, 2:28 AM
F13138494: D20457.id.diff
Fri, May 3, 1:21 AM
Unknown Object (File)
Wed, May 1, 6:45 AM
Unknown Object (File)
Mon, Apr 29, 1:59 PM
Unknown Object (File)
Thu, Apr 25, 1:43 PM
Unknown Object (File)
Wed, Apr 24, 10:04 PM
Unknown Object (File)
Sun, Apr 21, 4:10 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Commits
rPfc92cf438225: Move BlameController away from ancient "TABLE_COMMIT"
Summary

Ref T13276. Differential has a pre-edge "TABLE_COMMIT" with about a half-dozen weird callers I'd like to get rid of.

Move blame to use edges instead. (Bonus: this makes blame respect edge edits in the UI.)

Since there are some more callers to clean up this code may move into some "RelatedObjectQueryThing" class or something, but I'm taking it one step at a time for now.

Test Plan

Screen Shot 2019-04-22 at 11.45.07 AM.png (176×312 px, 22 KB)

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22683
Build 31086: Run Core Tests
Build 31085: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
87 lines

Diff 48811

View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Loading...
Phabricator · Built by Phacility