Page MenuHomePhabricator

Move BlameController away from ancient "TABLE_COMMIT"
ClosedPublic

Authored by epriestley on Apr 22 2019, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:17 PM
Unknown Object (File)
Feb 3 2024, 10:18 PM
Unknown Object (File)
Dec 27 2023, 9:36 PM
Unknown Object (File)
Dec 24 2023, 4:33 PM
Unknown Object (File)
Dec 23 2023, 3:13 PM
Unknown Object (File)
Dec 22 2023, 3:53 AM
Unknown Object (File)
Dec 22 2023, 2:08 AM
Unknown Object (File)
Dec 20 2023, 10:58 AM
Subscribers
None

Details

Summary

Ref T13276. Differential has a pre-edge "TABLE_COMMIT" with about a half-dozen weird callers I'd like to get rid of.

Move blame to use edges instead. (Bonus: this makes blame respect edge edits in the UI.)

Since there are some more callers to clean up this code may move into some "RelatedObjectQueryThing" class or something, but I'm taking it one step at a time for now.

Test Plan

Screen Shot 2019-04-22 at 11.45.07 AM.png (176×312 px, 22 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable