Move BlameController away from ancient "TABLE_COMMIT"
ClosedPublic
Actions

Authored by epriestley on Apr 22 2019, 6:47 PM.

Details

Reviewers

Maniphest Tasks

T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time

Commits

rPfc92cf438225: Move BlameController away from ancient "TABLE_COMMIT"

Summary

Ref T13276. Differential has a pre-edge "TABLE_COMMIT" with about a half-dozen weird callers I'd like to get rid of.

Move blame to use edges instead. (Bonus: this makes blame respect edge edits in the UI.)

Since there are some more callers to clean up this code may move into some "RelatedObjectQueryThing" class or something, but I'm taking it one step at a time for now.

Test Plan

Screen Shot 2019-04-22 at 11.45.07 AM.png (176×312 px, 22 KB)

Diff Detail

Repository

rP Phabricator

Branch

audit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22683
Build 31086: Run Core Tests
Build 31085: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 22 2019, 6:47 PM

Harbormaster completed remote builds in B22683: Diff 48811.Apr 22 2019, 6:49 PM

epriestley requested review of this revision.Apr 22 2019, 6:49 PM

epriestley added a child revision: D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".Apr 22 2019, 7:06 PM

amckinley accepted this revision.Apr 23 2019, 4:30 PM

This revision is now accepted and ready to land.Apr 23 2019, 4:30 PM

Closed by commit rPfc92cf438225: Move BlameController away from ancient "TABLE_COMMIT" (authored by epriestley). · Explain WhyApr 24 2019, 12:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBlameController.php

87 lines

Diff 48811

View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Move BlameController away from ancient "TABLE_COMMIT"ClosedPublicActions