Differential D14396

Default newPage() to device-ready
ClosedPublic
Actions

Authored by epriestley on Nov 3 2015, 8:48 PM.

Details

Reviewers

chad

Maniphest Tasks

T9690: Remove calls to methods deprecated by newPage()

Commits

Restricted Diffusion Commit
rP6b194af66979: Default newPage() to device-ready

Summary

Ref T9690. The "meta viewport" tag got dropped by accident because of the sort of weird logic on the old flow.

Make the default device-ready, then just turn it off for the tiny number of non-device pages.

Test Plan

Verified meta viewport tag appears on normal pages again.
Verified it doesn't show up on non-mobile pages like Maniphest Reports.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34779.Nov 3 2015, 8:48 PM

epriestley retitled this revision from to Default newPage() to device-ready.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9690: Remove calls to methods deprecated by newPage().

chad accepted this revision.Nov 3 2015, 8:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 3 2015, 8:50 PM

Closed by commit rP6b194af66979: Default newPage() to device-ready (authored by epriestley, committed by epriestley). · Explain WhyNov 3 2015, 8:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

7 lines

Diff 34780

View Options

src/applications/base/controller/PhabricatorController.php

Default newPage() to device-readyClosedPublicActions