Page MenuHomePhabricator

Remove some low-hanging buildStandardPageResponse() methods
ClosedPublic

Authored by epriestley on Nov 2 2015, 8:52 PM.
Tags
None
Referenced Files
F14057514: D14385.id34748.diff
Sun, Nov 17, 4:07 AM
F14039704: D14385.id34771.diff
Mon, Nov 11, 6:13 AM
F14026508: D14385.id.diff
Fri, Nov 8, 1:22 AM
F14026507: D14385.diff
Fri, Nov 8, 1:22 AM
F13981665: D14385.id34771.diff
Oct 19 2024, 6:17 PM
F13981639: D14385.id.diff
Oct 19 2024, 6:01 PM
F13981617: D14385.id34748.diff
Oct 19 2024, 5:54 PM
F13981594: D14385.id34771.diff
Oct 19 2024, 5:43 PM
Subscribers
None

Details

Summary

Ref T9690. I wanted to do an example of how to do these but it looks like most of them are trivial (no callsites) and the rest are a little tricky (weird interaction with frames, or in Releeph).

Test Plan
  • Used grep to look for callsites.
  • Hit all applications locally, everything worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove some low-hanging buildStandardPageResponse() methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2015, 12:11 AM
This revision was automatically updated to reflect the committed changes.