Page MenuHomePhabricator
Differential D14596

Modernize Herald
ClosedPublic
Actions

Authored by chad on Nov 29 2015, 1:07 AM.
Tags
None
Referenced Files
F18085372: D14596.id.diff
Tue, Aug 5, 7:11 PM
F17953404: D14596.id35306.diff
Fri, Aug 1, 3:03 AM
F17943000: D14596.id.diff
Thu, Jul 31, 7:29 AM
F17940323: D14596.diff
Thu, Jul 31, 4:14 AM
F17924751: D14596.diff
Wed, Jul 30, 10:29 AM
F17664055: D14596.diff
Jul 12 2025, 6:40 PM
Unknown Object (File)
Jun 30 2025, 2:14 PM
Unknown Object (File)
Jun 28 2025, 9:59 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rP1bfddccf3925: Modernize Herald
Summary

Updates Herald to use modern methods.

Test Plan

View List, View Test Console, Run a test, View Results, View Rules, New Rule, Edit Rule, Check mobile menus.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35306.Nov 29 2015, 1:07 AM
chad retitled this revision from to Modernize Herald.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 29 2015, 1:07 AM
chad added a task: T9690: Remove calls to methods deprecated by newPage().Nov 29 2015, 1:09 AM
epriestley accepted this revision.Nov 29 2015, 4:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:45 PM
Closed by commit rP1bfddccf3925: Modernize Herald (authored by chad, committed by chad). · Explain WhyNov 30 2015, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35331

View Options

src/applications/herald/controller/HeraldController.php

Loading...
View Options

src/applications/herald/controller/HeraldNewController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/herald/controller/HeraldTestConsoleController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptListController.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptSearchEngine.php

Loading...
Phabricator · Built by Phacility