Page MenuHomePhabricator

Update Almanac for newPage
ClosedPublic

Authored by chad on Nov 28 2015, 10:40 PM.

Details

Summary

Swaps out for modern methods. Ref T9690

Test Plan

Check various Almanac pages, new devices, editing, lists.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad retitled this revision from to Update Alamanac for newPage.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad retitled this revision from Update Alamanac for newPage to Update Almanac for newPage.Nov 28 2015, 10:40 PM
epriestley edited edge metadata.

One copypasta thing

src/applications/almanac/controller/AlmanacConsoleController.php
43

This one is great!

src/applications/almanac/controller/AlmanacDeviceEditController.php
154

Should be $title.

src/applications/almanac/controller/AlmanacDeviceViewController.php
60

Should be $title.

src/applications/almanac/controller/AlmanacInterfaceEditController.php
145

Should be $title.

src/applications/almanac/controller/AlmanacNetworkEditController.php
133

Should be $title.

src/applications/almanac/controller/AlmanacNetworkViewController.php
45

Should be $title.

This revision is now accepted and ready to land.Nov 28 2015, 10:42 PM
chad edited edge metadata.
  • derps
This revision was automatically updated to reflect the committed changes.