Page MenuHomePhabricator
Differential D20469

Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions
ClosedPublic
Actions

Authored by epriestley on Apr 23 2019, 6:05 PM.
Tags
None
Referenced Files
F13187709: D20469.diff
Sat, May 11, 4:42 AM
Unknown Object (File)
Tue, May 7, 3:59 PM
Unknown Object (File)
Tue, May 7, 3:50 AM
Unknown Object (File)
Fri, May 3, 7:34 AM
Unknown Object (File)
Thu, May 2, 8:49 PM
Unknown Object (File)
Thu, Apr 25, 1:37 AM
Unknown Object (File)
Tue, Apr 23, 9:39 PM
Unknown Object (File)
Fri, Apr 19, 3:11 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Summary

Depends on D20468. Ref T13276. See PHI1008.

When a commit or revision "reverts <hash>", and that's the hash of a commit which has a revision, also write a "reverts" edge to the revision.

Test Plan

Created "reverts X" objects for:

  • a revision;
  • a commit;
  • a commit with a revision (both got marked properly).

Diff Detail

Repository
rP Phabricator
Branch
audit12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22695
Build 31110: Run Core Tests
Build 31109: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
29 lines
differential/
editor/
18 lines
diffusion/
query/
70 lines

Diff 48823

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php

Loading...
Phabricator · Built by Phacility