Page MenuHomePhabricator

Google ChromeTag
ActivePublic

Members (2)

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Anything having to do with Google Chrome and how Phabricator works on it...!

Recent Activity

Sep 28 2020

epriestley added a revision to T13564: Remarkup tables should show all content when printed to PDF: D21472: When printing, wrap all content in Remarkup tables more aggressively.
Sep 28 2020, 4:22 PM · Google Chrome, Remarkup

Aug 11 2020

epriestley added a comment to T13564: Remarkup tables should show all content when printed to PDF.

Adding overflow-wrap: anywhere appears to fix this without breaking anything.

Aug 11 2020, 5:35 PM · Google Chrome, Remarkup
epriestley triaged T13564: Remarkup tables should show all content when printed to PDF as Normal priority.
Aug 11 2020, 5:17 PM · Google Chrome, Remarkup

Nov 8 2019

epriestley added a comment to T13451: Chrome double-click selection behavior has changed in LayoutNG.

I'm planning to give Chrome some time to triage the report. If it sits there for a while or they decide it's how LayoutNG is going to handle this case, I'll look for workarounds. I don't think our intent/markup is totally unambiguous, and it may be reasonable to decide that this behavior is acceptable, even though Safari and Firefox have different behavior.

Nov 8 2019, 4:10 PM · Google Chrome
epriestley updated the task description for T13451: Chrome double-click selection behavior has changed in LayoutNG.
Nov 8 2019, 4:07 PM · Google Chrome
epriestley renamed T13451: Chrome double-click selection behavior has changed in LayoutNG from Chrome double-click selection behavior has changed in Chrome ~78? to Chrome double-click selection behavior has changed in LayoutNG.
Nov 8 2019, 4:06 PM · Google Chrome
epriestley added a comment to T13451: Chrome double-click selection behavior has changed in LayoutNG.

Here's a simple reproduction case:

Nov 8 2019, 4:05 PM · Google Chrome
epriestley triaged T13451: Chrome double-click selection behavior has changed in LayoutNG as Low priority.
Nov 8 2019, 3:41 PM · Google Chrome

Sep 24 2019

epriestley lowered the priority of T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior from Normal to Wishlist.

This now appears to be fixed in the release version of Chrome. We can remove the workaround in some future change.

Sep 24 2019, 6:10 PM · Google Chrome

Sep 13 2019

epriestley added a revision to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior: D20812: Work around rendering engine freeze in Chrome 77 affecting workboards.
Sep 13 2019, 1:59 AM · Google Chrome

Sep 11 2019

epriestley added a comment to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior.

I upstreamed this to Chrome here: https://bugs.chromium.org/p/chromium/issues/detail?id=1003002

Sep 11 2019, 6:00 PM · Google Chrome
epriestley triaged T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior as Normal priority.
Sep 11 2019, 5:53 PM · Google Chrome

Aug 6 2017

chad closed T8122: Unable to scroll on mobile if horizontal scroll is available as Invalid.

No longer valid as far as I can find.

Aug 6 2017, 3:52 AM · Google Chrome, PHUI, Mobile

Jul 9 2017

chad removed the image for Google Chrome.
Jul 9 2017, 7:35 PM

Jan 12 2017

epriestley added a comment to T12032: Make sure Chrome 55 anchor issue does not impact Differential.

Chrome 56 has merged a fix for this so it should be moot in the not-too-distant future, although I'm not exactly sure what the Chrome release schedule looks like. If this only impacts ghost inlines for a few more weeks it's pretty tempting to just wait for it to resolve itself, but I may be digging around in that code soon so perhaps I'll take a more detailed look.

Jan 12 2017, 9:06 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
chris.siden added a comment to T12032: Make sure Chrome 55 anchor issue does not impact Differential.

Is it possible that this issue effects Differential but only for inline-comments that have been ported forward from a previous diff (i.e. the ones that are rendered as slightly faded). I see this issue on this instance with this revision: https://secure.phabricator.com/D15675, none of the anchor links in the timeline work for me when I use Chrome 55, but I don't see the same issue on reviews where comments are on the most-recent diff (not faded).

Jan 12 2017, 8:53 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential

Dec 28 2016

epriestley closed T12032: Make sure Chrome 55 anchor issue does not impact Differential as Resolved.

We haven't received more information about this in about a week and can't reproduce it, so we can't move forward. I'm going to close this until we get new information.

Dec 28 2016, 4:31 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential

Dec 22 2016

epriestley added a project to T12032: Make sure Chrome 55 anchor issue does not impact Differential: Bug Report (Needs Information).
Dec 22 2016, 2:04 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential

Dec 20 2016

epriestley added a project to T12032: Make sure Chrome 55 anchor issue does not impact Differential: Phacility.
Dec 20 2016, 1:00 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley added a comment to T12032: Make sure Chrome 55 anchor issue does not impact Differential.

I wasn't immediately able to reproduce this:

Dec 20 2016, 1:00 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential

Dec 19 2016

epriestley created T12032: Make sure Chrome 55 anchor issue does not impact Differential.
Dec 19 2016, 9:35 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential

Jul 28 2016

epriestley closed T11386: Weird effect on closed tasks in graph view as Resolved by committing rPcebf4bbec6ba: In Task Graphs, provide a parent/child hint and fix weird strikethrough.
Jul 28 2016, 6:50 PM · Google Chrome, Bug Report
epriestley added a revision to T11386: Weird effect on closed tasks in graph view: D16342: In Task Graphs, provide a parent/child hint and fix weird strikethrough.
Jul 28 2016, 6:48 PM · Google Chrome, Bug Report
sshannin added a comment to T11386: Weird effect on closed tasks in graph view.

No biggie, although the UI effect is obviously crucial for my org

Jul 28 2016, 12:40 AM · Google Chrome, Bug Report
chad reopened T11386: Weird effect on closed tasks in graph view as "Open".

Whoops, yeah the strikethrough isn't for some reason. Sorry I thought you meant an issue with the graph itself.

Jul 28 2016, 12:34 AM · Google Chrome, Bug Report
chad merged task T11386: Weird effect on closed tasks in graph view into T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Jul 28 2016, 12:33 AM · Google Chrome, Bug Report
sshannin created T11386: Weird effect on closed tasks in graph view.
Jul 28 2016, 12:32 AM · Google Chrome, Bug Report

Jun 30 2016

epriestley closed T11238: Hello as Spite.
Jun 30 2016, 10:44 AM · Google Chrome, Phabot, Bug Report
kingbonio added a comment to T11238: Hello.

I've located the mainframe and uploaded the downloads

Jun 30 2016, 9:04 AM · Google Chrome, Phabot, Bug Report
kingbonio created T11238: Hello.
Jun 30 2016, 9:03 AM · Google Chrome, Phabot, Bug Report

Feb 20 2016

ftdysa added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Ah cool, good to know. Thanks for the quick fix!

Feb 20 2016, 12:15 AM · Remarkup, Google Chrome, Bug Report

Feb 19 2016

epriestley closed T10396: Remarkup toolbar actions always cause comment box to scroll to bottom as Resolved by committing rP7b1b146620b5: Save, then restore scroll position in Chrome textareas on remarkup assist.
Feb 19 2016, 10:55 PM · Remarkup, Google Chrome, Bug Report
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Yeah, I came to approximately the same conclusion. Save + restore on the scroll position appears to be a complete fix as far as I can tell.

Feb 19 2016, 10:55 PM · Remarkup, Google Chrome, Bug Report
epriestley added a revision to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom: D15313: Save, then restore scroll position in Chrome textareas on remarkup assist.
Feb 19 2016, 10:49 PM · Remarkup, Google Chrome, Bug Report
ftdysa added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

So I looked into this and it is the call to area.focus() in the setSelectionRange method in https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/core/TextAreaUtils.js (unsure what line, my view of this file is plaintext here) that causes the scrolling. I removed this line and it seemed to have the expected behavior but who knows what other problems removing it may cause.

Feb 19 2016, 10:19 PM · Remarkup, Google Chrome, Bug Report
chad added projects to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom: Google Chrome, Remarkup.
Feb 19 2016, 9:25 PM · Remarkup, Google Chrome, Bug Report

Feb 2 2016

chad updated the image for Google Chrome from F1064814: profile to F1087336: profile.
Feb 2 2016, 4:54 PM

Jan 19 2016

chad set the image for Google Chrome to F1064814: profile.
Jan 19 2016, 10:07 PM

Oct 22 2015

epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

Yeah, I have the same guess as @chad on this.

Oct 22 2015, 1:57 PM · Differential, Google Chrome
oujesky closed T9612: Unable to scroll after clicking on inline comment link in Chrome 46 as Invalid.

Yes, you are right, we are on version from April 2015. Sorry for that.

Oct 22 2015, 1:57 PM · Differential, Google Chrome
chad added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

I presume you are behind D12789, which was May 2015.

Oct 22 2015, 1:53 PM · Differential, Google Chrome
oujesky added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

I tried to reproduce the issue here, but it looks fine (not sure which version is deployed here). I tried on https://secure.phabricator.com/D14297#inline-48363 and I can scroll with every means.

Oct 22 2015, 1:53 PM · Differential, Google Chrome
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

This does not reproduce for me with Chrome 46 on Windows 7.

Oct 22 2015, 1:52 PM · Differential, Google Chrome
oujesky added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

Tried on Windows 7 and Windows 10.

Oct 22 2015, 1:45 PM · Differential, Google Chrome
chad added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

Mac Desktop / Mouse / Chrome 46 also works fine. @oujesky what OS are you running and is your Phabricator at HEAD?

Oct 22 2015, 1:42 PM · Differential, Google Chrome
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

I also can't reproduce this with a similar setup (OSX / Macbook / Chrome 46).

Oct 22 2015, 1:32 PM · Differential, Google Chrome
chad added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

I gave a quick test on a laptop / Mac / Chrome 46 and can't really reproduce anything on https://secure.phabricator.com/D14268#inline-48344. @epriestley can you?

Oct 22 2015, 1:31 PM · Differential, Google Chrome
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

See T7740 / https://code.google.com/p/chromium/issues/detail?id=473657 for a previous adventure with scrolling Chrome anchors.

Oct 22 2015, 1:11 PM · Differential, Google Chrome
oujesky created T9612: Unable to scroll after clicking on inline comment link in Chrome 46.
Oct 22 2015, 10:57 AM · Differential, Google Chrome

May 14 2015

epriestley closed T7740: Chrome exhibits weird scrolling jumping with anchor in the URL as Resolved.

This should be resolved in HEAD because we no longer frame the page content. Chrome still has the underlying bug.

May 14 2015, 11:07 PM · Google Chrome