Projects Macros

MacrosProject
ActivePublic
Watch Project

Members (3)

joshuaspence (Joshua Spence)
Code Monkey
AnhNhan (Anh Nhan Nguyen)
Searching for a job :S
btrahan (Bob Trahan)
Utility player
View All

Watchers

This project does not have any watchers.
View All

Details

Description

The best feature of Phabricator and Remarkup is Macros.

welcometotheparty

Recent Activity
View All

Feb 20 2019

epriestley closed T12746: Add support for PHUIPinboardItemView to timeline/transactions as Wontfix.

Probably a good idea, but not worth keeping a task around for.

Feb 20 2019, 11:33 PM · Maniphest, Macros, Transactions

Jan 14 2019

epriestley closed T6670: Macro images don't show up on html emails if your instance requires logins as Resolved.

Screen Shot 2019-01-14 at 11.48.37 AM.png (658×741 px, 679 KB)

Jan 14 2019, 7:49 PM · Macros, Mail

epriestley added a comment to T6670: Macro images don't show up on html emails if your instance requires logins.

Jan 14 2019, 7:48 PM · Macros, Mail

Jan 2 2019

epriestley moved T6670: Macro images don't show up on html emails if your instance requires logins from Backlog to Soon? on the Mail board.

Jan 2 2019, 3:22 PM · Macros, Mail

Jul 26 2018

epriestley closed T13172: Saved meme-maker results are case-insensitive as Resolved by committing rP9e1a1577c3a2: Make the meme cache case-sensitive.

Jul 26 2018, 7:15 PM · Macros

epriestley added a revision to T13172: Saved meme-maker results are case-insensitive: D19537: Make the meme cache case-sensitive.

Jul 26 2018, 4:46 PM · Macros

Jul 20 2018

epriestley added a comment to T13172: Saved meme-maker results are case-insensitive.

I think in D19196 the engine always generated uppercase text, but that got changed in D19200, perhaps?

Jul 20 2018, 10:26 PM · Macros

epriestley added a comment to T13172: Saved meme-maker results are case-insensitive.

how did this ever escape us

Jul 20 2018, 10:23 PM · Macros

amckinley triaged T13172: Saved meme-maker results are case-insensitive as Unbreak Now! priority.

Jul 20 2018, 10:22 PM · Macros

Mar 13 2018

epriestley added a comment to T5741: Transparent meme animated gifs show up with a black background.

I wasn't able to reproduce the black background issue, exactly, but here's what I changed:

Mar 13 2018, 4:28 PM · Macros

epriestley closed T5741: Transparent meme animated gifs show up with a black background as Resolved by committing rPa4a390fe2d9f: Use "-dispose background" to improve reassembly of GIFs with transparency.

Mar 13 2018, 4:20 PM · Macros

epriestley added a revision to T5741: Transparent meme animated gifs show up with a black background: D19214: Use "-dispose background" to improve reassembly of GIFs with transparency.

Mar 13 2018, 4:07 PM · Macros

Mar 8 2018

epriestley closed T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy as Resolved.

Mar 8 2018, 7:24 PM · Remarkup, Security, Macros

epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

very good memes

Mar 8 2018, 7:19 PM · Remarkup, Security, Macros

epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

Mar 8 2018, 7:19 PM · Remarkup, Security, Macros

epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

hmmm

Mar 8 2018, 7:18 PM · Remarkup, Security, Macros

epriestley closed T5258: Memes use older image transform code without modern error handling as Resolved by committing rPa3d282d33efe: Somewhat improve meme transform code so it is merely very bad.

Mar 8 2018, 7:09 PM · Restricted Project, Macros, Files

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19203: Possibly fix memes in email.

Mar 8 2018, 7:04 PM · Remarkup, Security, Macros

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19201: Somewhat improve meme transform code so it is merely very bad.

Mar 8 2018, 6:50 PM · Remarkup, Security, Macros

epriestley added a revision to T5258: Memes use older image transform code without modern error handling: D19201: Somewhat improve meme transform code so it is merely very bad.

Mar 8 2018, 6:50 PM · Restricted Project, Macros, Files

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19200: PhabricatorMemeEngine HA HA HA HA.

Mar 8 2018, 5:38 PM · Remarkup, Security, Macros

epriestley added a revision to T5258: Memes use older image transform code without modern error handling: D19200: PhabricatorMemeEngine HA HA HA HA.

Mar 8 2018, 5:38 PM · Restricted Project, Macros, Files

epriestley added a revision to T5258: Memes use older image transform code without modern error handling: D19198: Remove some old image transform code with no callsites.

Mar 8 2018, 4:31 PM · Restricted Project, Macros, Files

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19198: Remove some old image transform code with no callsites.

Mar 8 2018, 4:31 PM · Remarkup, Security, Macros

epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

Actually, HTML mail has an issue now.

Mar 8 2018, 4:00 PM · Remarkup, Security, Macros

epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

This is technically fixed now but the meme stuff is real old and rough so I'm going to maybe make some kind of effort to get through more of T5258, etc.

Mar 8 2018, 3:56 PM · Remarkup, Security, Macros

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19196: Always serve "{meme ...}" from the CDN domain, never from the primary domain.

Mar 8 2018, 3:40 PM · Remarkup, Security, Macros

epriestley closed T12542: Build a macro typeahead as Wontfix.

This is conceptually easy but no trigger character really makes a ton of sense. I'm going to decline this until it's more clear what the desired behavior actually is.

Mar 8 2018, 3:09 PM · Macros, Remarkup

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19194: When rendering "{image ...}" images, check the cache and just render a direct "<img />" tag if possible.

Mar 8 2018, 2:51 PM · Remarkup, Security, Macros

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19193: When proxying an "{image ...}" image fails, show the user an error message.

Mar 8 2018, 1:36 PM · Remarkup, Security, Macros

epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: D19192: Separate the "{img ...}" remarkup rule into separate parse and markup phases.

Mar 8 2018, 1:03 PM · Remarkup, Security, Macros

Mar 7 2018

epriestley triaged T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy as Normal priority.

Mar 7 2018, 11:11 PM · Remarkup, Security, Macros

Feb 9 2018

epriestley closed T6121: Support non-latin characters in macros as Resolved by committing rP4fef0a612824: Allow a wider range of characters in macro names, including emoji.

Feb 9 2018, 10:34 PM · Macros

epriestley added a revision to T6121: Support non-latin characters in macros: D19051: Allow a wider range of characters in macro names, including emoji.

Feb 9 2018, 10:32 PM · Macros

epriestley added a comment to T6121: Support non-latin characters in macros.

Feb 9 2018, 10:18 PM · Macros

Sep 30 2017

epriestley added a comment to T12998: Image macros not working in Differential.

Well, it half-works in email, so that's something!

Sep 30 2017, 1:02 AM · Differential, Macros

epriestley added a comment to T12998: Image macros not working in Differential.

You can do this

Sep 30 2017, 1:01 AM · Differential, Macros

amckinley closed T12998: Image macros not working in Differential as Resolved.

Ahhh, so you can't have multiple adjacent macros on the same line; that was my problem. I guess that could be special-cased, which would be linear with the number of "tokens that are macros coming before a non-macro" appearing on a line, but I'm probably the only one clamoring for multiple horizontally aligned parrots.

Sep 30 2017, 1:00 AM · Differential, Macros

epriestley added a comment to T12998: Image macros not working in Differential.

They need to be on their own line. I think this rule got added in 2011, shortly after I left FB.

Sep 30 2017, 12:56 AM · Differential, Macros

amckinley created T12998: Image macros not working in Differential.

Sep 30 2017, 12:32 AM · Differential, Macros

Aug 3 2017

epriestley merged T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.

Aug 3 2017, 5:40 PM · Restricted Project, Files, Macros

epriestley merged task T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.

Aug 3 2017, 5:40 PM · Feature Request, Macros

epriestley added a comment to T12950: Regenerating thumbnails for memes is difficult.

I'm just going to merge this into T5258. There are two separate issues here:

Aug 3 2017, 5:40 PM · Feature Request, Macros

chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

This bug does exist on this server, but unclear why. Maybe related to size of image, but probably best solution is some command-line tool to regenerate all file transforms? I don't think making PHIDs easy to find inside the app is very user friendly.

Aug 3 2017, 5:31 PM · Feature Request, Macros

Aug 2 2017

joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.

In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros

chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

Why did they need regenerating in the first place?

Aug 2 2017, 9:38 PM · Feature Request, Macros

joshuaspence created T12950: Regenerating thumbnails for memes is difficult.

Aug 2 2017, 9:12 PM · Feature Request, Macros

May 23 2017

chad added projects to T12746: Add support for PHUIPinboardItemView to timeline/transactions: Macros, Maniphest.

May 23 2017, 10:23 PM · Maniphest, Macros, Transactions

May 15 2017

epriestley added a comment to T4096: Generated gif-macros are not animated.

@jeffprouty Shoot us an email at support@phacility.com with details about your instance and the issue you're hitting if you're a paying customer; see also https://admin.phacility.com/book/phacility/article/support/.

May 15 2017, 5:54 PM · Macros

jeffprouty added a comment to T4096: Generated gif-macros are not animated.

Just confirming this is broken for phacility hosted instances (it is for us at least) and that there is no work around to date? Should this be it's own issue? Or should we reopen this issue?

May 15 2017, 5:51 PM · Macros