Page MenuHomePhabricator

Image macros not working in Differential
Closed, ResolvedPublic

Description

See attached screenshot, or D18665 for example. Expected behavior: parrots. Actual behavior: zero parrots. Appears to be working elsewhere, or at least in Maniphest:

parrot

Actually it looks like macros need to be on their own line now? I can sometimes get macros to work in Differential, but it appears non-deterministic.

Screen Shot 2017-09-29 at 5.31.11 PM.png (156×466 px, 25 KB)

Event Timeline

They need to be on their own line. I think this rule got added in 2011, shortly after I left FB.

I think there was some kind of sports game rivalry, I think between the "North Oregon Short Ducks" and the "South Oregon Long Ducks", and fans of one or the other team made macros for the, a, etc., with 4000x4000px banners supporting their team.

We could conceivably revisit this rule but if we're going to change the syntax we should probably add some kind of ~#@macro@#~ markup to it since we have the inline typeahead and such now.

amckinley claimed this task.

Ahhh, so you can't have multiple adjacent macros on the same line; that was my problem. I guess that could be special-cased, which would be linear with the number of "tokens that are macros coming before a non-macro" appearing on a line, but I'm probably the only one clamoring for multiple horizontally aligned parrots.

You can do this

{meme, src=parrot} {meme, src=parrot} {meme, src=parrot} {meme, src=parrot}

...but it produces this:

Macro parrot:  Macro parrot:  Macro parrot:  Macro parrot:

...which is both wrongly GIF'd and not what you want anyway.

Well, it half-works in email, so that's something!