Phabricator daemon infrastructure.
Mar 10 2021
Although I didn't look particularly hard, I can't immediately find any more evidence that this is occurring in production.
Mar 2 2021
Mar 1 2021
When we are importing a commit, we often don't have any legitimate user to act as: the commit may come from an observed repository (so we never authenticated a pusher), and the "Author" and "Committer" strings are arbitrary and untrusted in Git and Mercurial.
All three of these are almost certainly diffusion.rawdiffquery, I think the first one just predated D21463 reaching production so it didn't show the method.
Feb 27 2021
Feb 24 2021
Feb 2 2021
Update the daemon UI to break tasks down by object/container.
See T13591. Tasks now (may) have a containerPHID, and whatever daemon console changes are made in service of dynamic generation should also expose container objects.
Feb 1 2021
Jan 29 2021
Jan 23 2021
Jan 22 2021
These parts seem likely resolved once I convince myself the patches so far actually work:
I have a change to add containerPHID locally, but it ends up having relatively high complexity because several other patches (including 20190909.herald.01.rebuild.php) call PhabricatorRebuildIndexesWorker::rebuildObjectsWithQuery(...), which does not work if executed in sequence prior to a worker queue schema change.
This also relates slightly to T13580, but I believe the two issues are addressable independently.
However, I'd like to have a better understanding of how we're reaching this state, and I'm not satisfied that these repositories are going down the "natural" pathway (of changing ref definitions after the import starts) and suspect there is some more complicated interaction at play here.
I'm hoping to land at least a narrow fix for this today to support an import in PHI1979 tomorrow. However, I'd like to have a better understanding of how we're reaching this state, and I'm not satisfied that these repositories are going down the "natural" pathway (of changing ref definitions after the import starts) and suspect there is some more complicated interaction at play here.
Oct 26 2020
I know it's an old thread, but I am encountering what is, as far as I can tell, exactly the same issue. I'm on the latest version of trunk (~Oct 26) with php 5.5.9 on Linux 3.13.0. I also observed the issue on the May 30 version.
Oct 16 2020
Sep 17 2020
This synthetic script demonstrates the conceptual problem with FutureIterator:
Sep 16 2020
Sep 8 2020
Sep 4 2020
Aug 17 2020
Aug 12 2020
Aug 11 2020
Jul 24 2020
In D21426, I removed phd.trace and phd.verbose.
Jul 23 2020
The call sequence here is approximately: