Page MenuHomePhabricator

Lift logic for queueing commit import tasks into RepositoryEngine
ClosedPublic

Authored by epriestley on Jan 22 2021, 10:50 PM.

Details

Summary

Ref T13591. There are currently two pathways to queue an import task for a commit: via repository discovery, or via a ref becoming permanent.

These pathways duplicate some logic and have behavioral differences: one does not set objectPHID properly, one does not set the priority correctly.

Unify these pathways, make them both set objectPHID, and make them both use the same priority logic.

Test Plan
  • Discovered refs.
  • See later changes in this series for more complete test cases.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.