Page MenuHomePhabricator

Mostly remove "STDERR" and "STDOUT" constants from Arcanist
ClosedPublic

Authored by epriestley on Apr 28 2022, 10:25 PM.
Tags
None
Referenced Files
F18230100: D21794.id.diff
Wed, Aug 20, 12:00 PM
F18213248: D21794.id51950.diff
Tue, Aug 19, 4:38 AM
F18106676: D21794.id.diff
Sun, Aug 10, 11:12 PM
F18082235: D21794.id51954.diff
Tue, Aug 5, 4:47 AM
F18044050: D21794.diff
Sun, Aug 3, 6:43 AM
F17868115: D21794.id51955.diff
Mon, Jul 28, 7:17 AM
F17845200: D21794.diff
Sun, Jul 27, 3:09 AM
F17842489: D21794.diff
Sat, Jul 26, 11:42 PM
Subscribers

Details

Summary

Ref T13675. Ref T13556. The "STDOUT" and "STDERR" constants are defined by the PHP CLI SAPI, in cli_register_file_handles().

The "native arc" embedded PHP wrapper doesn't define these, and there's no real reason to define them, since they're just defined in terms of the PHP stream wrappers ("php://stdin", etc) anyway.

This patch isn't exhaustive (and a subsequent change should add lint, rejecting these magic constants) but is just trying to make native arc functional.

Test Plan

Created this revision with a standalone native arc binary.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
cspeckmim added inline comments.
src/utils/PhutilSystem.php
31

This and the next function look swapped. This is getStderr but is initializing and returning stdout, and vice-versa below

src/utils/PhutilSystem.php
31

Ah, quite. Thanks!

  • Fix stderr vs stdout mixup.
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 6:58 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.