Page MenuHomePhabricator

Mostly remove "STDERR" and "STDOUT" constants from Arcanist
ClosedPublic

Authored by epriestley on Apr 28 2022, 10:25 PM.
Tags
None
Referenced Files
F12194237: D21794.diff
Sun, Sep 24, 6:40 PM
F12192656: D21794.diff
Sat, Sep 23, 2:36 AM
F12187938: D21794.id51955.diff
Mon, Sep 18, 9:19 AM
F12186144: D21794.id.diff
Sat, Sep 16, 5:26 PM
F12186141: D21794.id51950.diff
Sat, Sep 16, 5:26 PM
F12186139: D21794.id51955.diff
Sat, Sep 16, 5:23 PM
F12186138: D21794.id51954.diff
Sat, Sep 16, 5:23 PM
F12186095: D21794.diff
Sat, Sep 16, 4:49 PM
Subscribers

Details

Summary

Ref T13675. Ref T13556. The "STDOUT" and "STDERR" constants are defined by the PHP CLI SAPI, in cli_register_file_handles().

The "native arc" embedded PHP wrapper doesn't define these, and there's no real reason to define them, since they're just defined in terms of the PHP stream wrappers ("php://stdin", etc) anyway.

This patch isn't exhaustive (and a subsequent change should add lint, rejecting these magic constants) but is just trying to make native arc functional.

Test Plan

Created this revision with a standalone native arc binary.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
cspeckmim added inline comments.
src/utils/PhutilSystem.php
31

This and the next function look swapped. This is getStderr but is initializing and returning stdout, and vice-versa below

src/utils/PhutilSystem.php
31

Ah, quite. Thanks!

  • Fix stderr vs stdout mixup.
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 6:58 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.