Page MenuHomePhabricator

Mostly remove "STDERR" and "STDOUT" constants from Arcanist
ClosedPublic

Authored by epriestley on Apr 28 2022, 10:25 PM.
Tags
None
Referenced Files
F19901980: D21794.diff
Mon, Mar 30, 2:13 PM
F19901973: D21794.diff
Mon, Mar 30, 2:10 PM
F19823291: D21794.diff
Mar 7 2026, 11:10 AM
F19813296: D21794.diff
Mar 4 2026, 8:37 AM
F19673271: D21794.id51950.diff
Feb 8 2026, 5:31 AM
F19664475: D21794.id51950.diff
Feb 7 2026, 11:57 AM
F19519322: D21794.diff
Jan 16 2026, 4:22 AM
F19503635: D21794.id51950.diff
Jan 9 2026, 12:53 AM
Subscribers

Details

Summary

Ref T13675. Ref T13556. The "STDOUT" and "STDERR" constants are defined by the PHP CLI SAPI, in cli_register_file_handles().

The "native arc" embedded PHP wrapper doesn't define these, and there's no real reason to define them, since they're just defined in terms of the PHP stream wrappers ("php://stdin", etc) anyway.

This patch isn't exhaustive (and a subsequent change should add lint, rejecting these magic constants) but is just trying to make native arc functional.

Test Plan

Created this revision with a standalone native arc binary.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
cspeckmim added inline comments.
src/utils/PhutilSystem.php
31

This and the next function look swapped. This is getStderr but is initializing and returning stdout, and vice-versa below

src/utils/PhutilSystem.php
31

Ah, quite. Thanks!

  • Fix stderr vs stdout mixup.
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 6:58 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.