Paths

Table of Contentst

Differential D21513

Correct the behavior of "bin/repository discover --repair"
ClosedPublic
Actions

Authored by epriestley on Jan 22 2021, 8:25 PM.

Tags

None

Referenced Files

	F14053383: D21513.diff
	Fri, Nov 15, 3:13 PM

	F14040406: D21513.diff
	Mon, Nov 11, 9:55 AM

	F14023602: D21513.diff
	Thu, Nov 7, 3:04 AM

	Unknown Object (File)
	Oct 13 2024, 9:50 PM

	Unknown Object (File)
	Oct 2 2024, 6:27 AM

	Unknown Object (File)
	Oct 1 2024, 9:20 PM

	Unknown Object (File)
	Sep 6 2024, 8:36 AM

	Unknown Object (File)
	Sep 6 2024, 8:36 AM

View All 83 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT"
Commits: rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair"

Summary

Ref T13591. Since D8781, this flag does not function correctly in Git and Mercurial repositories, since ref discovery pre-fills the cache.

Move the "don't look at the database" behavior the flag enables into the cache lookup. D8781 should have been slightly more aggressive and done this, it was just overlooked.

Test Plan

Ran bin/repository discover --help and read the updated help text.
Ran bin/repository discover --repair in a fully-discovered Git repository.
- Before: no effect.
- After: full rediscovery.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 22 2021, 8:25 PM

Harbormaster completed remote builds in B25018: Diff 51207.Jan 22 2021, 8:26 PM

epriestley requested review of this revision.Jan 22 2021, 8:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2021, 3:51 AM

Closed by commit rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair".

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

14 lines

management/

PhabricatorRepositoryManagementDiscoverWorkflow.php

17 lines

Diff 51215

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...

src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php

Loading...