Page MenuHomePhabricator

Correct the behavior of "bin/repository discover --repair"
ClosedPublic

Authored by epriestley on Jan 22 2021, 8:25 PM.

Details

Summary

Ref T13591. Since D8781, this flag does not function correctly in Git and Mercurial repositories, since ref discovery pre-fills the cache.

Move the "don't look at the database" behavior the flag enables into the cache lookup. D8781 should have been slightly more aggressive and done this, it was just overlooked.

Test Plan
  • Ran bin/repository discover --help and read the updated help text.
  • Ran bin/repository discover --repair in a fully-discovered Git repository.
    • Before: no effect.
    • After: full rediscovery.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2021, 3:51 AM
This revision was automatically updated to reflect the committed changes.