Page MenuHomePhabricator

Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag
ClosedPublic

Authored by epriestley on Jan 22 2021, 9:41 PM.
Tags
None
Referenced Files
F19083403: D21514.id51213.diff
Tue, Dec 2, 12:35 PM
F19077483: D21514.diff
Mon, Dec 1, 3:14 PM
F19077346: D21514.diff
Mon, Dec 1, 2:59 PM
F19040729: D21514.diff
Wed, Nov 26, 1:30 PM
F18993583: D21514.id51208.diff
Wed, Nov 19, 8:11 AM
F18852269: D21514.diff
Oct 31 2025, 7:45 AM
F18850562: D21514.id.diff
Oct 30 2025, 5:49 PM
F18804069: D21514.id.diff
Oct 18 2025, 5:46 AM
Subscribers
None

Details

Summary

Ref T13591. This is an old flag with an old name, and there's an import bug because the outdated concept of "closable" is confusing two different behaviors.

This flag should mean only "is this commit reachable from a permanent ref?". Rename it to "IMPORTED_PERMANENT" to make that more clear.

Rename the "Unpublished" query to "Permanent" to make that more clear, as well.

Test Plan
  • Grepped for all affected symbols.
  • Queried for all commmits, permament commits, and impermanent commits.
  • Ran repository discovery.
  • See also further changes in this change series for more extensive tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable