Page MenuHomePhabricator

Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag
ClosedPublic

Authored by epriestley on Jan 22 2021, 9:41 PM.

Details

Summary

Ref T13591. This is an old flag with an old name, and there's an import bug because the outdated concept of "closable" is confusing two different behaviors.

This flag should mean only "is this commit reachable from a permanent ref?". Rename it to "IMPORTED_PERMANENT" to make that more clear.

Rename the "Unpublished" query to "Permanent" to make that more clear, as well.

Test Plan
  • Grepped for all affected symbols.
  • Queried for all commmits, permament commits, and impermanent commits.
  • Ran repository discovery.
  • See also further changes in this change series for more extensive tests.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.