Page MenuHomePhabricator

Correct some issues around IMPORTED_PERMANENT in RefEngine
ClosedPublic

Authored by epriestley on Jan 23 2021, 12:38 AM.
Tags
None
Referenced Files
F18762504: D21518.diff
Mon, Oct 6, 7:22 PM
F18756043: D21518.id.diff
Sun, Oct 5, 8:53 AM
F18734376: D21518.id.diff
Tue, Sep 30, 10:53 PM
F18659756: D21518.id.diff
Tue, Sep 23, 3:30 PM
F18646446: D21518.id51212.diff
Sep 19 2025, 9:58 AM
F18640629: D21518.diff
Sep 18 2025, 5:51 PM
F18600918: D21518.id.diff
Sep 13 2025, 10:59 AM
F18592238: D21518.diff
Sep 12 2025, 11:43 AM
Subscribers
None

Details

Summary

Ref T13591. Fixes a few issues with the recent updates here discovered in more thorough testing.

Test Plan
  • Stopped the daemons.
  • Created a new copy of Phabricator in Diffusion.
  • Pulled it with bin/repository pull ....
    • Got 17,278 commits on disk with git log --all --format=%H.
  • Set permanent refs to "master".
  • Discovered it with bin/repository discover ....
    • This took 31.5s and inserted 17,278 tasks.
    • Verified that all tasks have priority 4,000 (PRIORITY_IMPORT).
    • Observed that 16,799 commits have IMPORTED_PERMANENT and 479 commits do not.
      • This matches git log master --format=%H exactly.
  • Ran bin/repository refs .... Expected no changes and saw no changes.
  • Ran bin/worker execute --active for a minute or two. It processed all the impermanent changes first (since bin/worker is LIFO and these are supposed to process last).
    • Ran bin/repository refs. Expected no changes and saw no changes.
    • Marked all refs as permanent.
    • Starting state: 16,009 message tasks, all at priority 4000.
    • Ran bin/repository refs, expecting 479 new tasks at priority 4000.
    • Saw count rise to 16,488 as expected.
    • Saw all the new tasks have priority 4000 and all commits now have the IMPORTED_PERMANENT flag.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable